New issue
Advanced search Search tips

Issue 865552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 7
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 860347



Sign in to add a comment

Oscillator.detune nominal range is reduced

Project Member Reported by rtoy@chromium.org, Jul 19

Issue description

The nominal range for the detune attribute is being reduced.

See https://github.com/WebAudio/web-audio-api/issues/1698 and https://github.com/WebAudio/web-audio-api/pull/1703



 
Blocking: 860347
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a5a6b8b0e4384d17a7e66192963c2e0c0cc2948

commit 8a5a6b8b0e4384d17a7e66192963c2e0c0cc2948
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Sep 06 21:09:32 2018

Change detune min/max limits

The max and min valures for the OscillatorNode.detune parameter has been
reduced according the latest version of the spec.  Make it so.

Also implement clamping of the total frequency to Nyquist so that we don't
generate infinity or NaN doing the computations.  This is ok because anything
beyond Nyquist would output 0 anyway.  But we're careful to preserve the slope
of automations; test added for this as well.

Update expectations for AudioParam/audioparam-nominal-range.html because of
the new warnings produced by clamping detune.

Bug:  865552 ,  860347 
Test: the-oscillatornode-interface/detune-limiting.html
Change-Id: I35a214b0f3156ad8912718dcb277f1967f70df8f
Reviewed-on: https://chromium-review.googlesource.com/1138638
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589299}
[add] https://crrev.com/8a5a6b8b0e4384d17a7e66192963c2e0c0cc2948/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting.html
[modify] https://crrev.com/8a5a6b8b0e4384d17a7e66192963c2e0c0cc2948/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/8a5a6b8b0e4384d17a7e66192963c2e0c0cc2948/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
[modify] https://crrev.com/8a5a6b8b0e4384d17a7e66192963c2e0c0cc2948/third_party/blink/renderer/modules/webaudio/oscillator_node.cc

Status: Fixed (was: Assigned)

Sign in to add a comment