PDF Viewer: DCHECK on print button click while already printing to PDF |
|||
Issue descriptionOn a debug build: 1. Open a .pdf file with the Chrome PDF Viewer. 2. Press ctrl+P to open the print window. 3. Choose "Save as PDF". 4. Click "Save". The window will close (usually. Sometimes it does not.) Immediately, before the save as dialog appears, click the Print button in the PDF Viewer toolbar. Expected: Nothing. Actual: Crash due to DCHECK: [1:1:0719/133103.306361:FATAL:web_local_frame_impl.cc(1458)] Check failed: !is_in_printing_. DispatchAfterPrintEvent() should have been called after the previous DispatchBeforePrintEvent() call. #0 0x7f967aef87cd base::debug::StackTrace::StackTrace() #1 0x7f967ac3e36c base::debug::StackTrace::StackTrace() #2 0x7f967acad3aa logging::LogMessage::~LogMessage() #3 0x7f96625fcaf3 blink::WebLocalFrameImpl::DispatchBeforePrintEvent() #4 0x56283bf83cb9 printing::PrintRenderFrameHelper::RequestPrintPreview() #5 0x56283bf8c0f9 printing::PrintRenderFrameHelper::PrintNode() #6 0x56283bddda93 ChromePDFPrintClient::Print() #7 0x56283bf6e4e1 pdf::PepperPDFHost::InvokePrintingForInstance() #8 0x56283bf6fa53 pdf::PepperPDFHost::OnHostMsgPrint() #9 0x56283bf6e8a7 pdf::PepperPDFHost::OnResourceMessageReceived() #10 0x7f9667c20b54 ppapi::host::ResourceMessageHandler::RunMessageHandlerAndReply() #11 0x7f9667c1d9be ppapi::host::ResourceHost::HandleMessage() #12 0x7f9667c1681b ppapi::host::PpapiHost::HandleResourceCall() #13 0x7f9667c13549 ppapi::host::PpapiHost::OnHostMsgResourceCall() #14 0x7f9667c192e0 _ZN4base20DispatchToMethodImplIPN5ppapi4host9PpapiHostEMS3_FvRKNS1_5proxy25ResourceMessageCallParamsERKN3IPC7MessageEENSt3__15tupleIJS6_SA_EEEJLm0ELm1EEEEvRKT_T0_OT1_NSF_16integer_sequenceImJXspT2_EEEE #15 0x7f9667c19218 _ZN4base16DispatchToMethodIPN5ppapi4host9PpapiHostEMS3_FvRKNS1_5proxy25ResourceMessageCallParamsERKN3IPC7MessageEENSt3__15tupleIJS6_SA_EEEEEvRKT_T0_OT1_ #16 0x7f9667c19184 _ZN3IPC16DispatchToMethodIN5ppapi4host9PpapiHostEMS3_FvRKNS1_5proxy25ResourceMessageCallParamsERKNS_7MessageEEvNSt3__15tupleIJS5_S8_EEEEEvPT_T0_PT1_OT2_ #17 0x7f9667c1714d _ZN3IPC8MessageTI30PpapiHostMsg_ResourceCall_MetaNSt3__15tupleIJN5ppapi5proxy25ResourceMessageCallParamsENS_7MessageEEEEvE8DispatchINS4_4host9PpapiHostESC_vMSC_FvRKS6_RKS7_EEEbPSF_PT_PT0_PT1_T2_ #18 0x7f9667c130c5 ppapi::host::PpapiHost::OnMessageReceived() #19 0x7f9667ae791a ppapi::proxy::HostDispatcher::OnMessageReceived() #20 0x7f9678c8f1f5 IPC::ChannelProxy::Context::OnDispatchMessage() #21 0x7f9678cd004d IPC::SyncChannel::ReceivedSyncMsgQueue::DispatchMessages() #22 0x7f9678ccbfc1 IPC::SyncChannel::SyncContext::DispatchMessages() #23 0x7f9678cce839 IPC::SyncChannel::OnDispatchEventSignaled() #24 0x7f9678cd3ea0 _ZN4base8internal13FunctorTraitsIMN3IPC11SyncChannel11SyncContextEFvPNS_13WaitableEventEEvE6InvokeIS8_PS4_JS6_EEEvT_OT0_DpOT1_ #25 0x7f9678cd3dff _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN3IPC11SyncChannel20ReceivedSyncMsgQueue21NestedSendDoneWatcherEFvPNS_13WaitableEventEEJPS7_S9_EEEvOT_DpOT0_ #26 0x7f9678cd3d95 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC11SyncChannel11SyncContextEFvPNS_13WaitableEventEEJNS0_17UnretainedWrapperIS5_EEEEEFvS7_EE7RunImplIRKS9_RKNSt3__15tupleIJSB_EEEJLm0EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEEOS7_ #27 0x7f9678cd3d29 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC11SyncChannel20ReceivedSyncMsgQueue21NestedSendDoneWatcherEFvPNS_13WaitableEventEEJNS0_17UnretainedWrapperIS6_EEEEEFvS8_EE7RunOnceEPNS0_13BindStateBaseES8_ #28 0x7f967af295c1 _ZNO4base12OnceCallbackIFvPNS_13WaitableEventEEE3RunES2_ #29 0x7f967af28c23 base::AsyncCallbackHelper() #30 0x7f967af29d33 _ZN4base8internal13FunctorTraitsIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES6_EvE6InvokeISA_JS3_S8_S6_EEEvOT_DpOT0_ #31 0x7f967af29cad _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES8_EJS5_SA_S8_EEEvOT_DpOT0_ #32 0x7f967af29c4d _ZN4base8internal7InvokerINS0_9BindStateIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES7_EJNS0_18RetainedRefWrapperIS3_EES9_S7_EEEFvvEE7RunImplISB_NSt3__15tupleIJSD_S9_S7_EEEJLm0ELm1ELm2EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #33 0x7f967af29b29 _ZN4base8internal7InvokerINS0_9BindStateIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES7_EJNS0_18RetainedRefWrapperIS3_EES9_S7_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #34 0x7f967abed54e _ZNO4base12OnceCallbackIFvvEE3RunEv #35 0x7f967ac3f832 base::debug::TaskAnnotator::RunTask() #36 0x7f965fb3193d base::sequence_manager::internal::ThreadControllerImpl::DoWork() #37 0x7f965fb345d1 _ZN4base8internal13FunctorTraitsIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS4_8WorkTypeEEvE6InvokeIS7_RKNS_7WeakPtrIS4_EEJRKS5_EEEvT_OT0_DpOT1_ #38 0x7f965fb34535 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_16sequence_manager8internal20ThreadControllerImplEFvNS6_8WorkTypeEERKNS_7WeakPtrIS6_EEJRKS7_EEEvOT_OT0_DpOT1_ #39 0x7f965fb344ad _ZN4base8internal7InvokerINS0_9BindStateIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS5_8WorkTypeEEJNS_7WeakPtrIS5_EES6_EEEFvvEE7RunImplIRKS8_RKNSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSH_16integer_sequenceImJXspT1_EEEE #40 0x7f965fb343bc _ZN4base8internal7InvokerINS0_9BindStateIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS5_8WorkTypeEEJNS_7WeakPtrIS5_EES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #41 0x7f967abed54e _ZNO4base12OnceCallbackIFvvEE3RunEv #42 0x7f967ac3f832 base::debug::TaskAnnotator::RunTask() #43 0x7f967accca89 base::internal::IncomingTaskQueue::RunTask() #44 0x7f967acd6877 base::MessageLoop::RunTask() #45 0x7f967acd6ae8 base::MessageLoop::DeferOrRunPendingTask() #46 0x7f967acd6e19 base::MessageLoop::DoWork() #47 0x7f967acda147 base::MessagePumpDefault::Run() #48 0x7f967acd606b base::MessageLoop::Run() #49 0x7f967ad8244d base::RunLoop::Run() #50 0x7f9676024572 content::RendererMain() #51 0x7f96762488b4 content::RunZygote() #52 0x7f967624b849 content::RunOtherNamedProcessTypeMain() #53 0x7f967624da17 content::ContentMainRunnerImpl::Run() #54 0x7f9676242005 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #55 0x7f967b19a0d4 service_manager::Main() #56 0x7f9676248265 content::ContentMain() #57 0x562835003246 ChromeMain #58 0x562835003152 main #59 0x7f9656ffb2b1 __libc_start_main #60 0x56283500302a _start Received signal 6 #0 0x7f967aef87cd base::debug::StackTrace::StackTrace() #1 0x7f967ac3e36c base::debug::StackTrace::StackTrace() #2 0x7f967aef8224 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f965b26f0c0 <unknown> #4 0x7f965700dfcf gsignal #5 0x7f965700f3fa abort #6 0x7f967aef79a6 base::debug::(anonymous namespace)::DebugBreak() #7 0x7f967aef7988 base::debug::BreakDebugger() #8 0x7f967acae1a4 logging::LogMessage::~LogMessage() #9 0x7f96625fcaf3 blink::WebLocalFrameImpl::DispatchBeforePrintEvent() #10 0x56283bf83cb9 printing::PrintRenderFrameHelper::RequestPrintPreview() #11 0x56283bf8c0f9 printing::PrintRenderFrameHelper::PrintNode() #12 0x56283bddda93 ChromePDFPrintClient::Print() #13 0x56283bf6e4e1 pdf::PepperPDFHost::InvokePrintingForInstance() #14 0x56283bf6fa53 pdf::PepperPDFHost::OnHostMsgPrint() #15 0x56283bf6e8a7 pdf::PepperPDFHost::OnResourceMessageReceived() #16 0x7f9667c20b54 ppapi::host::ResourceMessageHandler::RunMessageHandlerAndReply() #17 0x7f9667c1d9be ppapi::host::ResourceHost::HandleMessage() #18 0x7f9667c1681b ppapi::host::PpapiHost::HandleResourceCall() #19 0x7f9667c13549 ppapi::host::PpapiHost::OnHostMsgResourceCall() #20 0x7f9667c192e0 _ZN4base20DispatchToMethodImplIPN5ppapi4host9PpapiHostEMS3_FvRKNS1_5proxy25ResourceMessageCallParamsERKN3IPC7MessageEENSt3__15tupleIJS6_SA_EEEJLm0ELm1EEEEvRKT_T0_OT1_NSF_16integer_sequenceImJXspT2_EEEE #21 0x7f9667c19218 _ZN4base16DispatchToMethodIPN5ppapi4host9PpapiHostEMS3_FvRKNS1_5proxy25ResourceMessageCallParamsERKN3IPC7MessageEENSt3__15tupleIJS6_SA_EEEEEvRKT_T0_OT1_ #22 0x7f9667c19184 _ZN3IPC16DispatchToMethodIN5ppapi4host9PpapiHostEMS3_FvRKNS1_5proxy25ResourceMessageCallParamsERKNS_7MessageEEvNSt3__15tupleIJS5_S8_EEEEEvPT_T0_PT1_OT2_ #23 0x7f9667c1714d _ZN3IPC8MessageTI30PpapiHostMsg_ResourceCall_MetaNSt3__15tupleIJN5ppapi5proxy25ResourceMessageCallParamsENS_7MessageEEEEvE8DispatchINS4_4host9PpapiHostESC_vMSC_FvRKS6_RKS7_EEEbPSF_PT_PT0_PT1_T2_ #24 0x7f9667c130c5 ppapi::host::PpapiHost::OnMessageReceived() #25 0x7f9667ae791a ppapi::proxy::HostDispatcher::OnMessageReceived() #26 0x7f9678c8f1f5 IPC::ChannelProxy::Context::OnDispatchMessage() #27 0x7f9678cd004d IPC::SyncChannel::ReceivedSyncMsgQueue::DispatchMessages() #28 0x7f9678ccbfc1 IPC::SyncChannel::SyncContext::DispatchMessages() #29 0x7f9678cce839 IPC::SyncChannel::OnDispatchEventSignaled() #30 0x7f9678cd3ea0 _ZN4base8internal13FunctorTraitsIMN3IPC11SyncChannel11SyncContextEFvPNS_13WaitableEventEEvE6InvokeIS8_PS4_JS6_EEEvT_OT0_DpOT1_ #31 0x7f9678cd3dff _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN3IPC11SyncChannel20ReceivedSyncMsgQueue21NestedSendDoneWatcherEFvPNS_13WaitableEventEEJPS7_S9_EEEvOT_DpOT0_ #32 0x7f9678cd3d95 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC11SyncChannel11SyncContextEFvPNS_13WaitableEventEEJNS0_17UnretainedWrapperIS5_EEEEEFvS7_EE7RunImplIRKS9_RKNSt3__15tupleIJSB_EEEJLm0EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEEOS7_ #33 0x7f9678cd3d29 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC11SyncChannel20ReceivedSyncMsgQueue21NestedSendDoneWatcherEFvPNS_13WaitableEventEEJNS0_17UnretainedWrapperIS6_EEEEEFvS8_EE7RunOnceEPNS0_13BindStateBaseES8_ #34 0x7f967af295c1 _ZNO4base12OnceCallbackIFvPNS_13WaitableEventEEE3RunES2_ #35 0x7f967af28c23 base::AsyncCallbackHelper() #36 0x7f967af29d33 _ZN4base8internal13FunctorTraitsIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES6_EvE6InvokeISA_JS3_S8_S6_EEEvOT_DpOT0_ #37 0x7f967af29cad _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES8_EJS5_SA_S8_EEEvOT_DpOT0_ #38 0x7f967af29c4d _ZN4base8internal7InvokerINS0_9BindStateIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES7_EJNS0_18RetainedRefWrapperIS3_EES9_S7_EEEFvvEE7RunImplISB_NSt3__15tupleIJSD_S9_S7_EEEJLm0ELm1ELm2EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #39 0x7f967af29b29 _ZN4base8internal7InvokerINS0_9BindStateIPFvPNS_4FlagENS_12OnceCallbackIFvPNS_13WaitableEventEEEES7_EJNS0_18RetainedRefWrapperIS3_EES9_S7_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #40 0x7f967abed54e _ZNO4base12OnceCallbackIFvvEE3RunEv #41 0x7f967ac3f832 base::debug::TaskAnnotator::RunTask() #42 0x7f965fb3193d base::sequence_manager::internal::ThreadControllerImpl::DoWork() #43 0x7f965fb345d1 _ZN4base8internal13FunctorTraitsIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS4_8WorkTypeEEvE6InvokeIS7_RKNS_7WeakPtrIS4_EEJRKS5_EEEvT_OT0_DpOT1_ #44 0x7f965fb34535 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_16sequence_manager8internal20ThreadControllerImplEFvNS6_8WorkTypeEERKNS_7WeakPtrIS6_EEJRKS7_EEEvOT_OT0_DpOT1_ #45 0x7f965fb344ad _ZN4base8internal7InvokerINS0_9BindStateIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS5_8WorkTypeEEJNS_7WeakPtrIS5_EES6_EEEFvvEE7RunImplIRKS8_RKNSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSH_16integer_sequenceImJXspT1_EEEE #46 0x7f965fb343bc _ZN4base8internal7InvokerINS0_9BindStateIMNS_16sequence_manager8internal20ThreadControllerImplEFvNS5_8WorkTypeEEJNS_7WeakPtrIS5_EES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #47 0x7f967abed54e _ZNO4base12OnceCallbackIFvvEE3RunEv #48 0x7f967ac3f832 base::debug::TaskAnnotator::RunTask() #49 0x7f967accca89 base::internal::IncomingTaskQueue::RunTask() #50 0x7f967acd6877 base::MessageLoop::RunTask() #51 0x7f967acd6ae8 base::MessageLoop::DeferOrRunPendingTask() #52 0x7f967acd6e19 base::MessageLoop::DoWork() #53 0x7f967acda147 base::MessagePumpDefault::Run() #54 0x7f967acd606b base::MessageLoop::Run() #55 0x7f967ad8244d base::RunLoop::Run() #56 0x7f9676024572 content::RendererMain() #57 0x7f96762488b4 content::RunZygote() #58 0x7f967624b849 Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged. content::RunOtherNamedProcessTypeMain() #59 0x7f967624da17 content::ContentMainRunnerImpl::Run() #60 0x7f9676242005 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #61 0x7f967b19a0d4 service_manager::Main() r8: 0000000000000000 r9: 00007ffd18e584d0 r10: 0000000000000008 r11: 0000000000000246 r12: 0000562835003000 r13: 00007ffd18e5ee60 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000002 si: 00007ffd18e584d0 bp: 00007ffd18e58710 bx: 0000000000000006 dx: 0000000000000000 ax: 0000000000000000 cx: 00007f965700dfcf sp: 00007ffd18e58548 ip: 00007f965700dfcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Bisected the culprit to be: Print Preview Componentization: Add field trial config https://chromium-review.googlesource.com/c/chromium/src/+/1103305
,
Jul 19
Print Preview shouldn't close until the preview loads when saving to PDF. This needs to be in M-69 as we need to maintain the invariant of only 1 Print Preview per web contents at a time, or many things can break. Candidate CL at https://crrev.com/c/1144189.
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02f7b5e232badc0ea379da445389ad6d75cdef41 commit 02f7b5e232badc0ea379da445389ad6d75cdef41 Author: rbpotter <rbpotter@chromium.org> Date: Thu Jul 19 23:43:18 2018 Print Preview Componentization: preview stays open if not local printer Ensure that print preview hides when the Print button is pressed only if the printer is local and not the Save as PDF printer. Bug: 865544 Change-Id: I2a2f26054c20effb72a9ca33937c0a425b4aff95 Reviewed-on: https://chromium-review.googlesource.com/1144189 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#576694} [modify] https://crrev.com/02f7b5e232badc0ea379da445389ad6d75cdef41/chrome/browser/resources/print_preview/new/app.js
,
Jul 24
Is anyone still seeing this on ToT (or anything more recent than r576694)? Should be fixed.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5a31baaf42d73968db2fbdc1b173af89a09b7b1 commit b5a31baaf42d73968db2fbdc1b173af89a09b7b1 Author: rbpotter <rbpotter@chromium.org> Date: Mon Jul 30 22:41:42 2018 Print Preview: Add test for hiding preview behavior Test that the preview hides when the user clicks print before the preview has loaded if the printer is local, and that the preview remains open until the preview loads if printing to PDF. Bug: 865544 Change-Id: I1fd89a565f65f4aa0c8115facc8817478896b141 Reviewed-on: https://chromium-review.googlesource.com/1153621 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#579209} [modify] https://crrev.com/b5a31baaf42d73968db2fbdc1b173af89a09b7b1/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [add] https://crrev.com/b5a31baaf42d73968db2fbdc1b173af89a09b7b1/chrome/test/data/webui/print_preview/print_button_test.js [modify] https://crrev.com/b5a31baaf42d73968db2fbdc1b173af89a09b7b1/chrome/test/data/webui/print_preview/print_preview_test_utils.js [modify] https://crrev.com/b5a31baaf42d73968db2fbdc1b173af89a09b7b1/chrome/test/data/webui/print_preview/print_preview_tests.js
,
Aug 1
This should be fixed (and verified by automated test added by CL at comment 5). Please re-open if you are still seeing this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Jul 19Components: -Internals>Plugins>PDF -Internals>Printing UI>Browser>PrintPreview
Labels: -Pri-3 M-69 Pri-1
Owner: rbpotter@chromium.org
Status: Started (was: Untriaged)