Chrome Version: 67.0.3396.99 Implement autocomplete in the search box located in the launcher to autocomplete user urls and text queries. PRD: https://docs.google.com/document/d/17YFFeCOZhAcZFjOo9dJzu51F2NIBZEBis1jU31__LW0/edit?ts=5b3be3a1#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2bae73194b8deb1ba2e533c235c328ba809fc07 commit a2bae73194b8deb1ba2e533c235c328ba809fc07 Author: Daniel Zhang <oxyflush@google.com> Date: Wed Aug 01 22:36:48 2018 Make SearchBoxView Search Box have the functionality to autocomplete user queries. Current iteration: 1. Autocomplete queries will only autocomplete if it is confident in a url or text query (no apps or answer cards). 2. Autocomplete is based off of the first result view in the SearchResultPageView. 3. Up/Down/Left/Right/Tab keys all trigger autocomplete. Bug: 865543 Change-Id: I8be9ba36f4bb79bc250b64d289919bd898144862 Reviewed-on: https://chromium-review.googlesource.com/1141118 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#579967} [modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/contents_view.h [modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_box_view.h [modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_result_page_view.cc [modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_result_page_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10d26ba530981f724704f023c79e52ed8070bc5a commit 10d26ba530981f724704f023c79e52ed8070bc5a Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Aug 02 04:10:09 2018 Revert "Make SearchBoxView Search Box have the functionality to autocomplete user queries." This reverts commit a2bae73194b8deb1ba2e533c235c328ba809fc07. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 579967 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EyYmFlNzMxOTRiOGRlYjFiYTJlNTMzYzIzNWMzMjhiYTgwOWZjMDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8101 Sample Failed Step: browser_tests Original change's description: > Make SearchBoxView Search Box have the functionality to autocomplete > user queries. > > Current iteration: > 1. Autocomplete queries will only autocomplete if it is confident in a > url or text query (no apps or answer cards). > 2. Autocomplete is based off of the first result view in the > SearchResultPageView. > 3. Up/Down/Left/Right/Tab keys all trigger autocomplete. > > Bug: 865543 > Change-Id: I8be9ba36f4bb79bc250b64d289919bd898144862 > Reviewed-on: https://chromium-review.googlesource.com/1141118 > Commit-Queue: Daniel Zhang <oxyflush@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579967} Change-Id: I069a412d061460bd83025292b583eefcd58c469f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865543 Reviewed-on: https://chromium-review.googlesource.com/1159852 Cr-Commit-Position: refs/heads/master@{#580056} [modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/contents_view.h [modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_box_view.h [modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_result_page_view.cc [modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_result_page_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5caaea099aa6d9fb15335c5947fe7c8985ec4402 commit 5caaea099aa6d9fb15335c5947fe7c8985ec4402 Author: Daniel Zhang <oxyflush@google.com> Date: Thu Aug 02 18:32:23 2018 Make SearchBoxView Search Box have the functionality to autocomplete user queries. Current iteration: 1. Autocomplete queries will only autocomplete if it is confident in a url or text query (no apps or answer cards). 2. Autocomplete is based off of the first result view in the SearchResultPageView. 3. Up/Down/Left/Right/Tab keys all trigger autocomplete. Bug: 865543 Change-Id: I579a6f1fb4cdc2af5e7a43577a73a843663e5e8c Reviewed-on: https://chromium-review.googlesource.com/1161014 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#580258} [modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/contents_view.h [modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_box_view.h [modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_result_page_view.cc [modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_result_page_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915 commit 7cdb04e261db5db4e7f63282b21d7e3dc5fa8915 Author: Daniel Zhang <oxyflush@google.com> Date: Fri Aug 03 23:13:45 2018 Let SearchBoxView autocomplete non-SearchResultListViews. 1. Autocomplete works on apps and playstore suggestions. 2. Autocomplete no longer works with less than 2 characters. Bug: 865543 Change-Id: Ib438083463d76b7dbd4106b8cf8ae574a47fafcc Reviewed-on: https://chromium-review.googlesource.com/1161511 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#580693} [modify] https://crrev.com/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915/ash/app_list/views/contents_view.h [modify] https://crrev.com/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915/ash/app_list/views/search_box_view.h [modify] https://crrev.com/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915/ash/app_list/views/search_result_page_view.cc [modify] https://crrev.com/7cdb04e261db5db4e7f63282b21d7e3dc5fa8915/ash/app_list/views/search_result_page_view_unittest.cc
Issue 859537 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fcd0208b3f849c13d52a89ec357eb25793032cc commit 2fcd0208b3f849c13d52a89ec357eb25793032cc Author: Daniel Zhang <oxyflush@google.com> Date: Thu Aug 16 00:34:26 2018 cros: Added in unit tests for autocomplete feature. Landed functionality separately. Bug: 865543 Change-Id: Ic44263ff2273ef97aec357c7a842a1134d57d061 Reviewed-on: https://chromium-review.googlesource.com/1171342 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583462} [modify] https://crrev.com/2fcd0208b3f849c13d52a89ec357eb25793032cc/ash/app_list/views/search_box_view_unittest.cc
Issue 764117 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Aug 1