New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865543 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add autocomplete to launcher search box

Project Member Reported by oxyflush@chromium.org, Jul 19

Issue description

Chrome Version: 67.0.3396.99

Implement autocomplete in the search box located in the launcher to autocomplete user urls and text queries.

PRD: https://docs.google.com/document/d/17YFFeCOZhAcZFjOo9dJzu51F2NIBZEBis1jU31__LW0/edit?ts=5b3be3a1#


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2bae73194b8deb1ba2e533c235c328ba809fc07

commit a2bae73194b8deb1ba2e533c235c328ba809fc07
Author: Daniel Zhang <oxyflush@google.com>
Date: Wed Aug 01 22:36:48 2018

Make SearchBoxView Search Box have the functionality to autocomplete
user queries.

Current iteration:
1. Autocomplete queries will only autocomplete if it is confident in a
   url or text query (no apps or answer cards).
2. Autocomplete is based off of the first result view in the
   SearchResultPageView.
3. Up/Down/Left/Right/Tab keys all trigger autocomplete.

Bug:  865543 
Change-Id: I8be9ba36f4bb79bc250b64d289919bd898144862
Reviewed-on: https://chromium-review.googlesource.com/1141118
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579967}
[modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/contents_view.h
[modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_box_view.h
[modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/a2bae73194b8deb1ba2e533c235c328ba809fc07/ash/app_list/views/search_result_page_view_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d26ba530981f724704f023c79e52ed8070bc5a

commit 10d26ba530981f724704f023c79e52ed8070bc5a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Aug 02 04:10:09 2018

Revert "Make SearchBoxView Search Box have the functionality to autocomplete user queries."

This reverts commit a2bae73194b8deb1ba2e533c235c328ba809fc07.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 579967 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EyYmFlNzMxOTRiOGRlYjFiYTJlNTMzYzIzNWMzMjhiYTgwOWZjMDcM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8101

Sample Failed Step: browser_tests

Original change's description:
> Make SearchBoxView Search Box have the functionality to autocomplete
> user queries.
> 
> Current iteration:
> 1. Autocomplete queries will only autocomplete if it is confident in a
>    url or text query (no apps or answer cards).
> 2. Autocomplete is based off of the first result view in the
>    SearchResultPageView.
> 3. Up/Down/Left/Right/Tab keys all trigger autocomplete.
> 
> Bug:  865543 
> Change-Id: I8be9ba36f4bb79bc250b64d289919bd898144862
> Reviewed-on: https://chromium-review.googlesource.com/1141118
> Commit-Queue: Daniel Zhang <oxyflush@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579967}

Change-Id: I069a412d061460bd83025292b583eefcd58c469f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  865543 
Reviewed-on: https://chromium-review.googlesource.com/1159852
Cr-Commit-Position: refs/heads/master@{#580056}
[modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/contents_view.h
[modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_box_view.h
[modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/10d26ba530981f724704f023c79e52ed8070bc5a/ash/app_list/views/search_result_page_view_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5caaea099aa6d9fb15335c5947fe7c8985ec4402

commit 5caaea099aa6d9fb15335c5947fe7c8985ec4402
Author: Daniel Zhang <oxyflush@google.com>
Date: Thu Aug 02 18:32:23 2018

Make SearchBoxView Search Box have the functionality to autocomplete user queries.

Current iteration:
1. Autocomplete queries will only autocomplete if it is confident in a
   url or text query (no apps or answer cards).
2. Autocomplete is based off of the first result view in the
   SearchResultPageView.
3. Up/Down/Left/Right/Tab keys all trigger autocomplete.

Bug:  865543 
Change-Id: I579a6f1fb4cdc2af5e7a43577a73a843663e5e8c
Reviewed-on: https://chromium-review.googlesource.com/1161014
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#580258}
[modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/contents_view.h
[modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_box_view.h
[modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/5caaea099aa6d9fb15335c5947fe7c8985ec4402/ash/app_list/views/search_result_page_view_unittest.cc

Cc: newcomer@chromium.org
Cc: oxyflush@chromium.org
 Issue 859537  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fcd0208b3f849c13d52a89ec357eb25793032cc

commit 2fcd0208b3f849c13d52a89ec357eb25793032cc
Author: Daniel Zhang <oxyflush@google.com>
Date: Thu Aug 16 00:34:26 2018

cros: Added in unit tests for autocomplete feature.

Landed functionality separately.

Bug:  865543 
Change-Id: Ic44263ff2273ef97aec357c7a842a1134d57d061
Reviewed-on: https://chromium-review.googlesource.com/1171342
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583462}
[modify] https://crrev.com/2fcd0208b3f849c13d52a89ec357eb25793032cc/ash/app_list/views/search_box_view_unittest.cc

Status: Fixed (was: Untriaged)
Issue 764117 has been merged into this issue.

Sign in to add a comment