DEPS: Convert use of download_from_google_storage.py to CIPD gclient support |
||||||
Issue description
$ chromium/src grep download_from_google_storage.py DEPS | wc -l
30
Now that we successfully used '{{platform}}', all of them can now be replaced by native gclient CIPD support. This will permit to close many issues about download_from_google_storage.
,
Jul 20
Please also CC me on CLs so that I can update V8's DEPS file. Unfortunately our auto-roller is not able to handle the case when dep changes name as reported by revinfo, e.g. from tools/luci-go to tools/luci-go:infra/tools/luci/isolate/${platform}, hence we need to update it manually.
,
Jul 20
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31d0faaac3c79d920233fa8c93e2cf886123c840 commit 31d0faaac3c79d920233fa8c93e2cf886123c840 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Fri Jul 20 09:52:41 2018 Revert "tools/luci-go: remove old way of mapping isolate" This reverts commit 6bb055bef632b46bed7ee8e350c5de2278c67145. Reason for revert: P0 bug https://crbug.com/865882 Original change's description: > tools/luci-go: remove old way of mapping isolate > > It's now only mapped via CIPD, which is the right solution going forward. > > Bug: 851596,865541 > Change-Id: I25ddd0e059c818fafbc5587b06ff35b6c733a16e > Reviewed-on: https://chromium-review.googlesource.com/1143448 > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576550} TBR=maruel@chromium.org,tandrii@chromium.org,jbudorick@chromium.org Change-Id: I2d432e9c80379c41e22b7a1cfdb4ea3f54586baa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851596, 865541 Reviewed-on: https://chromium-review.googlesource.com/1145020 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576823} [modify] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/DEPS [modify] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/.gitignore [add] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/linux64/isolate.sha1 [add] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/mac64/isolate.sha1 [add] https://crrev.com/31d0faaac3c79d920233fa8c93e2cf886123c840/tools/luci-go/win64/isolate.exe.sha1
,
Jul 20
Marking issue 851596 as a blocker because it's not worth investigating this until isolate is only distributed via CIPD via gclient.
,
Jul 20
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45a93161c50a2ede188b8ba5d8892ef76431c00d commit 45a93161c50a2ede188b8ba5d8892ef76431c00d Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Mon Jul 23 14:59:37 2018 Revert "tools/luci-go: remove old way of mapping isolate" This reverts commit 6bb055bef632b46bed7ee8e350c5de2278c67145. Reason for revert: P0 bug https://crbug.com/865882 Original change's description: > tools/luci-go: remove old way of mapping isolate > > It's now only mapped via CIPD, which is the right solution going forward. > > Bug: 851596,865541 > Change-Id: I25ddd0e059c818fafbc5587b06ff35b6c733a16e > Reviewed-on: https://chromium-review.googlesource.com/1143448 > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576550} TBR=maruel@chromium.org,tandrii@chromium.org,jbudorick@chromium.org Change-Id: I2d432e9c80379c41e22b7a1cfdb4ea3f54586baa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851596, 865541, 865882 Reviewed-on: https://chromium-review.googlesource.com/1145020 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576823}(cherry picked from commit 31d0faaac3c79d920233fa8c93e2cf886123c840) Reviewed-on: https://chromium-review.googlesource.com/1146841 Reviewed-by: John Budorick <jbudorick@google.com> Cr-Commit-Position: refs/branch-heads/3497@{#14} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/DEPS [modify] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/.gitignore [add] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/linux64/isolate.sha1 [add] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/mac64/isolate.sha1 [add] https://crrev.com/45a93161c50a2ede188b8ba5d8892ef76431c00d/tools/luci-go/win64/isolate.exe.sha1
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/919841a83970ddd63ef2db5f30f514c44278a3a3 commit 919841a83970ddd63ef2db5f30f514c44278a3a3 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Thu Oct 25 09:25:34 2018 Use CIPD to checkout luci-go binaries R=machenbach@chromium.org Bug: chromium:865541 Change-Id: I98f21c278099bd2c90b4a1ff9b7dddb74d263e34 Reviewed-on: https://chromium-review.googlesource.com/c/1144923 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56975} [modify] https://crrev.com/919841a83970ddd63ef2db5f30f514c44278a3a3/DEPS |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 19