New issue
Advanced search Search tips

Issue 865540 link

Starred by 1 user
Status: Fixed
Owner:
pkasting@chromium.org
Closed: Nov 21
Cc:
yus...@chromium.org
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

FontListTest::Fonts_GetHeight_GetBaseline fails on Android

Project Member Reported by wychen@chromium.org, Jul 19 
FontListTest::Fonts_GetHeight_GetBaseline fails on Android. The root cause is that this test requires two fonts to have different baseline and different height. The ones we are using don't meet this criteria. We need to find two system fonts that meet this criteria.

RenderTextTest.StringSizeRespectsFontListMetrics fails due to the similar issue as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22100358580bd5386491478e2fb72d1ccee1d0b8

commit 22100358580bd5386491478e2fb72d1ccee1d0b8
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 24 02:21:50 2018

Enable render_text_unittest on Android

Some tests are disabled for now.

Bug:  853281 , 865527,  865540 , 865709, 865715
Change-Id: I4fda286ff877301704426820ee10d200cd54468b
Reviewed-on: https://chromium-review.googlesource.com/1144305
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577408}
[modify] https://crrev.com/22100358580bd5386491478e2fb72d1ccee1d0b8/ui/gfx/BUILD.gn
[modify] https://crrev.com/22100358580bd5386491478e2fb72d1ccee1d0b8/ui/gfx/render_text_unittest.cc

Comment 2 by pkasting@chromium.org, Nov 20

Owner: pkasting@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d3fdfc64e8a27db48f7ea550d96d1234f1cd8be

commit 8d3fdfc64e8a27db48f7ea550d96d1234f1cd8be
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Nov 21 19:07:45 2018

Enable two disabled font metric tests on Android.

The tests currently assume that the normal and CJK fonts have different metrics.
On Android, this is not true for all platforms we support.  The tests still have
some value when run with fonts with identical metrics, so modify the test
expectations slightly to work in that case and enable these tests.

Bug:  865540 
Change-Id: I6cd98a254f9ae0e6c6a9818e37c9ae69ca954f13
Reviewed-on: https://chromium-review.googlesource.com/c/1343531
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610115}
[modify] https://crrev.com/8d3fdfc64e8a27db48f7ea550d96d1234f1cd8be/ui/gfx/font_list_unittest.cc
[modify] https://crrev.com/8d3fdfc64e8a27db48f7ea550d96d1234f1cd8be/ui/gfx/render_text_unittest.cc

Comment 4 by pkasting@chromium.org, Nov 21

Status: Fixed (was: Started)
►

Sign in to add a comment