RenderTextHarfBuzzTest.MoveLeftRightByWordInChineseText doesn't work on Android |
|||
Issue descriptionRenderTextHarfBuzzTest.MoveLeftRightByWordInChineseText doesn't work on Android. The root cause is that Chinese and Japanese tokenization doesn't work on mobile. See issue 719045. Each Chinese character is wrongly tokenized as a word. We could add one test using a language that's nontrivial to word segmentation, but still work on mobile (one of Thai, Burmese, Lao, and Khmer). The error message is: C 19.711s Main [ RUN ] RenderTextHarfBuzzTest.MoveLeftRightByWordInChineseText/HarfBuzz C 19.711s Main ../../ui/gfx/render_text_unittest.cc:2325: Failure C 19.711s Main Expected equality of these values: C 19.712s Main 2U C 19.712s Main Which is: 2 C 19.712s Main render_text->cursor_position() C 19.712s Main Which is: 1 C 19.712s Main Stack trace: C 19.712s Main C 19.712s Main ../../ui/gfx/render_text_unittest.cc:2327: Failure C 19.712s Main Expected equality of these values: C 19.712s Main 3U C 19.712s Main Which is: 3 C 19.712s Main render_text->cursor_position() C 19.712s Main Which is: 2 C 19.712s Main Stack trace: C 19.712s Main C 19.713s Main ../../ui/gfx/render_text_unittest.cc:2329: Failure C 19.713s Main Expected equality of these values: C 19.713s Main 5U C 19.713s Main Which is: 5 C 19.713s Main render_text->cursor_position() C 19.713s Main Which is: 3 C 19.713s Main Stack trace: C 19.713s Main C 19.713s Main ../../ui/gfx/render_text_unittest.cc:2331: Failure C 19.713s Main Expected equality of these values: C 19.713s Main 6U C 19.713s Main Which is: 6 C 19.713s Main render_text->cursor_position() C 19.713s Main Which is: 4 C 19.713s Main Stack trace: C 19.714s Main C 19.714s Main ../../ui/gfx/render_text_unittest.cc:2333: Failure C 19.714s Main Expected equality of these values: C 19.714s Main 6U C 19.714s Main Which is: 6 C 19.714s Main render_text->cursor_position() C 19.714s Main Which is: 5 C 19.714s Main Stack trace: C 19.714s Main C 19.714s Main [ FAILED ] RenderTextHarfBuzzTest.MoveLeftRightByWordInChineseText/HarfBuzz, where GetParam() = 0 (98 ms)
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de04316bbcec8aa177e559c5af3d9316592daabb commit de04316bbcec8aa177e559c5af3d9316592daabb Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Wed Jul 25 00:40:49 2018 Add RenderTextHarfBuzzTest.MoveLeftRightByWordInThaiText RenderTextHarfBuzzTest.MoveLeftRightByWordInChineseText doesn't work on Android because of ICU issues. Use Thai instead to compensate the testing coverage. Bug: 865527 Change-Id: I39fb148bc8842716f8f93978bc7cdc0ab7af0f5c Reviewed-on: https://chromium-review.googlesource.com/1147860 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577750} [modify] https://crrev.com/de04316bbcec8aa177e559c5af3d9316592daabb/ui/gfx/render_text_unittest.cc
,
Jul 25
This is now blocked on issue 719045 (not having CJ word tokenization on mobile). For RenderText unit tests, using Thai should be enough to test the logic here. I'm leaving this open if we have any updates from issue 719045.
,
Sep 19
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9 commit d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Nov 21 19:31:18 2018 Enable disabled tests in ui/gfx/. These pass on Windows. Bug: 320050 , 327287 , 406574 , 427184 , 624513 , 701241, 865527 Change-Id: I51db36ebd63ca17b60eff0bf999ed3aae9ddd958 Reviewed-on: https://chromium-review.googlesource.com/c/1338955 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610157} [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/color_transform_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/font_names_testing.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/font_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/text_utils_unittest.cc [modify] https://crrev.com/d170f40c01329d7a1ad4b4e0fcba69b445f9cbd9/ui/gfx/transform_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 24