New issue
Advanced search Search tips

Issue 865512 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

licensing: license search should include the stacked overlays

Project Member Reported by vapier@chromium.org, Jul 19

Issue description

currently chromite's licenses_lib.py hardcodes three overlays to find licenses in:
- portage-stable
- chromiumos-overlay
- chromeos-overlay

with the expansion of overlays and partners using CrOS, we should allow ebuilds in an overlay to also search the overlay and its parents.

for example, if a package is added to src/overlays/project-xxx/ with a custom license, that license should be allowed to live in src/overlays/project-xxx/licenses/
 
Owner: saklein@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/95f9e034309a25e2bf64bbf700deba63758c948b

commit 95f9e034309a25e2bf64bbf700deba63758c948b
Author: Alex Klein <saklein@chromium.org>
Date: Sat Aug 11 05:43:51 2018

Adding overlay master searching to license functionality.

These changes allow the licenses to reside in the overlays in which
they are used rather than having to place all of them in the few,
hard coded locations that were used before.

BUG= chromium:865512 
TEST=new tests, run_tests, manual tests
CQ-DEPEND=CL:1162637

Change-Id: I501176b6fae2580d4a7f437619187cbf70e179b3
Reviewed-on: https://chromium-review.googlesource.com/1162636
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/95f9e034309a25e2bf64bbf700deba63758c948b/licensing/licenses_lib_unittest.py
[modify] https://crrev.com/95f9e034309a25e2bf64bbf700deba63758c948b/licensing/licenses_lib.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/repohooks/+/b5953522d7d4c5d1385c9f70fc78895dd74785b2

commit b5953522d7d4c5d1385c9f70fc78895dd74785b2
Author: Alex Klein <saklein@chromium.org>
Date: Sat Aug 11 05:43:51 2018

Adding overlay master searching to license functionality.

This adds the overlay searching changes to the pre-upload hook.

BUG= chromium:865512 
TEST=ran tests, manual test
CQ-DEPEND=CL:1162636

Change-Id: I815830f746a0f5ba507132faff60a4fea135698e
Reviewed-on: https://chromium-review.googlesource.com/1162637
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b5953522d7d4c5d1385c9f70fc78895dd74785b2/pre-upload.py

Status: Fixed (was: Started)

Sign in to add a comment