New issue
Advanced search Search tips

Issue 865507 link

Starred by 1 user
Status: Verified
Owner:
sczs@chromium.org
Closed: Jul 23
Cc:
pschaffner@chromium.org
martijnb@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Update Show Full History icon in Recent Tabs.

Project Member Reported by marq@chromium.org, Jul 19 
The current icon is colored, but all of the NTP collections icons are now blue-on-grey. This icon should be updated to have the same style.

To martijnb@ for the asset, then to sczs@.

Comment 1 by kkhorimoto@chromium.org, Jul 19

Components: UI>Browser>Mobile>RecentTabs

Comment 2 by martijnb@chromium.org, Jul 20

Cc: -sczs@chromium.org martijnb@chromium.org
Owner: sczs@chromium.org
Updated show_history.png here:

https://drive.google.com/corp/drive/folders/10u-zxita8nfiydZpacJLsvdgxhtxDr7y

Comment 3 by sczs@chromium.org, Jul 20

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b67302b0876183533249cba3043ea6a00dfc61

commit a9b67302b0876183533249cba3043ea6a00dfc61
Author: sczs <sczs@chromium.org>
Date: Fri Jul 20 23:08:24 2018

[ios] Updates UIRefresh Show Full History asset

Bug:  865507 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I68feba19be76ca9e7b185073ac51111fe954e7ad
Reviewed-on: https://chromium-review.googlesource.com/1145684
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577026}
[modify] https://crrev.com/a9b67302b0876183533249cba3043ea6a00dfc61/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history.png
[modify] https://crrev.com/a9b67302b0876183533249cba3043ea6a00dfc61/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history@2x.png
[modify] https://crrev.com/a9b67302b0876183533249cba3043ea6a00dfc61/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history@3x.png

Comment 5 by sczs@chromium.org, Jul 23

Labels: Merge-Request-69 Merge-TBD
Status: Fixed (was: Started)
I've verified this issue on Canary, so we should be ready to cherrypick.

Comment 6 by kariahda@chromium.org, Jul 24

Labels: -Merge-TBD -Merge-Request-69 Merge-Approved-69
Approved.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f5bca974504e1d22839ab2215585447383c2af6

commit 7f5bca974504e1d22839ab2215585447383c2af6
Author: sczs <sczs@chromium.org>
Date: Wed Jul 25 18:52:06 2018

[ios] Updates UIRefresh Show Full History asset

TBR=sczs@chromium.org

(cherry picked from commit a9b67302b0876183533249cba3043ea6a00dfc61)

Bug:  865507 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I68feba19be76ca9e7b185073ac51111fe954e7ad
Reviewed-on: https://chromium-review.googlesource.com/1145684
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577026}
Reviewed-on: https://chromium-review.googlesource.com/1150519
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#82}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/7f5bca974504e1d22839ab2215585447383c2af6/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history.png
[modify] https://crrev.com/7f5bca974504e1d22839ab2215585447383c2af6/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history@2x.png
[modify] https://crrev.com/7f5bca974504e1d22839ab2215585447383c2af6/ios/chrome/browser/ui/recent_tabs/resources/show_history.imageset/show_history@3x.png

Comment 8 by vbarig...@chromium.org, Jul 31

Status: Verified (was: Fixed)
Verified on chrome canary version 70.0.3508.0 on iPhone 8 plus and iPad pro with iOS 11.4.1, as per the assets provided in comment #2.  Looks good.

Comment 9 by rakurati@chromium.org, Aug 1 

Verified in 69.0.3947.22 beta in iPhone 7(iOS 11.4.1), iPhone 8plus(iOS 12 beta 5) and iPad mini(iOS 10.3.3)

show full history icon is displayed as per the assets provided in comment#2
►

Sign in to add a comment