New issue
Advanced search Search tips

Issue 865501 link

Starred by 2 users
Status: Fixed
Owner:
orinj@chromium.org
Closed: Jul 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Tab switch suggestions should only use 2-line layout if the button is shown

Project Member Reported by jdonnelly@chromium.org, Jul 19 
Steps to reproduce:

0. Update to latest Canary.
1. Enable chrome://flags/#upcoming-ui-features.
2. Open a tab and navigate to google.com.
3. Open a second tab and type 'goog'.

Expected result: First suggestion is google.com, with a single-line (aka "split") layout.

Actual result: First suggestion is google.com, with a two-line layout (see attached screenshot).

The problem here is that the first suggestion is a tab match, so we apply the two-line layout. But it's also a keyword search suggestion, so we hide the tab switch button in favor of the keyword search indicator (right-facing chevron).

The solution is that when we decide to apply the two-line layout because of the tab match bit, we need to also check that the result is *not* a keyword search result.
two-line-layout-issue.PNG
13.2 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/010c89f039cce4d8f7d612b13caca0d398d6246f

commit 010c89f039cce4d8f7d612b13caca0d398d6246f
Author: Orin Jaworski <orinj@chromium.org>
Date: Thu Jul 19 23:55:09 2018

[omnibox] Use one-line layout when keyword supersedes tab match

When an autocomplete suggestion matches an open tab, a two-line
layout is used because a switch-to-tab button is shown. But when
the suggestion also matches a keyword result, the button is not
shown and uses the one-line layout as normal.

Bug:  865501 
Change-Id: I71c2ef65d7cdad4ddd6efa94b2f3b122ddd6893a
Reviewed-on: https://chromium-review.googlesource.com/1143889
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576702}
[modify] https://crrev.com/010c89f039cce4d8f7d612b13caca0d398d6246f/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/010c89f039cce4d8f7d612b13caca0d398d6246f/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
[modify] https://crrev.com/010c89f039cce4d8f7d612b13caca0d398d6246f/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/010c89f039cce4d8f7d612b13caca0d398d6246f/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/010c89f039cce4d8f7d612b13caca0d398d6246f/components/omnibox/browser/autocomplete_match.h

Comment 2 by orinj@chromium.org, Jul 20

Status: Fixed (was: Assigned)

Comment 3 by phanindra.mandapaka@chromium.org, Jul 20

Labels: TE-Verified-69.0.3497.0 TE-Verified-M69
Able to reproduce the issue on chrome version 69.0.3496.0 (build without fix) as per the comment #0.
Verified the fix on Mac 10.13.5, Windows 10 and Ubuntu 17.10 using Chrome version # 69.0.3497.0 .
Attaching screen-cast for reference.
Observed that  " First suggestion is google.com, with a single-line  " 
The fix is working as expected, adding Verified labels

Thanks...!
865501.mp4
1.1 MB View Download
►

Sign in to add a comment