The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03fbfadf3fe0238140b65730262a805022a0492b

commit 03fbfadf3fe0238140b65730262a805022a0492b
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Fri Aug 03 16:01:11 2018

Add mechanism to instantiate multiple LanguageModels

This patch adds a way to create secondary LanguageModels in the
LanguageModelManager. This will allow using the GeoLanguageModel to
sort languages based on geographic location, as well as implement
metrics that compare the predictions of the different models.

BUG:  865500 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2e710ef74beaf6a3323a3b882e41c4ed47052a7d
Reviewed-on: https://chromium-review.googlesource.com/1142354
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580562}
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/chrome/browser/language/language_model_manager_factory.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/components/language/core/browser/language_model_manager.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/components/language/core/browser/language_model_manager.h
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/ios/chrome/browser/language/language_model_manager_factory.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/ios/web_view/internal/language/web_view_language_model_manager_factory.cc
[modify] https://crrev.com/03fbfadf3fe0238140b65730262a805022a0492b/ios/web_view/internal/translate/web_view_translate_client.mm

As of patch https://chromium-review.googlesource.com/c/chromium/src/+/1143705, this UI currently looks like the attached screenshot.

Deleted: screencap.png 117 KB

	screencap.png 117 KB View Download

Will the "header" bit with most likely languages based on geo be implemented in the next patch?

Yep, that's the plan!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0a027d70b096625c8c5524624ae9c7ad8d8e295

commit c0a027d70b096625c8c5524624ae9c7ad8d8e295
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Aug 30 17:11:56 2018

Add an explicit language prompt on Android for experiment

Bug:  865500 
Change-Id: I3216ff4dc97661409597740a613c5947bc4e09e2
Reviewed-on: https://chromium-review.googlesource.com/1143705
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587634}
[add] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/android/java/res/layout/language_ask_prompt_row.xml
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[add] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/android/java_sources.gni
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/browser/about_flags.cc
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/components/language/core/common/language_experiments.cc
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/components/language/core/common/language_experiments.h
[modify] https://crrev.com/c0a027d70b096625c8c5524624ae9c7ad8d8e295/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1fd2bc1f908345f489f15a138bb450b7c053dc0

commit d1fd2bc1f908345f489f15a138bb450b7c053dc0
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Sep 06 14:37:45 2018

Only show explicit language ask once

Bug:  865500 
Change-Id: I51eec8d3cbd6bd474af8d3b5275a433899f232fc
Reviewed-on: https://chromium-review.googlesource.com/1207131
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589160}
[modify] https://crrev.com/d1fd2bc1f908345f489f15a138bb450b7c053dc0/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/d1fd2bc1f908345f489f15a138bb450b7c053dc0/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
[modify] https://crrev.com/d1fd2bc1f908345f489f15a138bb450b7c053dc0/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/d1fd2bc1f908345f489f15a138bb450b7c053dc0/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/d1fd2bc1f908345f489f15a138bb450b7c053dc0/components/translate/core/browser/translate_prefs.h

Hey Anthony, how hard would it be to show it one more time if the user ignores it?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee87a088044e1be8e87c5491151659c7724fd17b

commit ee87a088044e1be8e87c5491151659c7724fd17b
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Fri Sep 07 16:22:01 2018

Save accept languages changes in explicit prompt experiment

Bug:  865500 
Change-Id: I104a80f132b5ab0420f242328227150e05e7fb93
Reviewed-on: https://chromium-review.googlesource.com/1211506
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589539}
[modify] https://crrev.com/ee87a088044e1be8e87c5491151659c7724fd17b/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f99312892b59e1969a53eb1b263ccfada9a6121

commit 6f99312892b59e1969a53eb1b263ccfada9a6121
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Sep 17 16:13:28 2018

Order the languages in the Explicit Language Prompt's list.

Bug:  865500 
Change-Id: I7b8b4cab27a40b4bd5fc435d46fd30860daf44fa
Reviewed-on: https://chromium-review.googlesource.com/1214163
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591699}
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/chrome/android/BUILD.gn
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/chrome/android/java/DEPS
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/chrome/browser/BUILD.gn
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/chrome/browser/prefs/browser_prefs.cc
[add] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/android/BUILD.gn
[add] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/android/DEPS
[add] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/android/geo_language_provider_bridge.cc
[add] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/android/java/src/org/chromium/components/language/GeoLanguageProviderBridge.java
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/content/browser/BUILD.gn
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/content/browser/geo_language_model_unittest.cc
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/content/browser/geo_language_provider.cc
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/content/browser/geo_language_provider.h
[modify] https://crrev.com/6f99312892b59e1969a53eb1b263ccfada9a6121/components/language/content/browser/geo_language_provider_unittest.cc

Requesting merge for the patch in comment #11

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

+benmason@ explicitly since this is an Android change. This feature is behind a flag and only enabled on a small subset of users in India. It was also confirmed to work without issue on Canary.

Approved for merge into 70, branch 3538.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b

commit db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Sep 18 21:28:45 2018

Only show explicit language ask once

Bug:  865500 
Change-Id: I51eec8d3cbd6bd474af8d3b5275a433899f232fc
Reviewed-on: https://chromium-review.googlesource.com/1207131
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589160}(cherry picked from commit d1fd2bc1f908345f489f15a138bb450b7c053dc0)
Reviewed-on: https://chromium-review.googlesource.com/1231841
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#505}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
[modify] https://crrev.com/db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/db5ffc49e6d8d3e4ca36fadf365808e89cbbd38b/components/translate/core/browser/translate_prefs.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92c375c547c93c1faaebc608f983dde3bb2f8be4

commit 92c375c547c93c1faaebc608f983dde3bb2f8be4
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Sep 18 21:29:30 2018

Save accept languages changes in explicit prompt experiment

Bug:  865500 
Change-Id: I104a80f132b5ab0420f242328227150e05e7fb93
Reviewed-on: https://chromium-review.googlesource.com/1211506
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589539}(cherry picked from commit ee87a088044e1be8e87c5491151659c7724fd17b)
Reviewed-on: https://chromium-review.googlesource.com/1232039
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#506}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/92c375c547c93c1faaebc608f983dde3bb2f8be4/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a32d43005f29161ab9e74a9c8c1d45f56de11b2

commit 0a32d43005f29161ab9e74a9c8c1d45f56de11b2
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Sep 20 15:16:23 2018

Order the languages in the Explicit Language Prompt's list.

TBR=anthonyvd@chromium.org

(cherry picked from commit 6f99312892b59e1969a53eb1b263ccfada9a6121)

Bug:  865500 
Change-Id: I7b8b4cab27a40b4bd5fc435d46fd30860daf44fa
Reviewed-on: https://chromium-review.googlesource.com/1214163
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591699}
Reviewed-on: https://chromium-review.googlesource.com/1236496
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#542}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/chrome/android/BUILD.gn
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/chrome/android/java/DEPS
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/chrome/browser/BUILD.gn
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/chrome/browser/prefs/browser_prefs.cc
[add] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/android/BUILD.gn
[add] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/android/DEPS
[add] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/android/geo_language_provider_bridge.cc
[add] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/android/java/src/org/chromium/components/language/GeoLanguageProviderBridge.java
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/content/browser/BUILD.gn
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/content/browser/geo_language_model_unittest.cc
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/content/browser/geo_language_provider.cc
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/content/browser/geo_language_provider.h
[modify] https://crrev.com/0a32d43005f29161ab9e74a9c8c1d45f56de11b2/components/language/content/browser/geo_language_provider_unittest.cc

The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a32d43005f29161ab9e74a9c8c1d45f56de11b2
Commit: 0a32d43005f29161ab9e74a9c8c1d45f56de11b2
Author: anthonyvd@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-09-20 15:16:23 +0000 UTC
Order the languages in the Explicit Language Prompt's list.

TBR=anthonyvd@chromium.org

(cherry picked from commit 6f99312892b59e1969a53eb1b263ccfada9a6121)

Bug:  865500 
Change-Id: I7b8b4cab27a40b4bd5fc435d46fd30860daf44fa
Reviewed-on: https://chromium-review.googlesource.com/1214163
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591699}
Reviewed-on: https://chromium-review.googlesource.com/1236496
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#542}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}