New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865486 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 23
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocking:
issue 767282



Sign in to add a comment

VR: Refactor App button gestures out of VrShellGl

Project Member Reported by acondor@chromium.org, Jul 19

Issue description

VrShellGl currently does both detection and handling of the gestures 
originated by pressing the app button. Detection should go to the GestureDetector and handling to the Ui.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf6c3250f68c48564862d2e7df7ef053821ecf48

commit cf6c3250f68c48564862d2e7df7ef053821ecf48
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Fri Jul 20 19:20:43 2018

VR: Use PlatformController interface for the GestureDetector

This is a step towards making the GestureDetector detect gestures
triggered by other buttons of the PlatformController.

Bug:  865486 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifbdfc28b850fae81446e21caf42027506f7bf522
Reviewed-on: https://chromium-review.googlesource.com/1143712
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576948}
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/android/vr/vr_controller.h
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/vr/gesture_detector.cc
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/vr/gesture_detector.h
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/vr/gesture_detector_unittest.cc
[modify] https://crrev.com/cf6c3250f68c48564862d2e7df7ef053821ecf48/chrome/browser/vr/platform_controller.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/570c323d0b14cb505f206abc8f8b92c0cc292b38

commit 570c323d0b14cb505f206abc8f8b92c0cc292b38
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Mon Jul 23 16:46:47 2018

VR: Move menu button gesture detection off VrShellGl

Also replacing `app` by `menu` as the platform agnostic button name.
This is part of an effort of splitting the monolitic VrShellGl and add
tests to each part.

Bug:  865486 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7aa916b61d74ddada59c4cd4c8608c1ec25a7e23
Reviewed-on: https://chromium-review.googlesource.com/1145239
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577187}
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/android/vr/vr_controller.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/gesture_detector.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/gesture_detector.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/gesture_detector_unittest.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/input_event.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/model/model.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/platform_controller.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/ui.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/ui.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/570c323d0b14cb505f206abc8f8b92c0cc292b38/chrome/browser/vr/ui_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment