New issue
Advanced search Search tips

Issue 865474 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 852954



Sign in to add a comment

Chromad: Streamline UX tweaks

Project Member Reported by rsorokin@chromium.org, Jul 19

Issue description

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5fabc0d914af8998de8cb231756b00f9cd17e85

commit d5fabc0d914af8998de8cb231756b00f9cd17e85
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed Aug 22 09:13:15 2018

cros: Change attributes 'label' and 'error' to slots.

* 'label' and 'error' attributes of gaia-input moved to slots.
* added 'invalid-state-cleared' event.
* set aria-label for input inside gaia-input container.

BUG= chromium:865474 ,chromium:853571
TEST=manual

Change-Id: Ia14de60ad90f3055a3f0e2b2bcfe84ca1502b114
Reviewed-on: https://chromium-review.googlesource.com/1183240
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584980}
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/active_directory_password_change.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/gaia_input.css
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/gaia_input.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/gaia_input.js
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/gaia_input_form.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/gaia_input_form.js
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/gaia_password_changed.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/d5fabc0d914af8998de8cb231756b00f9cd17e85/chrome/browser/resources/chromeos/login/saml_confirm_password.html

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ec654dfd58768e18055cccc7add1e1c74f8de40

commit 5ec654dfd58768e18055cccc7add1e1c74f8de40
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed Sep 26 16:59:07 2018

Chromad: Streamline UX update to oobe-dialog

* Use oobe-dialog instead of gaia-card

To try follow go/streamlinesteps

BUG= chromium:865474 , chromium:853571
TEST=manual + existing tests
TBR=poromov@chromium.org

Change-Id: Ibd59001096b5378f69a61a41cb7a9e14a7c5f32f
Reviewed-on: https://chromium-review.googlesource.com/1151305
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594352}
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/chromeos/login/enrollment/enrollment_screen.h
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/chromeos/login/test/js_checker.cc
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/chromeos/login/test/js_checker.h
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/BUILD.gn
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/gaia_button.css
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/gaia_input.html
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/offline_ad_login.css
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/offline_ad_login.js
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/oobe_dialog_host_behavior.js
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.html
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/5ec654dfd58768e18055cccc7add1e1c74f8de40/ui/webui/resources/cr_elements/cr_input/cr_input.html

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/631846ffc7976d77c486d6cd431b5731ab8ff934

commit 631846ffc7976d77c486d6cd431b5731ab8ff934
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Oct 09 13:29:15 2018

Active Directory UX tweaks

Changed messages, added back button on the login screen, added progress
on the domain join screen

BUG= chromium:865474 

Change-Id: I2007bd043f91f1eb6fbe9eb97e7a4a849101dfbb
Reviewed-on: https://chromium-review.googlesource.com/c/1268256
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597894}
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/resources/chromeos/login/offline_ad_login.css
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/resources/chromeos/login/offline_ad_login.js
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/631846ffc7976d77c486d6cd431b5731ab8ff934/chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Labels: -M-70 M-71
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified fixed. Test plan doc updated according to new UI (https://docs.google.com/document/d/1E5KRWz0y1556E0v2fa0WmKG2dWWoTmPVC44iaYNH0ig/).

Chrome OS: 11151.3.0
Chrome: 71.0.3578.0
Device: Whitetip

Sign in to add a comment