New issue
Advanced search Search tips

Issue 865469 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Jul 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Send text direction from the renderer for displaying the credentials dropdown from the browser

Project Member Reported by ioanap@chromium.org, Jul 19 
The display of the credentials dropdown can be initiated by the browser for a form field for which password generation should be offered. This is done when the generation option needs to be added to the dropdown to avoid conflicts between the generation UI and the filling UI. 

Initiating the display of the credentials dropdown from the browser side requires that the text direction is passed to the browser process beforehand.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b4f61db50f560c233f1115f5db673651f9bece

commit f5b4f61db50f560c233f1115f5db673651f9bece
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Jul 24 09:26:57 2018

Pass TextDirection from the renderer for the password generation.

The direction is used if instead of the password generation we trigger the
standard password drop-down.

Bug:  865469 
Change-Id: I3da15c0446753e69f84d352c7095c40d571030ce
Reviewed-on: https://chromium-review.googlesource.com/1145300
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577468}
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/content/renderer/password_generation_agent.h
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/f5b4f61db50f560c233f1115f5db673651f9bece/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Comment 2 by vasi...@chromium.org, Jul 25

Labels: Merge-Rejected-69 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
I'd like to merge r577468 back to M69. It's required for the correct rendering of the password drop-down for RTL sites.

Comment 3 by vasi...@chromium.org, Jul 25

Labels: -Merge-Rejected-69 Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 26

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7743bd7e1882b435320ec51e2970b52cd788b331

commit 7743bd7e1882b435320ec51e2970b52cd788b331
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Jul 26 10:35:31 2018

Pass TextDirection from the renderer for the password generation.

The direction is used if instead of the password generation we trigger the
standard password drop-down.

TBR=vasilii@chromium.org

(cherry picked from commit f5b4f61db50f560c233f1115f5db673651f9bece)

Bug:  865469 
Change-Id: I3da15c0446753e69f84d352c7095c40d571030ce
Reviewed-on: https://chromium-review.googlesource.com/1145300
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577468}
Reviewed-on: https://chromium-review.googlesource.com/1151188
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#104}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/content/renderer/password_generation_agent.h
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/core/common/password_generation_util.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/autofill/core/common/password_generation_util.h
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/7743bd7e1882b435320ec51e2970b52cd788b331/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Comment 6 by vasi...@chromium.org, Jul 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment