Tab grid flashes under tab grid toolbars during transition animation. |
||||||
Issue descriptionIf there are grid cells under the top or bottom tab grid toolbar, they will flash briefly as as the toolbars fade out during the transition while leaving the tab grid.
,
Jul 30
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/481c3593b63e6cbf9e056714ae958cd8c42621cf commit 481c3593b63e6cbf9e056714ae958cd8c42621cf Author: Mark Cogan <marq@google.com> Date: Wed Aug 01 15:08:59 2018 [iOS] Fix toolbar flash in grid transition. This CL fixes the flash of grid visibility under the grid toolbars that happens during the grid transitions. The fix has two parts. The first is to fade the grid toolbar backgrounds to black (masking out the other grid cells) instead of fading them to alpha zero. The toolbar controls still fade out, however. The second part is to move the expanding tab in the view hierarchy so that it sits on top of the tab grid, while the rest of the animating cells are inserted inside it. The API for this is somewhat clumsy at this stage; the animation class (itself a UIView) exposes the animating cell as a property, and the animator reparents it to be above the presenting view during the animation. Bug: 865454 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ced094dfc053233f0dcbb5adb856639528c5daa Reviewed-on: https://chromium-review.googlesource.com/1154974 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579805} [modify] https://crrev.com/481c3593b63e6cbf9e056714ae958cd8c42621cf/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/481c3593b63e6cbf9e056714ae958cd8c42621cf/ios/chrome/browser/ui/tab_grid/transitions/grid_to_visible_tab_animator.mm [modify] https://crrev.com/481c3593b63e6cbf9e056714ae958cd8c42621cf/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.h [modify] https://crrev.com/481c3593b63e6cbf9e056714ae958cd8c42621cf/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm
,
Aug 1
,
Aug 2
Verified on Canary 70.0.3510.0
,
Aug 2
Approved.
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23fa89fa8c8a4523b08ec0d25ad3aca601839f51 commit 23fa89fa8c8a4523b08ec0d25ad3aca601839f51 Author: Mark Cogan <marq@google.com> Date: Fri Aug 03 06:20:43 2018 [iOS] Fix toolbar flash in grid transition. This CL fixes the flash of grid visibility under the grid toolbars that happens during the grid transitions. The fix has two parts. The first is to fade the grid toolbar backgrounds to black (masking out the other grid cells) instead of fading them to alpha zero. The toolbar controls still fade out, however. The second part is to move the expanding tab in the view hierarchy so that it sits on top of the tab grid, while the rest of the animating cells are inserted inside it. The API for this is somewhat clumsy at this stage; the animation class (itself a UIView) exposes the animating cell as a property, and the animator reparents it to be above the presenting view during the animation. Bug: 865454 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ced094dfc053233f0dcbb5adb856639528c5daa Reviewed-on: https://chromium-review.googlesource.com/1154974 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579805}(cherry picked from commit 481c3593b63e6cbf9e056714ae958cd8c42621cf) Reviewed-on: https://chromium-review.googlesource.com/1161781 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#374} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/23fa89fa8c8a4523b08ec0d25ad3aca601839f51/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm [modify] https://crrev.com/23fa89fa8c8a4523b08ec0d25ad3aca601839f51/ios/chrome/browser/ui/tab_grid/transitions/grid_to_visible_tab_animator.mm [modify] https://crrev.com/23fa89fa8c8a4523b08ec0d25ad3aca601839f51/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.h [modify] https://crrev.com/23fa89fa8c8a4523b08ec0d25ad3aca601839f51/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkhorimoto@chromium.org
, Jul 19