New issue
Advanced search Search tips

Issue 865452 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Tab content flickers when exiting tab grid.

Project Member Reported by marq@chromium.org, Jul 19

Issue description

The tab content cross-fade creates a distracting flicker when there's no difference between the tab grid cell snapshot and the tab content (which is most of the time).

 
Components: UI>Browser>Mobile>TabSwitcher
Status: Started (was: Assigned)
Status: Fixed (was: Started)
CL is https://chromium-review.googlesource.com/c/chromium/src/+/1144938
Labels: Merge-Request-65
Status: Verified (was: Fixed)
Verified on canary 70.0.3502.0
Labels: -Merge-Request-65 Merge-Request-69
Labels: -Merge-Request-69 Merge-Approved-69
Approved!
Labels: -Merge-Approved-69 merge-merged-3497
CL had the wrong bug number, but these are the merge headers:

[iOS] Remove content flicker when exiting tab grid.

The tab grid animation includes a cross-fade from the grid cell's snapshot
to the tab's content view. In cases where these views are identical, the
crossfade was introducing a flicker.

This CL has the TabGridViewController track its initial frame, and it will
mark the animation layout if it has changed (due to rotation). The animation
will only crossfade the content if this change has happened.

The timing of the crossfade is also changed.


Bug: 865440
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I838641fbd069222aae98f541ec8b0b7515f1529c
Reviewed-on: https://chromium-review.googlesource.com/1144938
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576832}(cherry picked from commit c386ff1919f8670e349764827947ff6a876df2fc)
Reviewed-on: https://chromium-review.googlesource.com/1150381
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#103}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}

Sign in to add a comment