New issue
Advanced search Search tips

Issue 865413 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Password Manager logging improvement

Project Member Reported by dvadym@chromium.org, Jul 19

Issue description

Password Manager logs (chrome://password-manager-internals) have a lot of useful information for debugging. But there is definitely a room for improvement. This is an umbrella bug for any password-manager-internals related improvements, refactorings etc
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed9ddcaef93429474b18266245e9662cb375cb0b

commit ed9ddcaef93429474b18266245e9662cb375cb0b
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu Jul 19 17:05:31 2018

Adding renderer ids to Password Manager logs.

Form and input elements unique renderer ids are getting more and more
used in Password Manager. This CL adds logging them to
chrome://password-manager-internals.

Some examples how it looks like in logs:
Form:
  Form renderer id: 0
Field:
  email: type=email, renderer_id = 2, visible, empty

Username/password element in PasswordForm
  Username element renderer id : 18

Also this CL adds logging of PasswordForm.confirmation_password_element.

Bug: 865413
Change-Id: Ia0e626a3c8b14679578addd88e9ec3f0911da150
Reviewed-on: https://chromium-review.googlesource.com/1143400
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576532}
[modify] https://crrev.com/ed9ddcaef93429474b18266245e9662cb375cb0b/components/autofill/content/renderer/renderer_save_password_progress_logger.cc
[modify] https://crrev.com/ed9ddcaef93429474b18266245e9662cb375cb0b/components/autofill/core/common/save_password_progress_logger.cc
[modify] https://crrev.com/ed9ddcaef93429474b18266245e9662cb375cb0b/components/autofill/core/common/save_password_progress_logger.h
[modify] https://crrev.com/ed9ddcaef93429474b18266245e9662cb375cb0b/components/password_manager/core/browser/browser_save_password_progress_logger.cc
[modify] https://crrev.com/ed9ddcaef93429474b18266245e9662cb375cb0b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

Components: UI>Browser>Passwords

Sign in to add a comment