New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865411 link

Starred by 2 users
Status: Fixed
Owner:
█ kraynov@chromium.org
Xoogler
Closed: Oct 3
Cc:
eseckler@chromium.org
skyos...@chromium.org
hajimehoshi@chromium.org
altimin@chromium.org
gab@chromium.org
█ alexclarke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

SequenceManager: Split TaskQueue and SingleThreadTaskRunner implementation.

Project Member Reported by kraynov@chromium.org, Jul 19 
Current proposal:
1. Make TaskQueueTaskRunner instead of TaskQueueWithTaskType (in blink).
2. Drop SingleThreadTaskRunner implementation in the TaskQueue class.
3. Drop ref-counting for TaskQueue and make SequenceManager manager its lifetime.
4. Remove spaghetti between TaskQueue and TaskQueueImpl by making a direct inheritance.

Comment 2 by gab@chromium.org, Jul 19 

Re. Googlers-only : there's no need for this. Let's keep good open source
habits and make this a public doc (from your chromium.org account, comment
access to chromium-dev, view-only to the world).

Le jeu. 19 juill. 2018 11 h 46, kraynov via monorail <
monorail+v2.3634340931@chromium.org> a écrit :

Comment 4 by gab@chromium.org, Jul 19 

Thanks :)

Le jeu. 19 juill. 2018 12 h 38, kraynov via monorail <
monorail+v2.3634340931@chromium.org> a écrit :
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f84c49f4030b93e7a953ff3bf46ead47e00fcc

commit 48f84c49f4030b93e7a953ff3bf46ead47e00fcc
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu Jul 26 13:38:02 2018

SequenceManager: Introduce TaskQueueTaskRunner.

First step in splitting TaskQueue and SingleThreadTaskRunner impl.
Blink's TaskQueueWithTaskType got removed along the way.

Design doc:
https://docs.google.com/document/d/1vJXk2HAd7P0_sAjRWwl5jjEq027zG-CQN6mV3l7lWJs

TBR=gab@chromium.org

Bug:  865411 
Change-Id: Ibc465034a15d48abcf5125358efb0d3ee755728e
Reviewed-on: https://chromium-review.googlesource.com/1143402
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578285}
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/base/BUILD.gn
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/base/task/sequence_manager/task_queue.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/base/task/sequence_manager/task_queue.h
[add] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/base/task/sequence_manager/task_queue_task_runner.cc
[add] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/base/task/sequence_manager/task_queue_task_runner.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/c877eee31debef134c7ae56f3e3e2c950f6845cc/third_party/blink/renderer/platform/scheduler/child/task_queue_with_task_type.cc
[delete] https://crrev.com/c877eee31debef134c7ae56f3e3e2c950f6845cc/third_party/blink/renderer/platform/scheduler/child/task_queue_with_task_type.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/main_thread/resource_loading_task_runner_handle_impl.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/public/worker_scheduler.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/48f84c49f4030b93e7a953ff3bf46ead47e00fcc/third_party/blink/renderer/platform/timer_test.cc

Comment 6 by hajimehoshi@chromium.org, Aug 2

Cc: hajimehoshi@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d002ad29e534de904f5461fbb163448b5d3140b9

commit d002ad29e534de904f5461fbb163448b5d3140b9
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Sep 21 15:10:49 2018

Introduce TaskQueueProxy.

Aimed to avoid ref-counted lifecycle of TaskQueueImpl.
SingleThreadTaskRunnner implementation will be dropped
from TaskQueue shortly. See bug for details.

TBR=gab@chromium.org

Bug:  865411 
Change-Id: I92a3965299cb1c829e8a385f4bb2690383436107
Reviewed-on: https://chromium-review.googlesource.com/1234474
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593185}
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/BUILD.gn
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue.cc
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue_impl.cc
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue_impl.h
[add] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue_proxy.cc
[add] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue_proxy.h
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue_task_runner.cc
[modify] https://crrev.com/d002ad29e534de904f5461fbb163448b5d3140b9/base/task/sequence_manager/task_queue_task_runner.h
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7099146dffef19375ed5330a2390fa94d8a2fb1f

commit 7099146dffef19375ed5330a2390fa94d8a2fb1f
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Sep 25 13:45:05 2018

Remove task runner implementation from SequenceManager's TaskQueue.

TBR=haraken@chromium.org

Bug:  865411 
Change-Id: I36b802de2df85d31175ddb5ce5f9035686eb004c
Reviewed-on: https://chromium-review.googlesource.com/1194364
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593915}
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/base/task/sequence_manager/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/base/task/sequence_manager/sequence_manager_perftest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/base/task/sequence_manager/task_queue.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/base/task/sequence_manager/test/test_task_queue.h
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/core/workers/worker_thread.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
[modify] https://crrev.com/7099146dffef19375ed5330a2390fa94d8a2fb1f/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf4154e9b07ce8a5c9de0b49356383277d46485

commit eaf4154e9b07ce8a5c9de0b49356383277d46485
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Oct 01 12:05:20 2018

Move away PostedTask from TaskQueue.

In order to remove unrelevant clutter from TaskQueue which
eventually will become a lean interface.

TBR=gab@chromium.org

Bug:  865411 
Change-Id: Ia0e2284c745895cf2869308be8af3fa164438dff
Reviewed-on: https://chromium-review.googlesource.com/1245469
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595429}
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/BUILD.gn
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue.cc
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue_impl.cc
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue_impl.h
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue_proxy.cc
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue_proxy.h
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue_selector_unittest.cc
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/task_queue_task_runner.cc
[add] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/tasks.cc
[add] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/tasks.h
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/test/fake_task.cc
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/work_queue_sets_unittest.cc
[modify] https://crrev.com/eaf4154e9b07ce8a5c9de0b49356383277d46485/base/task/sequence_manager/work_queue_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3076ea5b1345c88e32b98fe8aa4dede7857c58c

commit d3076ea5b1345c88e32b98fe8aa4dede7857c58c
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Oct 02 11:47:09 2018

Simplify TaskQueue(Impl)::Task.

Bug:  865411 
Change-Id: I068554583da9190c6d2e84c510f4d76d1bf4d742
Reviewed-on: https://chromium-review.googlesource.com/1245715
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595800}
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/sequence_manager_impl.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/sequence_manager_impl.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/task_queue.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/task_queue_impl.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/task_queue_impl.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/task_queue_selector_unittest.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/tasks.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/tasks.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/test/fake_task.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/test/fake_task.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/time_domain.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/time_domain.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/time_domain_unittest.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/work_queue.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/work_queue.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/work_queue_sets_unittest.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/base/task/sequence_manager/work_queue_unittest.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/components/scheduling_metrics/thread_metrics.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/components/scheduling_metrics/thread_metrics.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/common/metrics_helper.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/common/metrics_helper.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/compositor_metrics_helper.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/worker_metrics_helper.h
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/d3076ea5b1345c88e32b98fe8aa4dede7857c58c/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Comment 12 by kraynov@chromium.org, Oct 3

Status: Fixed (was: Assigned)
Subsequent ownership refactoring should be tracked in another bug
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef25f4c5f6ae617d028120e1369d300cd631ebb

commit 8ef25f4c5f6ae617d028120e1369d300cd631ebb
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Nov 16 22:52:32 2018

Remove PostTask methods in TestTaskQueue.

TaskQueues shouldn't be confused with task runners.

Bug:  865411 
Change-Id: Ibc37eb30de002f126a76231122f77c16fc3e8e35
Reviewed-on: https://chromium-review.googlesource.com/c/1336470
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609007}
[modify] https://crrev.com/8ef25f4c5f6ae617d028120e1369d300cd631ebb/base/task/sequence_manager/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/8ef25f4c5f6ae617d028120e1369d300cd631ebb/base/task/sequence_manager/test/test_task_queue.h
[modify] https://crrev.com/8ef25f4c5f6ae617d028120e1369d300cd631ebb/third_party/blink/renderer/platform/scheduler/test/fuzzer/thread_manager.cc
►

Sign in to add a comment