New issue
Advanced search Search tips

Issue 865410 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 19
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened



Sign in to add a comment

PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is Flaky

Project Member Reported by Findit, Jul 19

Issue description

Project Member

Comment 2 by Findit, Jul 19


Findit identified the culprit r576428 with confidence 100.0% in the config "chromium.win / Win10 Tests x64"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyiAILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLRAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjU3MjcvbmV0d29ya19zZXJ2aWNlX2Jyb3dzZXJfdGVzdHMgb24gV2luZG93cy0xMC0xNTA2My9VR2xqZEhWeVpVbHVVR2xqZEhWeVpWZHBibVJ2ZDBOdmJuUnliMnhzWlhKQ2NtOTNjMlZ5VkdWemRDNVZjR1JoZEdWV2FXUmxiMU55WTB0bFpYQnpVR2xqZEhWeVpVbHVVR2xqZEhWeVpWZHBibVJ2ZDA5d1pXNWxaQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If the culprit above is wrong, please file a bug using this link and hit submit:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyiAILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLRAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjU3MjcvbmV0d29ya19zZXJ2aWNlX2Jyb3dzZXJfdGVzdHMgb24gV2luZG93cy0xMC0xNTA2My9VR2xqZEhWeVpVbHVVR2xqZEhWeVpWZHBibVJ2ZDBOdmJuUnliMnhzWlhKQ2NtOTNjMlZ5VkdWemRDNVZjR1JoZEdWV2FXUmxiMU55WTB0bFpYQnpVR2xqZEhWeVpVbHVVR2xqZEhWeVpWZHBibVJ2ZDA5d1pXNWxaQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b0138d2ec5f88119917d183ac5039302d88460

commit 94b0138d2ec5f88119917d183ac5039302d88460
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Jul 19 12:26:07 2018

Revert "[Picture-in-Picture] Update window playback when video src changes."

This reverts commit 93488940ae5770af18ca5405395a206b426756a6.

Reason for revert: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is very flaky:  https://crbug.com/865410 

Original change's description:
> [Picture-in-Picture] Update window playback when video src changes.
> 
> This CL make sure the Picture-in-Picture window playback state is
> reflected when video src changes. It is a follow-up to
> https://chromium-review.googlesource.com/1089331
> 
> Bug:  726619 
> Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3
> Reviewed-on: https://chromium-review.googlesource.com/1133168
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576428}

TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org

Change-Id: I2b35b9ef8c119915b1c07f9f12321439c3242ab2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  726619 ,  865410 
Reviewed-on: https://chromium-review.googlesource.com/1143324
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576454}
[modify] https://crrev.com/94b0138d2ec5f88119917d183ac5039302d88460/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/94b0138d2ec5f88119917d183ac5039302d88460/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/94b0138d2ec5f88119917d183ac5039302d88460/content/browser/media/media_web_contents_observer.cc

Status: Fixed (was: Available)
 Issue 865426  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d94de87ceee4b2cb44eb33aea57cabaa0f8a37b

commit 4d94de87ceee4b2cb44eb33aea57cabaa0f8a37b
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Jul 20 00:59:12 2018

Reland "[Picture-in-Picture] Update window playback when video src changes."

This reverts commit 94b0138d2ec5f88119917d183ac5039302d88460.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[Picture-in-Picture] Update window playback when video src changes."
> 
> This reverts commit 93488940ae5770af18ca5405395a206b426756a6.
> 
> Reason for revert: PictureInPictureWindowControllerBrowserTest.UpdateVideoSrcKeepsPictureInPictureWindowOpened is very flaky:  https://crbug.com/865410 
> 
> Original change's description:
> > [Picture-in-Picture] Update window playback when video src changes.
> > 
> > This CL make sure the Picture-in-Picture window playback state is
> > reflected when video src changes. It is a follow-up to
> > https://chromium-review.googlesource.com/1089331
> > 
> > Bug:  726619 
> > Change-Id: Ic756c03aa023d3e4e229c7495686ea8f322503e3
> > Reviewed-on: https://chromium-review.googlesource.com/1133168
> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> > Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#576428}
> 
> TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org
> 
> Change-Id: I2b35b9ef8c119915b1c07f9f12321439c3242ab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  726619 ,  865410 
> Reviewed-on: https://chromium-review.googlesource.com/1143324
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576454}

TBR=dalecurtis@chromium.org,wolenetz@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,jochen@chromium.org,dullweber@chromium.org

Change-Id: Ia3931e803814eb9bf8bf56d44fd922f409cd5d8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  726619 ,  865410 
Reviewed-on: https://chromium-review.googlesource.com/1144560
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576731}
[modify] https://crrev.com/4d94de87ceee4b2cb44eb33aea57cabaa0f8a37b/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/4d94de87ceee4b2cb44eb33aea57cabaa0f8a37b/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/4d94de87ceee4b2cb44eb33aea57cabaa0f8a37b/content/browser/media/media_web_contents_observer.cc

Sign in to add a comment