New issue
Advanced search Search tips

Issue 865397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Avoid the adaptation of the decay in the reverberation model for bad performing filters in AEC3

Project Member Reported by peah@chromium.org, Jul 19

Issue description

The decay parameter in the exponential model of the reverberation is continually adapting even when the current linear filter is not performing well in AEC3.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09

commit ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Jul 30 22:34:19 2018

AEC3: Increasing the accuracy of the detection for early reverb

This CL introduces an adaptive estimation of the early reverb
in the estimation for the room reverberation. The benefits of
this is that for room with long early reflections there is
a lower risk of underestimating the reverberation.

This CL is for a landing the code in
https://webrtc-review.googlesource.com/c/src/+/87420,
and the review of the code was done in that CL. The author of
code is devicentepena@webrtc.org

Bug:  webrtc:9479 ,  chromium:865397 
Change-Id: Id6f57e2a684664aef96e8c502e66775f37da59da
Reviewed-on: https://webrtc-review.googlesource.com/91162
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24146}
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/aec3_common.h
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/aec_state.h
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/filter_analyzer.cc
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/filter_analyzer.h
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/residual_echo_estimator.cc
[add] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_decay_estimator.cc
[add] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_decay_estimator.h
[add] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_frequency_response.cc
[add] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_frequency_response.h
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_model_estimator.cc
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_model_estimator.h
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/modules/audio_processing/aec3/reverb_model_estimator_unittest.cc
[modify] https://crrev.com/ef5d5af3a07ae2e8dcf22655fa9cd908e5fb3b09/test/fuzzers/audio_processing_configs_fuzzer.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2250baa45e0f3946b1500d65b3b410bf2c51f21b

commit 2250baa45e0f3946b1500d65b3b410bf2c51f21b
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jul 31 07:32:52 2018

Roll src/third_party/webrtc 1899c1270f0c..168b4977f3c2 (2 commits)

https://webrtc.googlesource.com/src.git/+log/1899c1270f0c..168b4977f3c2


git log 1899c1270f0c..168b4977f3c2 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 buildbot@webrtc.org Roll chromium_revision fdf31b15b2..fb3a9711ab (579160:579262)
2018-07-30 peah@webrtc.org AEC3: Increasing the accuracy of the detection for early reverb


Created with:
  gclient setdep -r src/third_party/webrtc@168b4977f3c2

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:865397
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id138c35b1cf30747808c3286d9b9212e2054cb84
Reviewed-on: https://chromium-review.googlesource.com/1155888
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579333}
[modify] https://crrev.com/2250baa45e0f3946b1500d65b3b410bf2c51f21b/DEPS

Labels: M-70
Status: Fixed (was: Started)

Sign in to add a comment