New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865394 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 704259



Sign in to add a comment

Reporting: Add user_agent field to report

Project Member Reported by dcreager@chromium.org, Jul 19

Issue description

Per https://github.com/w3c/reporting/issues/52, we are now supposed to include the User-Agent string of the original request in any reports generated about that request.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6cb49f7a47325781c174e17dc6f348955c9cc7b

commit f6cb49f7a47325781c174e17dc6f348955c9cc7b
Author: Douglas Creager <dcreager@chromium.org>
Date: Thu Jul 19 20:14:53 2018

Reporting: Fill in user_agent field in reports

Per https://github.com/w3c/reporting/issues/52, we are now supposed to
include the User-Agent string of the original request in any reports
generated about that request.

TBR=markusheintz@chromium.org

Bug:  865394 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib49244399ed05398d598da1d02131153dd509306
Reviewed-on: https://chromium-review.googlesource.com/1140203
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576599}
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/chrome/browser/net/reporting_browsertest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/content/browser/net/reporting_service_proxy.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/network_error_logging/network_error_logging_service.h
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/network_error_logging/network_error_logging_service_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_browsing_data_remover_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_cache.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_cache.h
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_cache_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_delivery_agent.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_delivery_agent_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_garbage_collector_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_network_change_observer_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_report.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_report.h
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_service.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_service.h
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/reporting/reporting_service_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/url_request/url_request.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/url_request/url_request.h
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/url_request/url_request_test_util.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/url_request/url_request_test_util.h
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/f6cb49f7a47325781c174e17dc6f348955c9cc7b/services/network/network_context_unittest.cc

Status: Verified (was: Assigned)

Sign in to add a comment