New issue
Advanced search Search tips

Issue 865379 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Adjust vertical alignment of security state icon + host label in steady-state Omnibox

Project Member Reported by pschaffner@chromium.org, Jul 19

Issue description

stkhapugin@, I don't have specific values to give you, so lets just debug together in the simulator.
 
Cc: martijnb@chromium.org pschaffner@chromium.org stkhapugin@chromium.org
 Issue 865503  has been merged into this issue.
Labels: -Pri-2 Q2 M-69 MS-Omnibox Pri-1
Restoring priority and other flags.
Status: Started (was: Assigned)
We sat down with Martijn today and adjusted the horizontal spacing and X offset. 
Cc: kariahda@chromium.org
Labels: Merge-Request-69
Status: Fixed (was: Started)
Please verify that the lock icon is visually centered vertically, and the horizontal distance between the security icon and the URL is a bit wider than before.

No need for tests as this is a minor layout change. Requesting cherry-pick right away as this is a minor layout change. 
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 27

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: srikanthg@chromium.org
Please wait for canary verification to merge.
Status: Verified (was: Fixed)
Looks good. Page security is now aligned correctly.
Verified with few different state, http, https, info, invalid cert icons.

Verified on M70.0.3504.0 canary, iOS 11.4.1, 12.0
iPhoneX, iPad Pro.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25f86e1ad08bba838d4773062a808ce3018485b3

commit 25f86e1ad08bba838d4773062a808ce3018485b3
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Mon Jul 30 08:45:58 2018

Adjust various location bar element spacings.

Minor improvements to the location bar layout.

Bug:  865379 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5a7bfbc397cda4fdb607166dd7d5f0c3dfc468e1
Reviewed-on: https://chromium-review.googlesource.com/1151196
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578287}(cherry picked from commit d8e8fb73f0b95935c2ba8d29f1e727a7bc4a9994)
Reviewed-on: https://chromium-review.googlesource.com/1154807
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#201}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/25f86e1ad08bba838d4773062a808ce3018485b3/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/25f86e1ad08bba838d4773062a808ce3018485b3/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
[modify] https://crrev.com/25f86e1ad08bba838d4773062a808ce3018485b3/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
[modify] https://crrev.com/25f86e1ad08bba838d4773062a808ce3018485b3/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png

Verified in:

App Version: 69.0.3497.22 beta
Devices: iPhone 6 Plus, iPad Air
iOS Versions: 11.4.1, 12.0 beta 5

Looks good. Tested for different sites with http, https, info & invalid cert icons. 

Sign in to add a comment