New issue
Advanced search Search tips

Issue 865371 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Newly imported webaudio/the-audio-api test is failing

Project Member Reported by dullweber@chromium.org, Jul 19

Issue description

The test is failing on Mac, I will disable it.

external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4131

(Sheriff-o-matic failed to create a bug for this, so I'm doing it manually)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cfe9e51d6d8f95f7afdf29380dc4df1ad3fe4aa

commit 3cfe9e51d6d8f95f7afdf29380dc4df1ad3fe4aa
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Jul 19 11:47:36 2018

Disable panner-distance-clamping.html on Mac

Disable the-audio-api/the-pannernode-interface/panner-distance-clamping.html
on Mac.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4131

Tbr: rtoy@chromium.org
Bug:  865371 
Change-Id: I0c451ec5350c672fe75d18e6a0ee3610a40a6e09
Reviewed-on: https://chromium-review.googlesource.com/1143193
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576445}
[modify] https://crrev.com/3cfe9e51d6d8f95f7afdf29380dc4df1ad3fe4aa/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43646e208f6dc658f9674f2332801026847ae45e

commit 43646e208f6dc658f9674f2332801026847ae45e
Author: Raymond Toy <rtoy@chromium.org>
Date: Fri Jul 20 14:28:05 2018

Fix typo in panner-distance-clampling.html test

The should.throw() method now expects an actual error object instead
of a string and I think someone just forgot to change the
'RangeError' strings in this test to be just the RangeError object.

Bug:  865371 
Test: test passes again
Change-Id: I07cc057ff4f608a01ed3f35a0268b6e267078d13
Reviewed-on: https://chromium-review.googlesource.com/1144128
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576856}
[modify] https://crrev.com/43646e208f6dc658f9674f2332801026847ae45e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/43646e208f6dc658f9674f2332801026847ae45e/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html
[delete] https://crrev.com/28eb302d5f857deef7b08cd9d39a1e3c6605e75d/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt
[delete] https://crrev.com/28eb302d5f857deef7b08cd9d39a1e3c6605e75d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt
[delete] https://crrev.com/28eb302d5f857deef7b08cd9d39a1e3c6605e75d/third_party/WebKit/LayoutTests/platform/mac/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt
[delete] https://crrev.com/28eb302d5f857deef7b08cd9d39a1e3c6605e75d/third_party/WebKit/LayoutTests/platform/win/external/wpt/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt

Owner: rtoy@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment