New issue
Advanced search Search tips

Issue 865353 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview]'Fit to page' checkbox doesn't get unchecked and preview page doesn't change accordingly on changing the Scale size.

Reported by dchau...@etouch.net, Jul 19

Issue description

Chrome Version: 69.0.3496.0 (Official Build) Revision	4225deb99f054d45a757dbecf0de9421c5e4d05e-refs/branch-heads/3496@{#1} 32/64-bit.
OS: Win(7,8,8.1,10) 

Pre-condition: Enable 'Enable new Print Preview UI' flag from chrome://flags.
Test URL: http://www.orimi.com/pdf-test.pdf

What steps will reproduce the problem?
1. Launch Chrome, navigate to above Test URL or any PDF page and give print command.
2. Click on 'More settings' option and check 'Fit to page' checkbox.
3. Hover the mouse pointer on 'Scale' text-box so that up/down arrow appears.
4. Now click and hold on up/down arrow under scale text-box and observe.

Actual: 'Fit to page' checkbox doesn't get unchecked and size of preview page doesn't varies accordingly.
Expected: 'Fit to page' checkbox should get unchecked and size of preview page should varies accordingly.
 
This is a regression issue, broken in M-67 series, below is manual regression range:

Good build: 67.0.3382.0 (Revision: 546347)
Bad build: 67.0.3383.0 (Revision: 546671)

Unable to provide the bisect using bisect-per-revision script, Hence providing the bisect using Chromium builds.
You are probably looking for a change made after 546489 (known good), but no later than 546504 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/7a5a6984aebeafd361830070212ff99eefbcfa07..eee63eee9be83197a081b054cc5e07d0a593e58d

Suspecting: https://chromium.googlesource.com/chromium/src/+/eee63eee9be83197a081b054cc5e07d0a593e58d

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. This issue is not seen on Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) machines.
2. This issue is also reproducible on Stable #67.0.3396.99, Beta #68.0.3440.68 and Dev #69.0.3486.0

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
1.1 MB View Download
Cc: dpa...@chromium.org
When I tested this behavior is the same on both Windows and Linux.

The change in preview update behavior is working as intended. In the "actual" video and in my testing, as soon as the mouse is lifted, the value updates and fit to page is unchecked; it is only while the mouse is held down and the value is changing very quickly that the preview does not update. We added a timeout to this field to avoid immediately regenerating the preview as soon as the value changes, as this saves us from doing a large amount of unnecessary work. If the user clicks and holds the button, presumably they are trying to reach some new scaling value, at which point they will release the mouse; it is unlikely their intention is to generate dozens of previews with the intermediate scaling values, and for larger documents doing this becomes very time consuming and makes the UI seem less responsive.

The fit to page checkbox not immediately unchecking is a side effect of that change. I do not think it is an issue since it always ends up un-checked eventually, and leaving it while the mouse is down means that the preview state and the state of the checkbox always match. +dpapad@ for a second opinion on this, since unlike the preview regeneration behavior it was not something we specifically intended.
Labels: -Pri-1 Pri-3
I agree with Rebekah assessment overall.

Having said that, would it be feasible to manually uncheck the checkbox, even before any print preview regeneration is requested, as soon as the user interacts with the numerical input? Perhaps this would address the issue here with minimal effort.

Either way, I don't think this is a P1, so downgrading.

Sign in to add a comment