New issue
Advanced search Search tips

Issue 865350 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 773295



Sign in to add a comment

Migrate chrome/browser/io_thread_browsertest.cc to SimpleURLLoader

Project Member Reported by svil...@igalia.com, Jul 19

Issue description

This should be pretty similar to https://bugs.chromium.org/p/chromium/issues/detail?id=844915

There is a HangingURLFetcherDelegate which uses URLFetcher and the delegate to verify that the fetch hangs.
 
Blocking: 773295
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d49a3663dc4fa12c1f3f7eca04725bfea9208a70

commit d49a3663dc4fa12c1f3f7eca04725bfea9208a70
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Jul 19 16:48:24 2018

Migrate chrome/browser/io_thread_browsertest.cc to SimpleURLLoader

This CL moves io_thread_browsertest.cc away from URLFetcher replacing
it by SimpleURLLoader as part of the network servicification project.

Bug:  865350 
Change-Id: I9721e728976b69bf7ee4810c743f247872c81c3d
Reviewed-on: https://chromium-review.googlesource.com/1143261
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#576526}
[modify] https://crrev.com/d49a3663dc4fa12c1f3f7eca04725bfea9208a70/chrome/browser/io_thread_browsertest.cc

Status: Fixed (was: Assigned)
We can close this now
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6d8593a3ff0cbede6f25317704576bebe84654

commit aa6d8593a3ff0cbede6f25317704576bebe84654
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 08 15:57:07 2018

Enable now passing browser_tests with network service.

Bug:  769401 , 865350 , 844915 ,773295
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie7c87877597686927a401b64120c444c79a8912c
Reviewed-on: https://chromium-review.googlesource.com/1166593
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581577}
[modify] https://crrev.com/aa6d8593a3ff0cbede6f25317704576bebe84654/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

 Issue 844912  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3607b2f5c3f50c15b8ed3232c21970c8149db4b5

commit 3607b2f5c3f50c15b8ed3232c21970c8149db4b5
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Fri Aug 17 10:17:43 2018

Cleanup io_thread_browsertest.cc

There was some leftover code from https://crrev.com/c/1143261

BUG= 865350 

Change-Id: Ibe6561d4da605b4b8802e8f3862a023155c4f051
Reviewed-on: https://chromium-review.googlesource.com/1175122
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584012}
[modify] https://crrev.com/3607b2f5c3f50c15b8ed3232c21970c8149db4b5/chrome/browser/io_thread_browsertest.cc

Sign in to add a comment