New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865346 link

Starred by 1 user
Status: Fixed
Owner:
magchen@chromium.org
Closed: Jul 19
Cc:
█ kbr@chromium.org
cwallez@chromium.org
vmi...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 848097



Sign in to add a comment

Pixel_DirectComposition_Nonroot failing on Windows NVIDIA and AMD

Project Member Reported by cwallez@chromium.org, Jul 19 
This test has been failing on these bots since it was introduced.
 - The CL: https://chromium-review.googlesource.com/c/chromium/src/+/1136003
 - The first failing AMD Release run as an example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/1909

Traceback (most recent call last):
  _RunGpuTest at content\test\gpu\gpu_tests\gpu_integration_test.py:132
    self.RunActualGpuTest(url, *args)
  RunActualGpuTest at content\test\gpu\gpu_tests\pixel_integration_test.py:154
    tab, page.name, screenshot, page.expected_colors, dpr)
  _ValidateScreenshotSamples at content\test\gpu\gpu_tests\cloud_storage_integration_test_base.py:367
    self.GetParsedCommandLineOptions().test_machine_name)
  _CompareScreenshotSamples at content\test\gpu\gpu_tests\cloud_storage_integration_test_base.py:172
    str(actual_color.b) + "]")
  fail at .swarming_module\bin\Lib\unittest\case.py:410
    raise self.failureException(msg)
AssertionError: Expected pixel at [124, 4] (actual pixel (181, 4))  to be [255, 17, 24] but got [255, 38, 46]


magchen@, can you take a look since you added the test? Also the bug related to the CL mentions that this is supported on Intel only, should we restrict the tests to run only on Intel?

Comment 1 by magchen@chromium.org, Jul 19 

There is a nonroot underlay bug in the Direct Composition path. See bug 865556. The gradient function in \content\test\data\gpu\pixel_video_nonroot.html doesn't always take effect. 

Disabling the pixel comparisons at the blending area for now will be a quick solution to fix the failing on the bots. These comparisons can be put back in after bug 865556 is fixed.

The purpose of the Pixel_DirectComposition_Nonroot is to test the nonroot Direct composition test. It doesn't have to involve the gradient function.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/892ddc126dea4af83672676d08cdcc9bea7e0d81

commit 892ddc126dea4af83672676d08cdcc9bea7e0d81
Author: Maggie Chen <magchen@chromium.org>
Date: Thu Jul 19 23:06:42 2018

Fix the Pixel_DirectComposition_Nonroot test failures

In this Pixel_DirectComposition_Nonroot test (see
\content\test\data\gpu\pixel_video_nonroot.html) -webkit-gradient
is used and there is an issue with -gradient that it shows different
images on different machines. See http://crbug.com/865556.

The solutoin is to uppdate the solid color expectation area so only
the areas without the gradient effect are compared. The purpose of
this test is to exercise the nonroot path, not to test the gradient
functionality. The area with gradient will be put back after crbug
865556 is fixed.

media/test/data/README is also updated with more info on four-colors.mp4

Note:Direct Composition nonroot feature is not enabled by default except
for the protect video. This nonroot path is not used for most cases.

Bug:  865346 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I51b9cf15944bff5d26fd58b24611a560b51785e4
Reviewed-on: https://chromium-review.googlesource.com/1144242
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576680}
[modify] https://crrev.com/892ddc126dea4af83672676d08cdcc9bea7e0d81/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/892ddc126dea4af83672676d08cdcc9bea7e0d81/media/test/data/README

Comment 3 by magchen@chromium.org, Jul 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment