New issue
Advanced search Search tips

Issue 865343 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

leveldb GetChildren implementation inconsistency

Reported by milko.le...@mips.com, Jul 19

Issue description

UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce the problem:
1. Build leveldb_db_test
2. run leveldb_db_test

What is the expected behavior?
Test should finish without failures.

What went wrong?
Test reports failure:

==== Test DBTest.DestroyEmptyDir
../../third_party/leveldatabase/src/db/db_test.cc:1659: failed: 2 == 0

Did this work before? N/A 

Chrome version: r575971  Channel: n/a
OS Version: Ubuntu 16.04
Flash Version: Shockwave Flash 30.0 r0

Test assumes at [1] that used env does not filter out '.' and '..' special files, and this is true when using GetChildren() from posix_env.cc [2]. 

But this is not true for Chromium's implementation of GetChildren() [3] which uses GetDirectoryEntries() [4], where '.' and '..' are filtered out.

[1] https://cs.chromium.org/chromium/src/third_party/leveldatabase/src/db/db_test.cc?l=1658
[2] https://cs.chromium.org/chromium/src/third_party/leveldatabase/src/util/env_posix.cc?l=465
[3] https://cs.chromium.org/chromium/src/third_party/leveldatabase/env_chromium.cc?type=cs&q=env_chromium.cc&g=0&l=862
[4] https://cs.chromium.org/chromium/src/third_party/leveldatabase/env_chromium.cc?l=68
 
Labels: Needs-Milestone
Components: Internals>Storage
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET TE-NeedsTriageHelp
As per comment #0, this issue seems to be related Build leveldb_db_test which is out of scope from TE-End. Hence adding label "TE-NeedsTriageHelp" and requesting some one from Internals>Storage team to have a look into this and help in further triaging it.

Thanks...!
Components: Tests
Cc: -phanindra.mandapaka@chromium.org cmumford@chromium.org pwnall@chromium.org
Labels: -Pri-2 Pri-3
Status: Available (was: Unconfirmed)

Sign in to add a comment