New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865333 link

Starred by 2 users
Status: Fixed
Owner:
█ toshikikikuchi@google.com
Last visit > 30 days ago
Closed: Aug 2
Cc:
yamaguchi@chromium.org
tetsui@chromium.org
█ yoshiki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Network icon is seen enabled and able to click in Lock screen

Project Member Reported by mmanchala@chromium.org, Jul 19 
Chrome Version: 69.0.3494.0/10889.0.0 dev-channel Peppy,Daisy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> click on Uber Tray -> select 'Lock' option 
(2)In Lock screen click on Uber Tray -> observe Network icon is enabled and able to click i.e. able to turn off Wi-Fi
(3)Click on 'Connected network' -> observe enabled list of Wi-Fi networks and now try to select other Wi-Fi network and observe 'Join Wi-Fi' overlay is not seen
(Please refer Video and Screenshot)


Expected: 
a)Network icon should be disabled and should not be able to click 
b)Disabled list of Wi-Fi networks should be seen 

Actual: Instead 
a)Network icon is seen enabled and able to click 
b)Enabled list of Wi-Fi networks is seen but on selecting other Wi-Fi network 'Join Wi-Fi' overlay is not seen

This is Regression Issue as same is working fine in 69.0.3457.0/10784.0.0 dev-channel Reks


@tetsui : please confirm the Issue
Actual_EnabledNetwork.mp4
17.2 MB Download
Actual_EnabledNetwork.jpg
898 KB View Download
Expected_DisabledNetwork.jpg
995 KB View Download

Comment 1 by mmanchala@chromium.org, Jul 19 

Attaching Expected video for reference
Expected_DisabledNetwork.mp4
10.8 MB View Download

Comment 2 by tetsui@chromium.org, Jul 27

Cc: -ajha@chromium.org yoshiki@chromium.org tetsui@chromium.org
Owner: yamaguchi@chromium.org
yamaguchi@: Could you take a look? Thank you.

It might be useful: https://crrev.com/c/1146536

Comment 3 by tetsui@chromium.org, Jul 31

Cc: yamaguchi@chromium.org
Labels: -M-69 M-70
Owner: toshikikikuchi@google.com
This will be Toshiki-san's starter bug.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df0970e7ac5c116d47ab0699776ad707ccf1f0d9

commit df0970e7ac5c116d47ab0699776ad707ccf1f0d9
Author: Toshiki Kikuchi <toshikikikuchi@google.com>
Date: Wed Aug 01 09:44:53 2018

Disable Network button in lock screen.

Changing network settings is not allowed in lock screen. In previous
implementation, network button is enabled and able to click even in lock screen.

TEST=manual
BUG= 865333 

Change-Id: I1986b353d1cdbe698a5390a7861cdf804cc5990d
Reviewed-on: https://chromium-review.googlesource.com/1156189
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com>
Cr-Commit-Position: refs/heads/master@{#579742}
[modify] https://crrev.com/df0970e7ac5c116d47ab0699776ad707ccf1f0d9/ash/system/network/network_feature_pod_controller.cc
[modify] https://crrev.com/df0970e7ac5c116d47ab0699776ad707ccf1f0d9/ash/system/network/network_feature_pod_controller.h

Comment 5 by toshikikikuchi@google.com, Aug 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment