Over to ellyjones@ since she knows menus (or retriage!)

Is there a full spec for what the menu color scheme is meant to be? cc bettes@

https://chromium-review.googlesource.com/c/chromium/src/+/1148462

Kicking to M70 - this is turning out to be harder than it seemed.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec662f59629f0386eaffd62da0bba450b3a28a3

commit 7ec662f59629f0386eaffd62da0bba450b3a28a3
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Aug 27 18:52:14 2018

views: allow MenuDelegate implementations to override menu text colors

This change:
1) Renames MenuDelegate::GetLabelFontList to MenuDelegate::GetLabelStyle;
2) Removes MenuDelegate::GetShouldUseNormalForegroundColor() in favor of
   the MenuDelegate supplying its own foreground color;
3) Removes the "emphasized" notion from MenuItemView, since it was only used
   in one place (AppMenu) to achieve the behavior of having a disabled item
   paint as an enabled item;

This leads into a cleanup of MenuItemView::GetTextColor() to use
TypographyProvider to retrieve all colors.

Bug: 865318
Change-Id: Ie6238cfd5c9baac7be595809560485c23b804a08
Reviewed-on: https://chromium-review.googlesource.com/1186702
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586343}
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/chrome/browser/ui/views/profiles/dice_accounts_menu.cc
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/chrome/browser/ui/views/profiles/dice_accounts_menu.h
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/chrome/browser/ui/views/toolbar/app_menu.h
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/ui/views/controls/menu/menu_delegate.cc
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/ui/views/controls/menu/menu_delegate.h
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/ui/views/controls/menu/menu_item_view.h
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/ui/views/controls/menu/menu_model_adapter.cc
[modify] https://crrev.com/7ec662f59629f0386eaffd62da0bba450b3a28a3/ui/views/controls/menu/menu_model_adapter.h

@Elly Fong-Jones: As we are not very sure about the test steps to be performed in order to check and confirm the issue. Could you please provide a sample test file(...if any) which helps us in verifying the fix.

Thanks!

#9: A fix is not landed yet - that CL is preliminary work. No need to test right now.

***UI Mass Triage ***

In 72.0.3624.2, I'm seeing the menu text color slightly lighter than GG900 (#202124) by default, and then on hover, the highlight shifts the text color to black. Two questions:

I presume that having the hover state not affect the text isn't an easy task, but can  we ensure the default text color is GG900?

Deleted: Screen Shot 2018-11-28 at 9.35.37 PM.png 210 KB

	Screen Shot 2018-11-28 at 9.35.37 PM.png 210 KB View Download

I had an inflight CL for this but I dropped it to work on higher-priority stuff. I'm going to kick this over to the Views team for triage there.

Mac triage: assigning directly to robliao@ for Views triage