New issue
Advanced search Search tips

Issue 865309 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Mac: Spike in crashes under ExtensionPopup::ShowPopup around 69.0.3451.0

Project Member Reported by tapted@chromium.org, Jul 19

Issue description

Chrome Version       : 69.0.3451.0

These are bucketing into Issue 819520, but this looks mac-specific, and quite crashy for a Canary milestone.

https://crash.corp.google.com/browse?q=EXISTS+%28SELECT+1+FROM+UNNEST%28CrashedStackTrace.StackFrame%29+WHERE+FunctionName%3D%27ExtensionPopup%3A%3AExtensionPopup%28extensions%3A%3AExtensionViewHost*%2C+views%3A%3AView*%2C+views%3A%3ABubbleBorder%3A%3AArrow%2C+ExtensionPopup%3A%3AShowAction%29%27%29+AND+product_name%3D%27Chrome_Mac%27#samplereports,-productname:1000,productversion:100,-magicsignature:50,-magicsignature2:50,-stablesignature:50,-magicsignaturesorted:50



0x000000010bba6e7c	(Google Chrome Framework -view.cc:198 )	views::View::AddChildViewAt(views::View*, int)
0x000000010cbee7ab	(Google Chrome Framework -extension_popup.cc:54 )	ExtensionPopup::ExtensionPopup(extensions::ExtensionViewHost*, views::View*, views::BubbleBorder::Arrow, ExtensionPopup::ShowAction)
0x000000010cbef231	(Google Chrome Framework -extension_popup.cc:50 )	ExtensionPopup::ShowPopup(std::__1::unique_ptr<extensions::ExtensionViewHost, std::__1::default_delete<extensions::ExtensionViewHost> >, views::View*, views::BubbleBorder::Arrow, ExtensionPopup::ShowAction)
0x000000010cbf2a55	(Google Chrome Framework + 0x048d5a55 )	ExtensionActionPlatformDelegateViews::ShowPopup(std::__1::unique_ptr<extensions::ExtensionViewHost, std::__1::default_delete<extensions::ExtensionViewHost> >, bool, ExtensionActionViewController::PopupShowAction)
0x000000010cbe9c2a	(Google Chrome Framework + 0x048ccc2a )	ExtensionActionViewController::TriggerPopupWithUrl(ExtensionActionViewController::PopupShowAction, GURL const&, bool)
0x000000010cbe9aa1	(Google Chrome Framework + 0x048ccaa1 )	ExtensionActionViewController::ExecuteAction(ExtensionActionViewController::PopupShowAction, bool)
0x000000010bb5995e	(Google Chrome Framework -menu_button.cc:129 )	views::MenuButton::Activate(ui::Event const*)
0x000000010bb59d24	(Google Chrome Framework -menu_button.cc:206 )	views::MenuButton::OnMouseReleased(ui::MouseEvent const&)
0x000000010bb37378	(Google Chrome Framework -ink_drop_host_view.cc:276 )	views::InkDropHostView::OnMouseEvent(ui::MouseEvent*)
0x000000010adddc71	(Google Chrome Framework -scoped_target_handler.cc:32 )	ui::ScopedTargetHandler::OnEvent(ui::Event*)
0x000000010addba83	(Google Chrome Framework -event_dispatcher.cc:191 )	ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*)
0x000000010addb8bd	(Google Chrome Framework -event_dispatcher.cc:86 )	ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*)
0x000000010bbb5eec	(Google Chrome Framework -root_view.cc:445 )	views::internal::RootView::OnMouseReleased(ui::MouseEvent const&)
0x000000010bbbb3c5	(Google Chrome Framework -widget.cc:1232 )	views::Widget::OnMouseEvent(ui::MouseEvent*)
0x000000010bb45af5	(Google Chrome Framework -bridged_content_view.mm:617 )	-[BridgedContentView mouseEvent:]
0x000000010bb4c651	(Google Chrome Framework -cocoa_mouse_capture.mm:89 )	___ZN5views17CocoaMouseCapture14ActiveEventTap4InitEv_block_invoke
0x00007fff53b16365	(AppKit + 0x001ac365 )	_NSSendEventToObservers
0x00007fff5413f529	(AppKit + 0x007d5529 )	-[NSApplication(NSEvent) sendEvent:]
0x0000000109ffc36b	(Google Chrome Framework -chrome_browser_application_mac.mm:328 )	__34-[BrowserCrApplication sendEvent:]_block_invoke
0x000000010a3bae99	(Google Chrome Framework + 0x0209de99 )	base::mac::CallWithEHFrame(void () block_pointer)
0x0000000109ffc017	(Google Chrome Framework -chrome_browser_application_mac.mm:311 )	-[BrowserCrApplication sendEvent:]
0x00007fff539a0d9c	(AppKit + 0x00036d9c )	-[NSApplication run]

69.0.3491.0	5.13%	2
69.0.3486.0	5.13%	2
69.0.3482.0	7.69%	3
69.0.3480.0	2.56%	1
69.0.3479.0	2.56%	1
69.0.3472.3	28.21%	11
69.0.3472.0	5.13%	2
69.0.3469.2	2.56%	1
69.0.3466.0	5.13%	2
69.0.3464.2	5.13%	2
69.0.3451.0	2.56%	1
68.0.3440.42	20.51%	8
67.0.3396.99	5.13%	2
67.0.3396.30	2.56%	1
 
Cc: weili@chromium.org
Labels: -OS-Linux
r549561 was 67.0.3394 which fits
Cc: -weili@chromium.org ellyjo...@chromium.org
Labels: -Pri-1 Pri-2
Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
There are total 40 crashes. I can confirm that 38 of them have either SecondaryUiMd or ShowAllDialogsWithViewsToolkit disabled. In such cases, the extension popup will be Cocoa based, so treating it as views led to trouble.

Since all these flags are enabled by default already, and we no longer support MacViews browser with Cocoa secondary ui, I think it should be ok to downgrade it to p2 or even p3. I will continue monitor these crashes though. thanks.
Status: WontFix (was: Assigned)
Since we no longer support disabling views based secondary ui, will not fix this. In the future cleanup, we should remove those flags though.

Sign in to add a comment