New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865304 link

Starred by 1 user
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Jul 23
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Build-Toolchain

Blocking:
issue 834385



Sign in to add a comment

rootdev: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, Jul 19 
with glibc 2.27
emerge-samus rootdev

rootdev.c:84:11: error: implicit declaration of function 'makedev' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    dev = makedev(major_num, minor_num);
          ^
This is due to the following change in glibc:

* The inclusion of <sys/sysmacros.h> by <sys/types.h> is deprecated.  This
  means that in a future release, the macros “major”, “minor”, and “makedev”
  will only be available from <sys/sysmacros.h>.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/rootdev/+/8dc336a991e5494e6cc9a0094778fee67f22ed6c

commit 8dc336a991e5494e6cc9a0094778fee67f22ed6c
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Jul 20 12:31:38 2018

rootdev: include missing header file.

This adds <sys/sysmacros.h> because the
inclusion of <sys/sysmacros.h> by <sys/types.h> is deprecated since
glibc 2.25.

BUG= chromium:865304 
TEST=emerge-samus rootdev with glibc 2.27

Change-Id: Ic54e089659d620a862720b9882235117eb8487b5
Reviewed-on: https://chromium-review.googlesource.com/1143004
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8dc336a991e5494e6cc9a0094778fee67f22ed6c/rootdev.c
[modify] https://crrev.com/8dc336a991e5494e6cc9a0094778fee67f22ed6c/main.c

Comment 2 by yunlian@chromium.org, Jul 23

Status: Verified (was: Untriaged)
►

Sign in to add a comment