New issue
Advanced search Search tips

Issue 865292 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Longer URLs in Save passwords are truncated.

Project Member Reported by vbarig...@chromium.org, Jul 19

Issue description

App Version: 69.0.3495.0 canary
iOS Version: 12 beta 3, 11.4.1
Device: iPhones
URL: https://password-manager-test-forms.appspot.com/

Precondition:
Save a password in chrome using the above URL.

Steps to reproduce:
  1.  Launch chrome.
  2.  Go to Menu --> Passwords --> Tap on the Save password on the above URL

Observed results:
Notice that the long url is truncated.

Expected results:
URL should be visible fully.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M67
Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M68

Link to video/image: https://drive.google.com/file/d/1QMPKomUGadeCY6L3ZpSKR8oiDyE1ysc2/view

 
Labels: q4
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)
Definitely a P2
Labels: -Pri-2 -q4 -MS-Settings M-70 Pri-1
This feels like a constraints issue.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6567e305dace61fd4d48fb7f7ad23f81250faa30

commit 6567e305dace61fd4d48fb7f7ad23f81250faa30
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Aug 08 23:10:37 2018

[ios] Use a variable cell height for the password details URL.

BUG= 865292 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia654723c1fa870921658fa2d53bc77114627fcd2
Reviewed-on: https://chromium-review.googlesource.com/1167112
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581722}
[modify] https://crrev.com/6567e305dace61fd4d48fb7f7ad23f81250faa30/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on chrome canary version 70.0.3521.0 on iPhone X and iPhone 8 plus with iOS 11.4.1, following the steps mentioned in comment #0.  Long URLs are not truncated.  Looks good.

Sign in to add a comment