New issue
Advanced search Search tips

Issue 865272 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: false

Project Member Reported by ClusterFuzz, Jul 19

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5211831761895424

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  false
  CPDF_CrossRefTable::AddNormal
  CPDF_Parser::LoadCrossRefV5
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=576000:576006

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5211831761895424

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 19

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 19

Cc: thestig@chromium.org art-sn...@yandex-team.ru
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Do not add invalid objects to the cross reference table. by thestig@chromium.org - https://pdfium.googlesource.com/pdfium/+/30688fb1c434b141380aa224da12e8246a8a78e1

Use CPDF_CrossRefTable within CPDF_Parser by art-snake@yandex-team.ru - https://pdfium.googlesource.com/pdfium/+/084c31d93439d5166c60dbfb0ccee6db1406d09c

Make CPDF_Parser::GetTrailer const method. by art-snake@yandex-team.ru - https://pdfium.googlesource.com/pdfium/+/a18536af5b32b63f795d8b5812a4303c7ee6ea97

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Lei, can you take a look at this?
Status: Started (was: Assigned)
Yes. https://pdfium-review.googlesource.com/39438
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/f3a3393a2f96bb8c4cc275ee67921e2b7bddf540

commit f3a3393a2f96bb8c4cc275ee67921e2b7bddf540
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Aug 06 18:25:03 2018

Avoid invalid object numbers in CPDF_Parser::LoadCrossRefV5().

BUG= chromium:865272 

Change-Id: I4606bdfd78ebd6553c36b985b4f49d07b579ac40
Reviewed-on: https://pdfium-review.googlesource.com/39438
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Art Snake <art-snake@yandex-team.ru>

[modify] https://crrev.com/f3a3393a2f96bb8c4cc275ee67921e2b7bddf540/core/fpdfapi/parser/cpdf_parser.cpp

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bcd41ba7ab4142b74b4d95a4417c78161774d93

commit 2bcd41ba7ab4142b74b4d95a4417c78161774d93
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 06 20:03:29 2018

Roll src/third_party/pdfium a7a957f7cec2..f3a3393a2f96 (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/a7a957f7cec2..f3a3393a2f96


git log a7a957f7cec2..f3a3393a2f96 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 thestig@chromium.org Avoid invalid object numbers in CPDF_Parser::LoadCrossRefV5().
2018-08-06 tsepez@chromium.org Small optimization in CJBig2_Image::SubImage()
2018-08-06 thestig@chromium.org Check for null object type in CPDF_Parser::LoadCrossRefV5().
2018-08-06 thestig@chromium.org Do more CPDF_Parser::LoadCrossRefV5() cleanup.
2018-08-06 rharrison@chromium.org Clean up a nit that was identified after CQing an earlier CL


Created with:
  gclient setdep -r src/third_party/pdfium@f3a3393a2f96

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:865272 , chromium:871042 , chromium:863098 
TBR=dsinclair@chromium.org

Change-Id: I244334140b9abd5f018f052799d278320c51e5fc
Reviewed-on: https://chromium-review.googlesource.com/1163845
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580959}
[modify] https://crrev.com/2bcd41ba7ab4142b74b4d95a4417c78161774d93/DEPS

Project Member

Comment 8 by ClusterFuzz, Aug 7

ClusterFuzz has detected this issue as fixed in range 580951:581109.

Detailed report: https://clusterfuzz.com/testcase?key=5211831761895424

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  false
  CPDF_CrossRefTable::AddNormal
  CPDF_Parser::LoadCrossRefV5
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=576000:576006
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=580951:581109

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5211831761895424

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Aug 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5211831761895424 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment