No Linux apps (Terminal, etc) launch anymore |
|||||||||
Issue descriptionChrome version: 69.0.3473.0 (Official Build) dev (64-bit) OS: Chrome Repro steps: 1. Click on the "Terminal" icon in my launcher. Expected: Terminal app to launch. Actual: It just spins, but never launches. I installed Visual Studio Code as well (through apt-get) and that doesn't load either. Same if I browse to "Linux Files" in my file browser. Everything looks like it's loading, but never gets anywhere. Even if I leave in the loading state for a couple hours.
,
Jul 19
My penguin is back. I'm a happy camper.
,
Jul 20
Dupe of issue 863615 ? I think I found the race though. In garcon: https://chromium.googlesource.com/chromiumos/platform2/+/master/vm_tools/garcon/main.cc#175 HostNotifier::Create will notify cicerone over gRPC that garcon is ready before the gRPC server is started. That wasn't an issue before, but now we do some PackageKit proxy setup in between notifying the host and starting the gRPC server. This gives the host time to notify Chrome of container startup, and for Chrome to fire off a D-Bus call (LaunchContainerApplication or LaunchVshd) back to cicerone, which then fails since garcon isn't ready yet.
,
Jul 20
Fix at https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1145777
,
Jul 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/810af32ea3322a77c8901eefea37378518a7502a commit 810af32ea3322a77c8901eefea37378518a7502a Author: Stephen Barber <smbarber@chromium.org> Date: Sat Jul 21 20:19:00 2018 vm_tools: garcon: fix startup host_notifier race garcon must not notify the host until its gRPC server is listening. BUG= chromium:865246 TEST=garcon still starts up; Linux apps starts reliably Change-Id: I0e6eb656faa55eb270b6d89a2688750ab76dcd49 Reviewed-on: https://chromium-review.googlesource.com/1145777 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> [modify] https://crrev.com/810af32ea3322a77c8901eefea37378518a7502a/vm_tools/garcon/host_notifier.cc [modify] https://crrev.com/810af32ea3322a77c8901eefea37378518a7502a/vm_tools/garcon/main.cc [modify] https://crrev.com/810af32ea3322a77c8901eefea37378518a7502a/vm_tools/garcon/host_notifier.h
,
Jul 21
This will need a component push.
,
Jul 24
,
Jul 24
Issue 864274 has been merged into this issue.
,
Jul 25
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149 commit f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149 Author: Stephen Barber <smbarber@chromium.org> Date: Wed Jul 25 03:27:55 2018 vm_tools: garcon: fix startup host_notifier race garcon must not notify the host until its gRPC server is listening. BUG= chromium:865246 TEST=garcon still starts up; Linux apps starts reliably Change-Id: I0e6eb656faa55eb270b6d89a2688750ab76dcd49 Reviewed-on: https://chromium-review.googlesource.com/1145777 Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com> (cherry picked from commit 810af32ea3322a77c8901eefea37378518a7502a) Reviewed-on: https://chromium-review.googlesource.com/1149560 Commit-Queue: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149/vm_tools/garcon/host_notifier.cc [modify] https://crrev.com/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149/vm_tools/garcon/main.cc [modify] https://crrev.com/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149/vm_tools/garcon/host_notifier.h
,
Jul 26
Verified on eve 10888.0.0, cros-termina 10895.4.0. The new component version is now live.
,
Jul 30
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tbuck...@chromium.org
, Jul 19Owner: jkardatzke@chromium.org
Status: Assigned (was: Untriaged)