New issue
Advanced search Search tips

Issue 865246 link

Starred by 19 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

No Linux apps (Terminal, etc) launch anymore

Project Member Reported by ddanchenko@google.com, Jul 19

Issue description

Chrome version: 69.0.3473.0 (Official Build) dev (64-bit)
OS: Chrome

Repro steps:
1. Click on the "Terminal" icon in my launcher.  

Expected: Terminal app to launch.
Actual: It just spins, but never launches.

I installed Visual Studio Code as well (through apt-get) and that doesn't load either. Same if I browse to "Linux Files" in my file browser. Everything looks like it's loading, but never gets anywhere. Even if I leave in the loading state for a couple hours.

 
Cc: dgreid@chromium.org nverne@chromium.org
Owner: jkardatzke@chromium.org
Status: Assigned (was: Untriaged)
I am also seeing this on latest dev
Chrome version: 69.0.3473.0
OS version: 10820.0.0
Termina version: 10869.0.0

From crosh, it looks like termina/penguin have both been started. However, clicking the Terminal or other app icons just hangs.

I don't seem to be seeing this on canary, so might be fixed.
My penguin is back. I'm a happy camper.
Dupe of  issue 863615 ?

I think I found the race though.
In garcon: https://chromium.googlesource.com/chromiumos/platform2/+/master/vm_tools/garcon/main.cc#175

HostNotifier::Create will notify cicerone over gRPC that garcon is ready before the gRPC server is started. That wasn't an issue before, but now we do some PackageKit proxy setup in between notifying the host and starting the gRPC server. This gives the host time to notify Chrome of container startup, and for Chrome to fire off a D-Bus call (LaunchContainerApplication or LaunchVshd) back to cicerone, which then fails since garcon isn't ready yet.
Cc: jkardatzke@chromium.org
Components: OS>Systems>Containers
Labels: -Pri-2 M-69 Pri-1
Owner: smbar...@chromium.org
Status: Started (was: Assigned)
Fix at https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1145777
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/810af32ea3322a77c8901eefea37378518a7502a

commit 810af32ea3322a77c8901eefea37378518a7502a
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Jul 21 20:19:00 2018

vm_tools: garcon: fix startup host_notifier race

garcon must not notify the host until its gRPC server
is listening.

BUG= chromium:865246 
TEST=garcon still starts up; Linux apps starts reliably

Change-Id: I0e6eb656faa55eb270b6d89a2688750ab76dcd49
Reviewed-on: https://chromium-review.googlesource.com/1145777
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>

[modify] https://crrev.com/810af32ea3322a77c8901eefea37378518a7502a/vm_tools/garcon/host_notifier.cc
[modify] https://crrev.com/810af32ea3322a77c8901eefea37378518a7502a/vm_tools/garcon/main.cc
[modify] https://crrev.com/810af32ea3322a77c8901eefea37378518a7502a/vm_tools/garcon/host_notifier.h

Status: Fixed (was: Started)
This will need a component push.
Labels: Merge-Request-69
Cc: tbuck...@chromium.org rohi...@chromium.org timloh@chromium.org
 Issue 864274  has been merged into this issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 25

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 25

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149

commit f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149
Author: Stephen Barber <smbarber@chromium.org>
Date: Wed Jul 25 03:27:55 2018

vm_tools: garcon: fix startup host_notifier race

garcon must not notify the host until its gRPC server
is listening.

BUG= chromium:865246 
TEST=garcon still starts up; Linux apps starts reliably

Change-Id: I0e6eb656faa55eb270b6d89a2688750ab76dcd49
Reviewed-on: https://chromium-review.googlesource.com/1145777
Commit-Ready: Jeffrey Kardatzke <jkardatzke@google.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
(cherry picked from commit 810af32ea3322a77c8901eefea37378518a7502a)
Reviewed-on: https://chromium-review.googlesource.com/1149560
Commit-Queue: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149/vm_tools/garcon/host_notifier.cc
[modify] https://crrev.com/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149/vm_tools/garcon/main.cc
[modify] https://crrev.com/f4f6e726c6d37f7fb4d28a38dc565ab6a9c32149/vm_tools/garcon/host_notifier.h

Status: Verified (was: Fixed)
Verified on eve 10888.0.0, cros-termina 10895.4.0. The new component version is now live.
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 30

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-69

Sign in to add a comment