Since we don't scale non-fallback favicons for dynamic type (do we?), it seems like we shouldn't be scaling the fallback monograms either. Right?

That seems to be a cleaner fix than juggling the layout.

Leaving at P1 for now.

I agree with marq that if non-fallback icons' dimensions do not change, neither should the fallback icons'. I think the font size of the monogram inside the shaded background should be fixed and not scale with the user's dynamic font size choice.

You can think about the user who chose to have a tiny font size. The monogram should be sized to fit the box, not scaled down to be tiny.

Also, I don't think this is P1.

Sounds good, I'll just fix the fallback monogram to the 12pt font that Pete wanted.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deca07eb64f08ef254995178b73471b3641c34b0

commit deca07eb64f08ef254995178b73471b3641c34b0
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Thu Jul 19 23:15:13 2018

[ios] Fix Collections Fallback monograms to 12pt bold font

Since Favicons can't be scaled at the moment, we should keep the fallback monogram fixed as well.

Screenshot: https://drive.google.com/open?id=1WRrarQl8AOqjL3I_6B2mEXfR73DoBnSk

Bug:  865226 

Change-Id: Ia507dc052937101df18b4676f2106c8a89622609
Reviewed-on: https://chromium-review.googlesource.com/1143713
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576683}
[modify] https://crrev.com/deca07eb64f08ef254995178b73471b3641c34b0/ios/chrome/common/favicon/favicon_view.mm

I think M-69 was branched by the time this CL landed, I'd like to cherrypick this since its pretty noticeable, the fix is safe enough, and we just branched.

Changing back to started until we decide if we'll cherrypick or not.

This bug requires manual review: We don't branch M69 until 2018-07-19.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Changing back to fixed, because it needs to be mark as Fixed in order to be consider for cherrypicking

This is bug is P2. We are prioritizing P1, Proj-UIRefresh bugs since there will be lots of merges this milestone.

+Marq@ to decide if this should make M69.

We are currently prioritizing P1, Proj-UIRefresh, M-69 bugs. See Marq@'s email with subject "Bijou bug priorities." For this reason I am rejecting this merge. Let me know if I missed something here.