New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865225 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jul 19
Cc:
chanli@chromium.org
█ diegomtzg@google.com
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Initial Pylint analyzer has more warnings than intended

Project Member Reported by qyears...@chromium.org, Jul 18 
Example:

https://chromium-review.googlesource.com/c/infra/infra/+/1141333/3

 - Import error warnings don't work right since we only run pylint
   on the files in the change.
 - Function/method names that match the Chromium style guide (https://www.chromium.org/chromium-os/python-style-guidelines) are flagged, but they shouldn't be.

Feel free to note any other warnings that should be disabled for the initial version here.

Later on, we'll of course want projects to be able to enable more warnings ( bug 864685 ).
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/70e5d70a35d081cbd3671c82e213b6e7ae37c59b

commit 70e5d70a35d081cbd3671c82e213b6e7ae37c59b
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jul 19 21:21:08 2018

[tricium pylint] Disable more warnings in bundled pylintrc

Bug:  865225 
Change-Id: I92007de1420f8cf8197cb1d5117b87868d4460c1
Reviewed-on: https://chromium-review.googlesource.com/1143716
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/70e5d70a35d081cbd3671c82e213b6e7ae37c59b/go/src/infra/tricium/functions/pylint/pylintrc

Comment 2 by qyears...@chromium.org, Jul 19

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
Deployed new version, although we may still want to tweak later.

Pointed out in the code review above: a version of pylint analyzer that does a full checkout would be able to handle checking imports etc.
►

Sign in to add a comment