New issue
Advanced search Search tips

Issue 865219 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 865217

Blocking:
issue 881490



Sign in to add a comment

Rebase CUPS patches to 2.2.8

Project Member Reported by skau@chromium.org, Jul 18

Issue description

Uprev CUPS from 2.1.4 to 2.2.8 since 2.3 isn't stable yet.  This will require rebasing our patches on 2.2.8.
 
Blocking: 865217
Blockedon: 865217
Blocking: -865217
Owner: valleau@chromium.org
Status: Assigned (was: Available)
Blocking: 881490
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f442d0cfd779b0459c869ea8edbde01bd4b63eb1

commit f442d0cfd779b0459c869ea8edbde01bd4b63eb1
Author: David Valleau <valleau@chromium.org>
Date: Tue Sep 11 00:17:43 2018

Removing documention from CUPS ebuild

These particular documentation files to be installed no longer exist
in v2.2.8, and we don't really need to install documention for CUPS
anyways so this change removes them entirely.

BUG= chromium:865219 
TEST=Able to successfully emerge

Change-Id: I7f93ab02cd77b3cad45abc97daf5880639e74de7
Reviewed-on: https://chromium-review.googlesource.com/1213408
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/f442d0cfd779b0459c869ea8edbde01bd4b63eb1/net-print/cups/cups-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/e787a2fa32bf4166805b153513b5caf44ddfc0fe

commit e787a2fa32bf4166805b153513b5caf44ddfc0fe
Author: David Valleau <valleau@chromium.org>
Date: Wed Sep 19 00:54:57 2018

Changing manifest to point to the cups-2-2-8 branch

BUG= chromium:865219 
TEST=None
CQ-DEPEND=CL:1191985

Change-Id: I4966183f659c0bfab8f34c97c04d46a54b34a489
Reviewed-on: https://chromium-review.googlesource.com/1192229
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/e787a2fa32bf4166805b153513b5caf44ddfc0fe/full.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/e7915d2dd4577501fe9a04da339bff7ce3101632

commit e7915d2dd4577501fe9a04da339bff7ce3101632
Author: David Valleau <valleau@google.com>
Date: Wed Sep 19 00:54:58 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/18135db6c840f504f8ee08264b9b751d9077ed10

commit 18135db6c840f504f8ee08264b9b751d9077ed10
Author: Bernie Thompson <bhthompson@google.com>
Date: Wed Sep 19 16:17:33 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/724e0bb2edc7866ff59044018d98d009719227ae

commit 724e0bb2edc7866ff59044018d98d009719227ae
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Wed Sep 19 16:17:07 2018

Revert "Changing manifest to point to the cups-2-2-8 branch"

This reverts commit e787a2fa32bf4166805b153513b5caf44ddfc0fe.

Reason for revert: Chrome build is broken. https://bugs.chromium.org/p/chromium/issues/detail?id=886932

Original change's description:
> Changing manifest to point to the cups-2-2-8 branch
> 
> BUG= chromium:865219 
> TEST=None
> CQ-DEPEND=CL:1191985
> 
> Change-Id: I4966183f659c0bfab8f34c97c04d46a54b34a489
> Reviewed-on: https://chromium-review.googlesource.com/1192229
> Commit-Ready: David Valleau <valleau@chromium.org>
> Tested-by: David Valleau <valleau@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>

Bug:  chromium:865219 
Change-Id: I2cab85a0cbe2d63209478a9d07e6207fe0620cbb
Reviewed-on: https://chromium-review.googlesource.com/1234273
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/724e0bb2edc7866ff59044018d98d009719227ae/full.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/59a6fdbafb03c5bf238a1103ab7b87294de6b19a

commit 59a6fdbafb03c5bf238a1103ab7b87294de6b19a
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Wed Sep 19 16:17:22 2018

Revert "Updating the ebuild and seccomp policies to work with cups v2.2.8"

This reverts commit 4b330781a00db1251d9a9947a8d418535ac5870a.

Reason for revert: Chrome build is broken. https://bugs.chromium.org/p/chromium/issues/detail?id=886932

Original change's description:
> Updating the ebuild and seccomp policies to work with cups v2.2.8
> 
> BUG= chromium:865219 
> TEST=Tested manually on device
> 
> Change-Id: I3207cf75c8242b8ca04dfe062030db174697698d
> Reviewed-on: https://chromium-review.googlesource.com/1191985
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: David Valleau <valleau@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>

Bug:  chromium:865219 
Change-Id: I44cff2ece9fd5e8636fdb626ca7277a54f29cd79
Reviewed-on: https://chromium-review.googlesource.com/1234293
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/59a6fdbafb03c5bf238a1103ab7b87294de6b19a/net-print/cups/files/cupsd-seccomp-x86.policy
[modify] https://crrev.com/59a6fdbafb03c5bf238a1103ab7b87294de6b19a/net-print/cups/files/cupsd-seccomp-arm64.policy
[modify] https://crrev.com/59a6fdbafb03c5bf238a1103ab7b87294de6b19a/net-print/cups/files/cupsd-seccomp-arm.policy
[modify] https://crrev.com/59a6fdbafb03c5bf238a1103ab7b87294de6b19a/net-print/cups/files/cupsd-seccomp-amd64.policy

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/91efb54e16fdeecc756b4455fc2a626db1808b13

commit 91efb54e16fdeecc756b4455fc2a626db1808b13
Author: David Valleau <valleau@chromium.org>
Date: Thu Oct 04 07:37:19 2018

Reland "Updating the ebuild and seccomp policies to work with cups v2.2.8"

This is a reland of 4b330781a00db1251d9a9947a8d418535ac5870a

Original change's description:
> Updating the ebuild and seccomp policies to work with cups v2.2.8
>
> BUG= chromium:865219 
> TEST=Tested manually on device
>
> Change-Id: I3207cf75c8242b8ca04dfe062030db174697698d
> Reviewed-on: https://chromium-review.googlesource.com/1191985
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: David Valleau <valleau@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>

Bug:  chromium:865219 
Change-Id: I055372bc87f9e646b15098b9fe38fb110c966dea
Reviewed-on: https://chromium-review.googlesource.com/1260017
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/91efb54e16fdeecc756b4455fc2a626db1808b13/net-print/cups/files/cupsd-seccomp-x86.policy
[modify] https://crrev.com/91efb54e16fdeecc756b4455fc2a626db1808b13/net-print/cups/files/cupsd-seccomp-arm64.policy
[modify] https://crrev.com/91efb54e16fdeecc756b4455fc2a626db1808b13/net-print/cups/files/cupsd-seccomp-arm.policy
[modify] https://crrev.com/91efb54e16fdeecc756b4455fc2a626db1808b13/net-print/cups/files/cupsd-seccomp-amd64.policy

Labels: M-72
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ce80aa9e8916a9946bfaad1a3cd1521066719bbe

commit ce80aa9e8916a9946bfaad1a3cd1521066719bbe
Author: David Valleau <valleau@chromium.org>
Date: Thu Nov 08 00:06:28 2018

Temporarily disabling addPrinter test to land cups update

BUG= chromium:865219 
TEST=None

Change-Id: I7f51e4f24b2729ebfbceb64feed25eb8bc3da752
Reviewed-on: https://chromium-review.googlesource.com/c/1324430
Tested-by: David Valleau <valleau@chromium.org>
Trybot-Ready: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/ce80aa9e8916a9946bfaad1a3cd1521066719bbe/client/site_tests/platform_AddPrinter/control.generic

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/6a3750430811f8e72d59f671f328968e209a0551

commit 6a3750430811f8e72d59f671f328968e209a0551
Author: David Valleau <valleau@google.com>
Date: Fri Nov 09 15:19:43 2018

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/324686ffd63c9186baf8e665fcf0ee64efdd5314

commit 324686ffd63c9186baf8e665fcf0ee64efdd5314
Author: David Valleau <valleau@chromium.org>
Date: Fri Nov 09 15:19:44 2018

Changing manifest to point to the cups-2-2-8 branch

BUG= chromium:865219 
TEST=None
CQ-DEPEND=CL:*712352

Change-Id: Idf06c08cec8bf0211d3895b7fd9f1b556ade83a2
Reviewed-on: https://chromium-review.googlesource.com/1323477
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/324686ffd63c9186baf8e665fcf0ee64efdd5314/full.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/665072f77386511e242b44a23c8b9f50091fa282

commit 665072f77386511e242b44a23c8b9f50091fa282
Author: Sean Kau <skau@chromium.org>
Date: Thu Nov 15 10:17:04 2018

platform_AddPrinter: Update generic for CUPS 2.2.8

CUPS 2.2.8 no longer embeds document name and username
in generated PostScript.  Update the golden file appropriately.

BUG= chromium:865219 
TEST=test_that ... platform_AddPrinter.generic with CUPS 2.2.8
patched.

Change-Id: I1535239a5ec5f37e987bb12ab9efcc7997d93f34
Reviewed-on: https://chromium-review.googlesource.com/1278357
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: David Valleau <valleau@chromium.org>

[modify] https://crrev.com/665072f77386511e242b44a23c8b9f50091fa282/client/site_tests/platform_AddPrinter/golden_printing_request_generic.bin

Status: Fixed (was: Assigned)
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cd6d13c768e5b782101690e922c7feaa78e86597

commit cd6d13c768e5b782101690e922c7feaa78e86597
Author: Sean Kau <skau@chromium.org>
Date: Thu Nov 22 06:49:20 2018

platform_AddPrinter: Add generic test back to bvt-cq.

Test was removed from CQ so that CUPS uprev could land.
Test is updated for the 2.2.8 uprev and can be added
back to the CQ.

CQ-DEPEND=CL:1278357
BUG= chromium:865219 
TEST=Verify that platform_AddPrinter.generic is passing

Change-Id: I5c049baff59a0dd9d22dca0220f8bdd8f688c3e3
Reviewed-on: https://chromium-review.googlesource.com/1330851
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/cd6d13c768e5b782101690e922c7feaa78e86597/client/site_tests/platform_AddPrinter/control.generic

Sign in to add a comment