New issue
Advanced search Search tips

Issue 865217 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocking:
issue 865219



Sign in to add a comment

Change CUPS repository to a cros_workon directory

Project Member Reported by skau@chromium.org, Jul 18

Issue description

We carry a lot of patches to CUPS as we differ from upstream needs in some significant ways.  We now maintain a fork at chromiumos/third_party/cups.  Modify the ebuild to use our forked repository.
 
Blockedon: 865219
Blocking: 865219
Blockedon: -865219
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/e088b132e3191ac9ad2b99e025b8205e80ebe079

commit e088b132e3191ac9ad2b99e025b8205e80ebe079
Author: David Valleau <valleau@chromium.org>
Date: Fri Jul 20 16:57:40 2018

Applying cups-1.4.4-nostrip.patch

BUG= chromium:865217 
TEST=None

Change-Id: I0bb948e4a25ff79a91205c7ab7f30d0861e7f1d0

[modify] https://crrev.com/e088b132e3191ac9ad2b99e025b8205e80ebe079/config-scripts/cups-compiler.m4

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/d3fc088eb32ba0a4c10ca6c5ffa9bac07fc7ea74

commit d3fc088eb32ba0a4c10ca6c5ffa9bac07fc7ea74
Author: David Valleau <valleau@chromium.org>
Date: Fri Jul 20 16:59:28 2018

Applying cups-1.6.0-dont-compress-manpages.patch

Prevents compression of manpages.

BUG= chromium:865217 
TEST=None

Change-Id: Ifc6511f5974599b240102dff65bbbb53b2683fe4

[modify] https://crrev.com/d3fc088eb32ba0a4c10ca6c5ffa9bac07fc7ea74/config-scripts/cups-manpages.m4

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/541e386edfc5cd30fda06b5c121cec4a415bab3f

commit 541e386edfc5cd30fda06b5c121cec4a415bab3f
Author: David Valleau <valleau@chromium.org>
Date: Fri Jul 20 17:17:07 2018

Applying cups-1.6.0-fix-install-perms.patch

BUG= chromium:865217 
TEST=None

Change-Id: Ib62c78d168124caffebdeae3adcf49e65d53c601

[modify] https://crrev.com/541e386edfc5cd30fda06b5c121cec4a415bab3f/Makedefs.in

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/cbb0f5461418bed1f7b7fe901bf496e92e82ec4f

commit cbb0f5461418bed1f7b7fe901bf496e92e82ec4f
Author: David Valleau <valleau@chromium.org>
Date: Fri Jul 20 17:56:44 2018

Applying cups-2.0.1-xinetd-installation-fix.patch

BUG= chromium:865217 
TEST=None

Change-Id: I9a475d6a036c91797bda3397c255d7482d6b536e

[modify] https://crrev.com/cbb0f5461418bed1f7b7fe901bf496e92e82ec4f/scheduler/Makefile

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/fcce77fefa4f4907aab8583713565e7d01a536b5

commit fcce77fefa4f4907aab8583713565e7d01a536b5
Author: David Valleau <valleau@chromium.org>
Date: Fri Jul 20 18:08:42 2018

Applying cups-2.0.2-rename-systemd-service-files.patch

BUG= chromium:865217 
TEST=None

Change-Id: I27a03223116300c7c30c01d8d3d3852b409a2f63

[modify] https://crrev.com/fcce77fefa4f4907aab8583713565e7d01a536b5/scheduler/Makefile
[modify] https://crrev.com/fcce77fefa4f4907aab8583713565e7d01a536b5/scheduler/org.cups.cupsd.service.in

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/ac1f3a06f5449e4bd63c5659339bb8f1dc6716ba

commit ac1f3a06f5449e4bd63c5659339bb8f1dc6716ba
Author: David Valleau <valleau@chromium.org>
Date: Mon Jul 23 17:30:52 2018

Applying cups-2.0.3-Add-printerroot-to-configure.patch

Add printerroot to configure script

BUG= chromium:865217 
TEST=None

Change-Id: If7aa027f043b1605dd1e36be963192a2c8455c9c

[modify] https://crrev.com/ac1f3a06f5449e4bd63c5659339bb8f1dc6716ba/config-scripts/cups-directories.m4

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/d713fdd53fe77751a252c125fa77ef10e9a8b2c2

commit d713fdd53fe77751a252c125fa77ef10e9a8b2c2
Author: David Valleau <valleau@chromium.org>
Date: Mon Jul 23 17:31:16 2018

Applying cups-2.0.3-cross-compile.patch

BUG= chromium:865217 
TEST=None

Change-Id: I5d2f9b7e11f64980ec637bafc26f66cce0020104

[modify] https://crrev.com/d713fdd53fe77751a252c125fa77ef10e9a8b2c2/man/Makefile
[modify] https://crrev.com/d713fdd53fe77751a252c125fa77ef10e9a8b2c2/ppdc/Makefile

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/e062fa86efa6f0ee4036569443e353d1fb211e90

commit e062fa86efa6f0ee4036569443e353d1fb211e90
Author: David Valleau <valleau@chromium.org>
Date: Mon Jul 23 17:34:34 2018

Applying cups-2.1.2-PrinterRoot.patch

cupsd writes out its printer data to
$ServerRoot/{printers.conf,ppd/*.ppd}, alongside less volatile data,
like cupsd.conf and cups-files.conf. Some systems might like to keep the
static config files (i.e., ServerRoot) protected in a read-only
partition, while placing the volatile printer info in a writeable partition.

BUG= chromium:865217 
TEST=None

Change-Id: I42f957a6a47d2e7edfd5bff8b6e981a95a3d67de

[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/client.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/cupsd.h
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/main.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/config.h.in
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/conf.h
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/systemv/lpstat.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/colorman.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/job.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/cups-config.in
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/cups/util.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/ipp.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/classes.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/printers.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/cups/globals.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/cups/cups-private.h
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/subscriptions.c
[modify] https://crrev.com/e062fa86efa6f0ee4036569443e353d1fb211e90/scheduler/conf.c

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/0fe20bb1296ed7bee5250400edc88a7d94ec54cd

commit 0fe20bb1296ed7bee5250400edc88a7d94ec54cd
Author: David Valleau <valleau@chromium.org>
Date: Mon Jul 23 21:12:49 2018

Applying cups-2.1.2-systemd-socket.patch

net-print/cups: copy from portage-stable

We need to modify this ebuild to run it in an unprivileged minijail.
Pulled from portage-stable's Change-Id
I275744f3661d31edff7b33dbeec90f6d17d34281.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/322835
Reviewed-by: Olof Johansson <olofj@chromium.org>

BUG= chromium:865217 
TEST=None

Change-Id: I925c8ab33e2159711b1c43a85e32e8c6df5dc629

[modify] https://crrev.com/0fe20bb1296ed7bee5250400edc88a7d94ec54cd/scheduler/main.c
[modify] https://crrev.com/0fe20bb1296ed7bee5250400edc88a7d94ec54cd/scheduler/org.cups.cupsd.path.in
[modify] https://crrev.com/0fe20bb1296ed7bee5250400edc88a7d94ec54cd/scheduler/org.cups.cupsd.service.in

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/63217cae77c2c30c4fea3325093f505d0dfe0a93

commit 63217cae77c2c30c4fea3325093f505d0dfe0a93
Author: David Valleau <valleau@chromium.org>
Date: Mon Jul 23 21:13:48 2018

Applying cups-2.1.4-strict-filters.patch

Makes cupstestppd extra strict, preventing filters from having '/' or
'.' in the name. This is to ensure that filters don't use an absolute
path or even relative path with '..' in it. Yes, it's extra strict,
b/c a filter name like 'myfilter.foo' would be stopped by this script,
but doesn't pose a problem. That said, we don't see that in practice.

From: Andrew de los Reyes <adlr@chromium.org>
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=633384

BUG= chromium:865217 
TEST=None

Change-Id: Ieabf6e1548c46356e4ec5f66669e31f1dbf99ddf

[modify] https://crrev.com/63217cae77c2c30c4fea3325093f505d0dfe0a93/systemv/cupstestppd.c

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/ec3695e6cc024a5daee36343aec87cbc74f9ec54

commit ec3695e6cc024a5daee36343aec87cbc74f9ec54
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 24 23:19:51 2018

Adding cups to the public manifest

BUG= chromium:865217 
TEST=None

Change-Id: Ib5fe38a88713b471ea8af2ccd84c2c600a156293
Reviewed-on: https://chromium-review.googlesource.com/1144320
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/ec3695e6cc024a5daee36343aec87cbc74f9ec54/full.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/e20fa706f2ec5ceca0fdc72c5fcf26cfac247746

commit e20fa706f2ec5ceca0fdc72c5fcf26cfac247746
Author: David Valleau <valleau@chromium.org>
Date: Mon Jul 23 21:16:50 2018

Applying cups-2.1.4-usb-device-uris.patch

cups: Change USB uri naming scheme to make it friendlier to chrome-matching.

This changes the cups USB uri naming to the form usb://VENDOR_ID/PRODUCT_ID[?serial=SERIAL

where VENDOR_ID and PRODUCT_ID are both 4-digit lowercase hex fields,
and serial is whatever is determined to be the (USB) serial number of
the printer. This intentionally avoids using any ieee1284 fields in
printer identification, since those fields are subject to fixups and
mangling in cups, so generating the same URI on the chrome side is
fragile.

Reviewed-on: https://chromium-review.googlesource.com/445998
Commit-Ready: Justin Carlson <justincarlson@chromium.org>
Tested-by: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

BUG= chromium:865217 
TEST=None

Change-Id: Ic8f21ffbb88cdf67afe95be2c068321ef8e2dbcc

[modify] https://crrev.com/e20fa706f2ec5ceca0fdc72c5fcf26cfac247746/backend/usb-libusb.c

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/e1e073ada6ad23af2d8c6cdd4287e28e08baceec

commit e1e073ada6ad23af2d8c6cdd4287e28e08baceec
Author: David Valleau <valleau@google.com>
Date: Thu Jul 26 02:45:31 2018

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/d2f806b39771e3664711d21c91890ca88b51ec8b

commit d2f806b39771e3664711d21c91890ca88b51ec8b
Author: David Valleau <valleau@chromium.org>
Date: Sat Jul 28 02:11:13 2018

Applying cups-2.1.4-non-standard-grays.patch

Add non-standard grays
From: Sean Kau <skau@chromium.org>
Date: Mon, 24 Apr 2017 18:51:19 -0700

BUG= chromium:865217 
TEST=None

Change-Id: Id160f536bd886bb2ce9a3693d864f785d2ae662f
Reviewed-on: https://chromium-review.googlesource.com/1145663
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/d2f806b39771e3664711d21c91890ca88b51ec8b/cups/ppd-cache.c

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/2a0545487b4bb01b1e091ce0f858986a2a3b8517

commit 2a0545487b4bb01b1e091ce0f858986a2a3b8517
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:53 2018

Applying cups-2.1.4-raise-log-level-for-desired-features.patch

raise log level for desired features
From: Sean Kau <skau@chromium.org>
Date: Wed, 10 May 2017 17:57:45 -0700

BUG= chromium:865217 
TEST=None

Change-Id: Ib03dbddc558e6f4103fa80e998e347e94022306e
Reviewed-on: https://chromium-review.googlesource.com/1145664
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/2a0545487b4bb01b1e091ce0f858986a2a3b8517/scheduler/main.c
[modify] https://crrev.com/2a0545487b4bb01b1e091ce0f858986a2a3b8517/scheduler/job.c

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/090d74d20730d7b25ea080d505758bda80ac5f15

commit 090d74d20730d7b25ea080d505758bda80ac5f15
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:54 2018

Applying cups-2.1.4-search-filter.patch

NOTE: The applied version of this patch contains a number of commits.
The commit message contains context from each of those commits.

Change-Id: Ia91d1f643680208e61a12e5ab9a1e6c07e85736c

net-print/cups: allow search filter in component mount point.

This allows cupsd/cupstestppd to search filters in non-standard locations (in addition to
/usr/libexec/cups/filter and absolute path). It searches in
/run/imageloader/epson-injket-printer-escpr which holds all mount points of
each component version. cupsdSearchFilterLatest iterates all subdirs in this
folder and compare for the latest version. Then cupsdSearchFilter recursively
search in the latest version folder for the abs path
of filter with 'filter_name'.

For cupsd, it performs search when a filter is not found at standard location.
For cupstestppd, it performs search when a filter is not found at standard location and
skips capitalization test since it fails on squashfs when readdir a string not trailing
with '/'.

Change-Id: Iac216a827b0b5afde0eeafe9a246e7d5ba2de77a

net-print/cups: search filter for star printer

Allow cupsd search for filter in /run/imageloader/star-cups-driver.

Change-Id: Ie72f83aca08c82ade675de05dfefe042272d927e

cups: make internal helper functions static

No new code. Only change the declaration of functions to be static.

Change-Id: Iee1af0eede80aa0be028cb48dcce3e7a58fadc7c

net-print/cups: move components to search into a table

This simplifies the patching process for more filter components in the
future. The only thing to do (presumably) is add 2 additional lines for
filter name and its path.

BUG= chromium:865217 
TEST=None

Change-Id: I27a2a562007458604ca9db8a4a8ce3900a0f05a6
Reviewed-on: https://chromium-review.googlesource.com/1145665
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/090d74d20730d7b25ea080d505758bda80ac5f15/scheduler/job.c
[modify] https://crrev.com/090d74d20730d7b25ea080d505758bda80ac5f15/systemv/cupstestppd.c
[modify] https://crrev.com/090d74d20730d7b25ea080d505758bda80ac5f15/cups/util.c
[modify] https://crrev.com/090d74d20730d7b25ea080d505758bda80ac5f15/cups/cups-private.h

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/c15f75089b4e4b0c15bfa6552556c062888e979e

commit c15f75089b4e4b0c15bfa6552556c062888e979e
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:54 2018

Applying cups-2.1.4-limit-PSVersion-sscanf.patch

cupstestppd.c: limit PSVersion sscanf size and stop at a newline
From: Rory McNamara <git@rorym.cnamara.com>
Date: Wed, 10 May 2017 13:31:00 +0100

BUG= chromium:865217 
TEST=None

Change-Id: I8eb1611308a1942c2f62e6bf9a729dbcad3a9d12
Reviewed-on: https://chromium-review.googlesource.com/1145666
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/c15f75089b4e4b0c15bfa6552556c062888e979e/systemv/cupstestppd.c

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/e370ae41e60f9f99041151a8266635c32a2e46f1

commit e370ae41e60f9f99041151a8266635c32a2e46f1
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:55 2018

Applying cups.2.1.4-ippusb-query.patch

Adding ippusb query path to cups
From: David Valleau <valleau@chromium.org>
Date: Wed, 8 Nov 2017 11:22:05 -0800

BUG= chromium:865217 
TEST=None

Change-Id: I0fd17527c26a1520a9a6ffb0e32ce1e7c1c4a20c
Reviewed-on: https://chromium-review.googlesource.com/1145667
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/e370ae41e60f9f99041151a8266635c32a2e46f1/backend/ipp.c
[modify] https://crrev.com/e370ae41e60f9f99041151a8266635c32a2e46f1/cups/Makefile
[modify] https://crrev.com/e370ae41e60f9f99041151a8266635c32a2e46f1/systemv/lpadmin.c
[add] https://crrev.com/e370ae41e60f9f99041151a8266635c32a2e46f1/cups/ippusb-private.h
[add] https://crrev.com/e370ae41e60f9f99041151a8266635c32a2e46f1/cups/ippusb.c

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/95406929f42777494eadc245becdce5928c281ab

commit 95406929f42777494eadc245becdce5928c281ab
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:55 2018

Applying cups-2.1.4-timeout.patch

Decrease printer connection timeout from a week to 20 seconds. Consider all
failures timeout worthy; no more cases of waiting for a connection forever.

This allows us to use a larger timeout on chrome, allowing ample time for
large print jobs and still catching persistent non-connection failures.

From: Luum Habtemariam <luum@chromium.org>
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=786182

BUG= chromium:865217 
TEST=None

Change-Id: Ibc6d20f80f636489442d2fa3681b0ad30f99a24a
Reviewed-on: https://chromium-review.googlesource.com/1145668
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/95406929f42777494eadc245becdce5928c281ab/backend/ipp.c

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/8916663fedd12f6f8ec3712e77dea80297e88217

commit 8916663fedd12f6f8ec3712e77dea80297e88217
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:56 2018

Applying cups-2.2.2-Tweak-the-PDL-priority-Issue-4932.patch

Tweak the PDL priority ( Issue #4932 )
From: Michael Sweet <michael.r.sweet@gmail.com>
Date: Wed, 14 Dec 2016 09:44:55 -0500

BUG= chromium:865217 
TEST=None

Change-Id: I11a8a6e942879deaedb55b0fd6d92ea5608bbf81
Reviewed-on: https://chromium-review.googlesource.com/1145669
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/8916663fedd12f6f8ec3712e77dea80297e88217/cups/ppd-cache.c

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/5e4c440b996b4670ae9e4791894df1e97d002caf

commit 5e4c440b996b4670ae9e4791894df1e97d002caf
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:56 2018

Applying cups-2.2.2-Only-list-supported-PDLs-Issue-4923.patch

Only list supported PDLs ( Issue #4923 )
From: Michael Sweet <michael.r.sweet@gmail.com>
Date: Wed, 14 Dec 2016 10:02:17 -0500

BUG= chromium:865217 
TEST=None

Change-Id: Ia8b9c6c88b2161fdac3c6cf1a28c1034e978e998
Reviewed-on: https://chromium-review.googlesource.com/1145670
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/5e4c440b996b4670ae9e4791894df1e97d002caf/cups/ppd-cache.c

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/5d7afbeadbc6b058b0a9c1105d9cdd33d3f3f674

commit 5d7afbeadbc6b058b0a9c1105d9cdd33d3f3f674
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:57 2018

Applying cups-2.2.2-no-tests.patch

Removing test dir from cups Makefile
From: David Valleau <valleau@chromium.org>
Date: Thu, 21 Jun 2018 11:03:39 -0700

BUG= chromium:865217 
TEST=None

Change-Id: I3602470a69e761b44d19f6fbb1ff1f73837b02e3
Reviewed-on: https://chromium-review.googlesource.com/1145671
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/5d7afbeadbc6b058b0a9c1105d9cdd33d3f3f674/Makefile

Project Member

Comment 27 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/cups/+/f8dc0f66be7feabdafe48cae46b6a375293d2507

commit f8dc0f66be7feabdafe48cae46b6a375293d2507
Author: David Valleau <valleau@chromium.org>
Date: Tue Jul 31 06:07:57 2018

Applying cups-2.1.4-cups-config-libs.patch

cups-config: only CUPS libraries go in non-static `cups-config --libs`

We're including compression and crypto libraries in the linker flags
output, even when we're built as a shared library. This doesn't make
sense, because callers of cups-config are only looking for their direct
dependencies. If they plan to make any SSL or zlib calls of their own,
they should be managing those flags on their own.

This resolves problems seen in package management, where libcups users
end up inadvertently linking against (e.g.) gnutls directly, without the
package manager being aware. (And thus, it doesn't know to rebuild on
library upgrades.)
---
Sent upstream here:
https://github.com/apple/cups/pull/5261

From: Brian Norris <briannorris@chromium.org>
Date: Thu, 8 Mar 2018 10:30:28 -0800

BUG= chromium:865217 
TEST=None

Change-Id: Iba4884d378bc96b7fab8132d5e89156e5fa4a366
Reviewed-on: https://chromium-review.googlesource.com/1145672
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/f8dc0f66be7feabdafe48cae46b6a375293d2507/cups-config.in

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a11c46a077e28e1d28f84e456fcbf6b57e89b58d

commit a11c46a077e28e1d28f84e456fcbf6b57e89b58d
Author: David Valleau <valleau@chromium.org>
Date: Thu Aug 16 07:30:04 2018

Changing CUPS to use a cros_workon ebuild

This change replaces the old ebuild with a 9999 ebuild which uses the
new cros_workon directory in chromiumos/third_party/cups. This change
also deletes the "files/" directory as all of it's contents have been
moved to the cros_workon directory.

BUG= chromium:865217 
TEST=Built image and tested on device
CQ-DEPEND=CL:1174954

Change-Id: If4eabc944a2df06edb1030554422d75377fc9685
Reviewed-on: https://chromium-review.googlesource.com/1170350
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-strict-filters.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-timeout.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.2-systemd-socket.patch
[add] https://crrev.com/a11c46a077e28e1d28f84e456fcbf6b57e89b58d/net-print/cups/files/chromeos-version.sh
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.0.3-upstart-on-demand.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-cups-config-libs.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-1.6.0-fix-install-perms.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-raise-log-level-for-desired-features.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.2.2-Tweak-the-PDL-priority-Issue-4932.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.0.2-rename-systemd-service-files.patch
[rename] https://crrev.com/a11c46a077e28e1d28f84e456fcbf6b57e89b58d/net-print/cups/cups-9999.ebuild
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.0.1-fix-compilation.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.2-PrinterRoot.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-search-filter.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-ippusb-query.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-usb-device-uris.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/cups-2.1.4-r51.ebuild
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-1.6.0-dont-compress-manpages.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-non-standard-grays.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.0.1-xinetd-installation-fix.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-1.7.2-systemd-socket-2.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.2.2-no-tests.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.1.4-limit-PSVersion-sscanf.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.2.2-Only-list-supported-PDLs-Issue-4923.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.0.3-cross-compile.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-2.0.3-Add-printerroot-to-configure.patch
[delete] https://crrev.com/c970e0ee06a8772669e0be75b4e4f0be9f770326/net-print/cups/files/cups-1.4.4-nostrip.patch

Status: Fixed (was: Started)

Sign in to add a comment