New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865200 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

"File bug" link after reporting not useful should be prepopulated with analyzer owner/component

Project Member Reported by qyears...@chromium.org, Jul 18

Issue description

Now (after  bug 852893 ) there is a "file a bug" link that appears after the "not useful" button is clicked.

Currently it is prepopulated with the Tricium monorail component; but in Analyzer definitions we have more specific per-analyzer owners and monorail components. We want to include those so that bugs filed in this way can be easily routed to the most relevant people.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94

commit cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jul 19 16:29:54 2018

[tricium] Change report not useful API to not include issue URLs

Originally when planning the mechanism for reporting feedback for
analyzers, we were originally considering having the user fill in
a text box in code review, then file an issue on the user's behalf;
later we decided it would be simpler to just give the user a link
to fill out a bug.

This is a preliminary CL to remove a related part of the API that
is unused and that we're not planning to use; after this, the
plan is to change rpc_report.go to return owner/component in
ReportNotUsefulResponse, and to change the plugin to use these
when constructing the URL.

Bug:  865200 
Change-Id: I06bbac44dbea33698cb41761d80a668cc8c138cd
Reviewed-on: https://chromium-review.googlesource.com/1142579
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94/go/src/infra/tricium/api/v1/tricium.proto
[modify] https://crrev.com/cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94/go/src/infra/tricium/appengine/frontend/rpc_feedback.go
[modify] https://crrev.com/cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94/go/src/infra/tricium/appengine/frontend/rpc_feedback_test.go
[modify] https://crrev.com/cb0fe1736d467ae1e5e88226fe2a3e87ee06ae94/go/src/infra/tricium/appengine/frontend/rpc_report.go

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ded22bb88f9f6ac878a6a4680683f74293985446

commit ded22bb88f9f6ac878a6a4680683f74293985446
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jul 20 21:28:06 2018

[tricium] Refactor report not useful handler

This is in preparation for fetching owner/component
and including them in the response.

Bug:  865200 
Change-Id: I56f957ba3fbd0378fd881170a3691f33522b677b
Reviewed-on: https://chromium-review.googlesource.com/1145597
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/ded22bb88f9f6ac878a6a4680683f74293985446/go/src/infra/tricium/appengine/frontend/rpc_report.go
[modify] https://crrev.com/ded22bb88f9f6ac878a6a4680683f74293985446/go/src/infra/tricium/appengine/frontend/rpc_report_test.go

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/14627374a133675c5f46bd7987c2bcacc4f9645d

commit 14627374a133675c5f46bd7987c2bcacc4f9645d
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Jul 23 23:17:50 2018

[tricium] Store owner/component in tracked FunctionRun

In this CL:
 - Add function definitions to generated Workflow in config.Generate
 - Add owner/component to stored FunctionRun entity in WorkflowLaunched handler.

In the Launch RPC, we're already fetching the project and service
configs and getting the function definitions that will be used in
the current run; we can store the owner/component at this point
to avoid having to fetch these things again later on.

If we didn't store things here, then later on when these things are needed,
the configs would have to be fetched & merged later on in order to get the
analyzer owner and component.

Proposed next CL: Add owner/component to ReportNotUsefulReponse;
it would also be possible to put owner/componeont in each commment.

One-pager doc related to this change:
https://docs.google.com/document/d/1-TRt0Wwm-6-eh92eFrQJsYDp_awAuizOZGjPfmrWkkY/edit

Bug:  865200 
Change-Id: Ie35a77ecfce4bfb04044b3948719785f0e357d02
Reviewed-on: https://chromium-review.googlesource.com/1147213
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/api/admin/v1/workflow.pb.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/api/admin/v1/workflow.proto
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/appengine/common/config/validate.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/api/v1/config_helpers_test.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/api/v1/config_helpers.go
[modify] https://crrev.com/14627374a133675c5f46bd7987c2bcacc4f9645d/go/src/infra/tricium/appengine/common/config/generate.go

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/adcd44720e7fc9b77d31c4297a1df1b8d4ad29ef

commit adcd44720e7fc9b77d31c4297a1df1b8d4ad29ef
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Jul 24 17:47:06 2018

[tricium] Send owner and component in ReportNotUsefulResponse

Bug:  865200 
Change-Id: I06fb026e8cee9a93224beebd337ad6c78c87c2b2
Reviewed-on: https://chromium-review.googlesource.com/1147662
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/adcd44720e7fc9b77d31c4297a1df1b8d4ad29ef/go/src/infra/tricium/appengine/frontend/rpc_report.go
[modify] https://crrev.com/adcd44720e7fc9b77d31c4297a1df1b8d4ad29ef/go/src/infra/tricium/appengine/frontend/rpc_report_test.go

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/c3e68055135b44281d8f3532176d5766aeace3b8

commit c3e68055135b44281d8f3532176d5766aeace3b8
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jul 27 17:11:01 2018

[tricium plugin] Fill out more details in Tricium bug report link

Context: After reporting not useful, we show a bug filing link to
make it easier to report issues with analyzers; analyzers may be
owned and maintained by various different teams so we want to make
sure reports go to the right people.

The Tricium service was just changed so that owner and component
information (from analyzer definitions in configs) are sent in the
response after reporting that a comment is not useful.

Bug:  865200 
Change-Id: I77e807d17aabb0bdff8519a3ec9c18ac3c8aa44a
Reviewed-on: https://chromium-review.googlesource.com/1149220
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/c3e68055135b44281d8f3532176d5766aeace3b8/src/main/resources/static/tricium-feedback-button.html
[modify] https://crrev.com/c3e68055135b44281d8f3532176d5766aeace3b8/test/tricium-feedback-button_test.html
[modify] https://crrev.com/c3e68055135b44281d8f3532176d5766aeace3b8/src/main/resources/static/tricium-client.js
[modify] https://crrev.com/c3e68055135b44281d8f3532176d5766aeace3b8/src/main/resources/static/tricium-feedback-button.js

Status: Started (was: Assigned)
Waiting for plugin deployment before confirming.
Status: Fixed (was: Started)
Plugin deployed, verified; but noticed that component is set to Infra>CodeAnalysis instead of Infra>Platform>Tricium, so I'll want to update that.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b931354c0fd1d10c9e956006b4330bee313ceaca

commit b931354c0fd1d10c9e956006b4330bee313ceaca
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Aug 06 18:27:36 2018

Sign in to add a comment