New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865198 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crash when you click on the status area in the bottom right

Project Member Reported by qnnguyen@chromium.org, Jul 18

Issue description

Chrome Version: Tested at commit 4b93e2d451c855b1b8c3fc4df4544451e9bcacf0 (Jul 18, ~3:20pm)
OS: ChromeOS

What steps will reproduce the problem?
(1) Be at the login screen
(2) Click on the bottom right corner (where the battery indicator / clock are)

What is the expected result?
We see the bubble with various controls (brightness, settings button, etc...)

What happens instead?
Crash.

Stack trace:
Received signal 8 FPE_INTDIV 7f90a0ef1386                                                                                                                                                                                                                                                   
#0 0x7f90a7431d3c base::debug::StackTrace::StackTrace()                                                                                                                                                                                                                                     
#1 0x7f90a7431831 base::debug::(anonymous namespace)::StackDumpSignalHandler()                                                                                                                                                                                                              
#2 0x7f909a3650c0 <unknown>                                                                                                                                                                                                                                                                 
#3 0x7f90a0ef1386 ash::TopShortcutButtonContainer::Layout()                                                                                                                                                                                                                                 
#4 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                              
#5 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                              
#6 0x7f90a16299f2 views::BoxLayout::Layout()                                                                                                                                                                                                                                                
#7 0x7f90a16386a0 views::View::Layout()                                                                                                                                                                                                                                                     
#8 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                              
#9 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                              
#10 0x7f90a16299f2 views::BoxLayout::Layout()                                                                                                                                                                                                                                               
#11 0x7f90a16386a0 views::View::Layout()                                                                                                                                                                                                                                                    
#12 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#13 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#14 0x7f90a16299f2 views::BoxLayout::Layout()                                                                                                                                                                                                                                               
#15 0x7f90a16386a0 views::View::Layout()                                                                                                                                                                                                                                                    
#16 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#17 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#18 0x7f90a0efbaa9 ash::(anonymous namespace)::ContainerView::Layout()                                                                                                                                                                                                                      
#19 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#20 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#21 0x7f90a16299f2 views::BoxLayout::Layout()                                                                                                                                                                                                                                               
#22 0x7f90a16386a0 views::View::Layout()                                                                                                                                                                                                                                                    
#23 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#24 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#25 0x7f90a164db52 views::DialogClientView::Layout()                                                                                                                                                                                                                                        
#26 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#27 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#28 0x7f90a1650e5c views::NonClientView::Layout()                                                                                                                                                                                                                                           
#29 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#30 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#31 0x7f90a162b0b8 views::FillLayout::Layout()                                                                                                                                                                                                                                              
#32 0x7f90a16386a0 views::View::Layout()                                                                                                                                                                                                                                                    
#33 0x7f90a1636916 views::View::BoundsChanged()                                                                                                                                                                                                                                             
#34 0x7f90a1635e0d views::View::SetBoundsRect()                                                                                                                                                                                                                                             
#35 0x7f90a1636af9 views::View::SetSize()                                                                                                                                                                                                                                                   
#36 0x7f90a1647758 views::Widget::OnNativeWidgetSizeChanged()                                                                                                                                                                                                                               
#37 0x7f90a2b900c4 aura::Window::OnLayerBoundsChanged()                                                                                                                                                                                                                                     
#38 0x7f90a2ad3a4d ui::Layer::SetBoundsFromAnimation()                                                                                                                                                                                                                                      
#39 0x7f90a2b8c945 aura::Window::SetBoundsInternal()                                                                                                                                                                                                                                        
#40 0x7f90a0f7a98e ash::wm::WmSnapToPixelLayoutManager::SetChildBounds()                                                                                                                                                                                                                    
#41 0x7f90a1663587 views::NativeWidgetAura::CenterWindow()                                                                                                                                                                                                                                  
#42 0x7f90a16455a2 views::Widget::SetInitialBounds()                                                                                                                                                                                                                                        
#43 0x7f90a1644d58 views::Widget::Init()                                                                                                                                                                                                                                                    
#44 0x7f90a15c3e34 views::BubbleDialogDelegateView::CreateBubble()                                                                                                                                                                                                                          
#45 0x7f90a0efac5c ash::UnifiedSystemTrayBubble::UnifiedSystemTrayBubble()                                                                                                                                                                                                                  
#46 0x7f90a0ef9d37 ash::UnifiedSystemTray::UiDelegate::ShowMessageCenter()                                                                                                                                                                                                                  
#47 0x7f9097b91607 message_center::UiController::ShowMessageCenterBubble()                                                                                                                                                                                                                  
#48 0x7f90a0efa883 ash::UnifiedSystemTray::ShowBubble()                                                                                                                                                                                                                                     
#49 0x7f90a0efa80f ash::UnifiedSystemTray::PerformAction()                                                                                                                                                                                                                                  
#50 0x7f90a0ed97d9 ash::ActionableView::ButtonPressed()                                                                                                                                                                                                                                     
#51 0x7f90a15cc0ed views::Button::OnMouseReleased()                                                                                                                                                                                                                                         
#52 0x7f90a15b97b9 views::InkDropHostView::OnMouseEvent()                                                                                                                                                                                                                                   
#53 0x7f90a2e8ee32 ui::ScopedTargetHandler::OnEvent()                                                                                                                                                                                                                                       
#54 0x7f90a2e8a29e ui::EventDispatcher::ProcessEvent()                                                                                                                                                                                                                                      
#55 0x7f90a2e8a043 ui::EventDispatcherDelegate::DispatchEvent()                                                                                                                                                                                                                             
#56 0x7f90a164214d views::internal::RootView::OnMouseReleased()                                                                                                                                                                                                                             
#57 0x7f90a1647cc7 views::Widget::OnMouseEvent()                                                                                                                                                                                                                                            
#58 0x7f90a1664dd6 views::NativeWidgetAura::OnMouseEvent()                                                                                                                                                                                                                                  
#59 0x7f90a2e8a29e ui::EventDispatcher::ProcessEvent()                                                                                                                                                                                                                                      
#60 0x7f90a2e8a043 ui::EventDispatcherDelegate::DispatchEvent()                                                                                                                                                                                                                             
#61 0x7f90a2e8b852 ui::EventProcessor::OnEventFromSource()                                                                                                                                                                                                                                  
  r8: 00000544010bbbc0  r9: 00007f90a74c2c38 r10: 00000543ff3f7fc8 r11: 0000000000000246                                                                                                                                                                                                    
 r12: 0000054400a01c00 r13: 0000000000000138 r14: 0000000000000000 r15: 0000000000000020                                                                                                                                                                                                    
  di: 0000054400f0fa80  si: 00000544010e7020  bp: 00007fffa87431b0  bx: 00000000000000f8                                                                                                                                                                                                    
  dx: 0000000000000000  ax: 00000000000000f8  cx: 00000544010e7040  sp: 00007fffa8743160                                                                                                                                                                                                    
  ip: 00007f90a0ef1386 efl: 0000000000010257 cgf: 002b000000000033 erf: 0000000000000000                                                                                                                                                                                                    
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000                                                                                                                                                                                                                          
[end of stack trace]

I performed a bisect and narrowed it down to this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1139847

As an experiment, I manually changed the code back (i.e. SetVisible -> SetEnabled) and no longer had this issue.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543b9168ee6821aebc8b5e7175a3cdcff539469e

commit 543b9168ee6821aebc8b5e7175a3cdcff539469e
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Jul 20 06:52:21 2018

Revert "Unified: Hide inactive top buttons instead of dim."

This reverts commit f82109c5b3122d5f88a654e3ba3e5b128e59e48c.

Reason for revert: Crash  https://crbug.com/865198 

Original change's description:
> Unified: Hide inactive top buttons instead of dim.
>
> On the login screen, we made the settings button and the lock button
> look dim.
>
> According to UX, we should just make them invisible.
>
> TEST=manual
> BUG=864233
>
> Change-Id: I90fc6853b2735a73d426dbb05b2f693be7ff2ce6
> Reviewed-on: https://chromium-review.googlesource.com/1139847
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575970}

TBR=yoshiki@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864233, 865198 
Change-Id: I4f3d30c529a5ecc5e68c69cb833bfd6a4c8e2c6d
Reviewed-on: https://chromium-review.googlesource.com/1144860
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576800}
[modify] https://crrev.com/543b9168ee6821aebc8b5e7175a3cdcff539469e/ash/system/unified/top_shortcuts_view.cc
[modify] https://crrev.com/543b9168ee6821aebc8b5e7175a3cdcff539469e/ash/system/unified/top_shortcuts_view_unittest.cc

Status: Fixed (was: Untriaged)
Labels: ReleaseBlock-Dev M-69 Merge-Approved-69 OS-Chrome
This fix (revert) did not make the M69 branch point 

https://chromium.googlesource.com/chromium/src/+log/69.0.3497.0..70.0.3498.0?n=10000

@tetsui, please go ahead and merge to M69 
Cc: cindyb@chromium.org kbleicher@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c56b76f02c0d6a47de9c018488cf7451a7048ef

commit 3c56b76f02c0d6a47de9c018488cf7451a7048ef
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Jul 25 00:29:14 2018

Revert "Unified: Hide inactive top buttons instead of dim."

This reverts commit f82109c5b3122d5f88a654e3ba3e5b128e59e48c.

Reason for revert: Crash  https://crbug.com/865198 

Original change's description:
> Unified: Hide inactive top buttons instead of dim.
>
> On the login screen, we made the settings button and the lock button
> look dim.
>
> According to UX, we should just make them invisible.
>
> TEST=manual
> BUG=864233
>
> Change-Id: I90fc6853b2735a73d426dbb05b2f693be7ff2ce6
> Reviewed-on: https://chromium-review.googlesource.com/1139847
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575970}

TBR=yoshiki@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864233, 865198 
Change-Id: I4f3d30c529a5ecc5e68c69cb833bfd6a4c8e2c6d
Reviewed-on: https://chromium-review.googlesource.com/1144860
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576800}(cherry picked from commit 543b9168ee6821aebc8b5e7175a3cdcff539469e)
Reviewed-on: https://chromium-review.googlesource.com/1149380
Reviewed-by: Josafat Garcia <josafat@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#57}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3c56b76f02c0d6a47de9c018488cf7451a7048ef/ash/system/unified/top_shortcuts_view.cc
[modify] https://crrev.com/3c56b76f02c0d6a47de9c018488cf7451a7048ef/ash/system/unified/top_shortcuts_view_unittest.cc

Status: Verified (was: Fixed)
This issue seems to have fixed on M69 (10895.4.0/69.0.3497.13). There isn't any device crash during the OOBE and normal sign in.

Sign in to add a comment