This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I don't know if this report belongs here or in a new or existing crbug, I couldn't find one, please let me know if this needs to go elsewhere.

But, conversely, I cannot 'unzip' archives, even a small 52K one in version 69.0.3494.0 via the 'Zip Archiver'. It *does* work correctly in version 69.0.3486.0.

Also both versions render my 'Wicked Good Unarchiver'inoperative even though it's still enabled.
 

Deleted: JwKJrgd.png 18.8 KB

	JwKJrgd.png 18.8 KB View Download

Yamaguchi san - are you able to take a quick look at this?

unzip file
 works 68.0.3439.0  offical  stable
 works 68.0.3440.74 official beta
 broke 69.0.3494.0  offical  dev

zip file
 works 68.0.3440.74 official beta
 broke 69.0.3494.0  offical  dev

#5 > But, conversely, I cannot 'unzip' archives, even a small 52K one in version 69.0.3494.0 via the 'Zip Archiver'. It *does* work correctly in version 69.0.3486.0.

Ok, that suggests something in here:

https://chromium.googlesource.com/chromium/src/+log/69.0.3486.0..69.0.3494.0?pretty=fuller&n=10000

yamaguchi@ you made no change to zip code in that range above, right?

Re: Comment 5
Thanks for reporting success/failure with version numbers. It would help me investigate either issue. Issue 864256 (restricted) tracks the unzipping issue.

Wicked Good Unarchiver says it can "Open 7z/CAB/CPIO/ISO/pax/rpm/tar files in Files app." in its description. Therefore I don't think it can handle ZIP archives, by design.
https://github.com/vapier/chrome-ext-wicked-good-unarchiver/blob/wgu/unpacker/manifest.json

> yamaguchi@ you made no change to zip code in that range above, right?
Right. I don't think I made any changes to ZIP during that period.

ok thanks, if you'd like to look at issue 864256, that'd be good.  

I can repro the current issue in a local build, and we're bisecting now.

Re: #c10
You're welcome, glad the data points were helpful.

Immediately after I submitted the comment I realized I had forgotten to mention that this was on 'eve' if that makes a difference.

I *thought* Wicked Good Unarchiver was invoked on zip files too but I may be mistaken. I'll ask about this on chromium-os-dev instead so this issue doesn't get off track.

Thanx much.

Yeah good data points.  Another bug mentioned it might be CSP from the logs, so
we split the effort in two:

first part

 - noticed in-range change descriptions mentioned CSP
    see https://chromium-review.googlesource.com/c/chromium/src/+/1129473
 - try adding new self policy field is needed in the Zip Archiver manifest
    https://chromium-review.googlesource.com/c/chromium/src/+/1147893

second part

 - bisection to find the cause (cont)

- bisection to find the cause (cont)
  cause https://chromium-review.googlesource.com/1116065 crrev.com/574196

and ^^^ was a change in CSP affecting chrome extensions and that hit Zip Archiver in this case.

Fix is https://chromium-review.googlesource.com/c/chromium/src/+/1147893

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f53767331d74e75e7e055542951e4d7f2c01f45

commit 5f53767331d74e75e7e055542951e4d7f2c01f45
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Jul 24 06:25:22 2018

Add 'self' to Zip Archiver script-src content security policy

Fix issues where Files app failed to mount .zip files, and also
failed to zip files in M69 dev.

Cause was on the Zip Archiver extension failing to load its own
JS files due the manifest Content Security Policy (CSP) changes
submitted in issue 836412.

Bug: 864256,  865197 , 836412
Change-Id: I8ffd382671deac0a23dfa5688830d9608a919bf5
Reviewed-on: https://chromium-review.googlesource.com/1147893
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577438}
[modify] https://crrev.com/5f53767331d74e75e7e055542951e4d7f2c01f45/chrome/browser/resources/chromeos/zip_archiver/manifest.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe16005a1e102929790edcba2d2e80a1a7a9b702

commit fe16005a1e102929790edcba2d2e80a1a7a9b702
Author: Noel Gordon <noel@chromium.org>
Date: Wed Jul 25 06:43:08 2018

Add FilesAppBrowserTestBase harness support for zip/unzip testing

Add support enabling zip/unzip in the integration test base class. Any
derived class can request support in test by overriding method:

  GetNeedsZipSupport()

The default implementation returns false. Add ZipCase derived from the
TestCase class, and an overriden method, in the FileManagerBrowserTest
class. Future TODO: write test to exercise zip/unzip support.

Bug: 864256, 865197 ,836412
Change-Id: I3dc5b17023506ef3a2fa57611fff16ee68ead43e
Reviewed-on: https://chromium-review.googlesource.com/1149438
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577814}
[modify] https://crrev.com/fe16005a1e102929790edcba2d2e80a1a7a9b702/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/fe16005a1e102929790edcba2d2e80a1a7a9b702/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/fe16005a1e102929790edcba2d2e80a1a7a9b702/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/605757eee32c2873576eec4c69ebade18a4dde8f

commit 605757eee32c2873576eec4c69ebade18a4dde8f
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jul 26 03:26:34 2018

Add FilesApp integration tests for unzipping a zip archive

Add tests cases for unzipping a zip archive from Downloads, Drive, and
a removable volume (USB).

Test: browser_tests --gtest_filter="ZipFiles/FilesApp*"
Bug: 864256, 865197 , 867738 
Change-Id: Iea2d2a8537798d7eb4eab7370862fe27a4054a7e
Reviewed-on: https://chromium-review.googlesource.com/1150008
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578182}
[modify] https://crrev.com/605757eee32c2873576eec4c69ebade18a4dde8f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[add] https://crrev.com/605757eee32c2873576eec4c69ebade18a4dde8f/ui/file_manager/integration_tests/file_manager/zip_files.js
[modify] https://crrev.com/605757eee32c2873576eec4c69ebade18a4dde8f/ui/file_manager/integration_tests/file_manager_test_manifest.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc0182d589d4a8d6c3f07611aa002e388a8d4fca

commit cc0182d589d4a8d6c3f07611aa002e388a8d4fca
Author: Noel Gordon <noel@chromium.org>
Date: Thu Jul 26 14:31:37 2018

Add FilesApp integration tests for zipping a file

Add tests cases for zipping a file: test Downloads, Drive, and USB, to
get the "create-a-zip-file" integration test ball rolling.

Test: browser_tests --gtest_filter="ZipFiles/FilesApp*zipCreate*"
Bug: 864256, 865197 , 867738 
Change-Id: I28c2da7bd5662ef944659c11529d963cf81d48ed
Reviewed-on: https://chromium-review.googlesource.com/1151068
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578295}
[modify] https://crrev.com/cc0182d589d4a8d6c3f07611aa002e388a8d4fca/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/cc0182d589d4a8d6c3f07611aa002e388a8d4fca/ui/file_manager/integration_tests/file_manager/zip_files.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c31ee076595e115c91defce15a25ee3f1cb3f3e

commit 8c31ee076595e115c91defce15a25ee3f1cb3f3e
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Jul 30 00:24:08 2018

Add 'self' to Zip Archiver script-src content security policy

Fix issues where Files app failed to mount .zip files, and also
failed to zip files in M69 dev.

Cause was on the Zip Archiver extension failing to load its own
JS files due the manifest Content Security Policy (CSP) changes
submitted in issue 836412.

Bug: 864256,  865197 , 836412
Change-Id: I8ffd382671deac0a23dfa5688830d9608a919bf5
Reviewed-on: https://chromium-review.googlesource.com/1147893
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577438}(cherry picked from commit 5f53767331d74e75e7e055542951e4d7f2c01f45)
Reviewed-on: https://chromium-review.googlesource.com/1154587
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#197}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/8c31ee076595e115c91defce15a25ee3f1cb3f3e/chrome/browser/resources/chromeos/zip_archiver/manifest.json

verified in 69.0.3497.21/10895.10.0(Paine,Cave),  69.0.3497.24/10895.11.0(Banjo)