New issue
Advanced search Search tips

Issue 865167 link

Starred by 1 user
Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 862573
issue 865071


Sign in to add a comment

several browser_tests fail in Chrome-branded builds

Project Member Reported by inglorion@chromium.org, Jul 18 
The following tests pass when is_chrome_branded is false, but fail when it is true:

SigninSyncConfirmationTest.DialogWithDice
ProfileChooserViewExtensionsTest.IncrementDiceSigninPromoShowCounter
LocalNTPMDTest.LoadsMDIframe
ProfileChooserViewExtensionsTest.DiceSigninPromoWithoutIllustration

Example failing build: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1854

PDFTestFiles/PDFExtensionLoadTest.Load/8 also failed in that build, but succeeded for me locally.

Comment 1 by inglorion@chromium.org, Jul 18

Labels: Restrict-View-Google

Comment 2 by inglorion@chromium.org, Jul 18

Summary: several browser_tests fail in Chrome-branded builds (was: several browser_tests are flaky in Chrome-branded builds)

Comment 3 by inglorion@chromium.org, Jul 18 

Bugs for individual tests:

All that mention Dice: https://crbug.com/862573
LocalNTPMDTest.LoadsMDIframe: httsp:// crbug.com/865071 

The latter one seems to have a fix incoming.

The former seems stalled. I'll disable the associated tests for now.

Comment 4 by thakis@chromium.org, Jul 19

Blockedon: 862573 865071
Labels: -Restrict-View-Google Build-Official
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599fff692e9fb04bb63da66d00fa41f8251fba4a

commit 599fff692e9fb04bb63da66d00fa41f8251fba4a
Author: inglorion <inglorion@chromium.org>
Date: Thu Jul 19 17:38:00 2018

Temporarily disable browser_tests that fail with is_chrome_branded

This disables the following tests when is_chrome_branded is true:
ProfileChooserViewExtensionsTest.DiceSigninPromoWithoutIllustration
ProfileChooserViewExtensionsTest.IncrementDiceSigninPromoShowCounter
SigninSyncConfirmationTest.DialogWithDice

Bug 862573 is open to fix those, but until that fix lands, this will
make the bots green so that we don't shadow other issues.

Bug: 865167,862573
Change-Id: Ic6e94f780de5dab7137281acdc0e1ba552337a6c
Reviewed-on: https://chromium-review.googlesource.com/1142609
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576551}
[modify] https://crrev.com/599fff692e9fb04bb63da66d00fa41f8251fba4a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/599fff692e9fb04bb63da66d00fa41f8251fba4a/chrome/test/data/webui/signin/signin_browsertest.js
►

Sign in to add a comment