Chrome SU deprecation |
|||||||||||
Issue descriptionWe want to deprecate SU on Chrome (not Chrome OS for now). The following steps are required MilestoneN > Send notification or butterbar to users to announce feature removal MilestoneN+1 > Remove the feature For MilestoneN, we need to implement a butter bar with the following text: "Supervised user profiles will no longer be supervised after XX-XX-XXXX. Learn More" Learn More should point to a page similar to this one (https://support.google.com/chrome/answer/3463947?hl=en) and explain what this means.
,
Jul 19
,
Jul 19
,
Jul 19
,
Jul 19
To avoid redundancy in the butter bar text, could we use something more like: "Supervised user profiles will no longer be available starting <date>. Learn more" or the HC text: "You can no longer create or use supervised profiles, starting XX-XX-XXXX. Learn more"
,
Jul 19
Note that we can't put in an exact date, as we don't know when the stable update will be pushed. What about something like "Supervised user profiles will no longer be available starting with Chrome 70 (October 2018)"?
,
Jul 19
Of course, that makes sense. It's perfectly acceptable to omit any mention of a date and just put the release #: "Supervised user profiles will no longer be available starting with Chrome 70. Learn more"
,
Jul 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe951b0f670092797822da96d50d3e56a66e8957 commit fe951b0f670092797822da96d50d3e56a66e8957 Author: Jochen Eisinger <jochen@chromium.org> Date: Sun Jul 22 09:38:28 2018 Show an infobar to supervised users announcing EOL in M70 Bug: 865157 Change-Id: I6d04148640812e4a2de80866fee1545bd2ef1868 Reviewed-on: https://chromium-review.googlesource.com/1141874 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577091} [modify] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/chrome/app/chromium_strings.grd [modify] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/chrome/browser/ui/startup/startup_browser_creator_impl.cc [add] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/chrome/browser/ui/startup/supervised_users_deprecated_infobar_delegate.cc [add] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/chrome/browser/ui/startup/supervised_users_deprecated_infobar_delegate.h [modify] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/components/infobars/core/infobar_delegate.h [modify] https://crrev.com/fe951b0f670092797822da96d50d3e56a66e8957/tools/metrics/histograms/enums.xml
,
Jul 22
,
Jul 23
marking this as fixed for the purpose of the merge request
,
Jul 23
This bug requires manual review: There is .grd file changes and we are only 42 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 23
this change is in 70.0.3500.0 I verified it again using the same steps I used for local testing when developing the CL. The change is safe to merge (and critical for 69)
,
Jul 23
Approving merge to M69 branch 3497 based on comment #12. Please merge ASAP. Thank you.
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5f0036dc0323358c39d481777ec1169d2f4056b commit c5f0036dc0323358c39d481777ec1169d2f4056b Author: Jochen Eisinger <jochen@chromium.org> Date: Mon Jul 23 18:32:40 2018 Show an infobar to supervised users announcing EOL in M70 Bug: 865157 TBR=jochen@chromium.org (cherry picked from commit fe951b0f670092797822da96d50d3e56a66e8957) Change-Id: I6d04148640812e4a2de80866fee1545bd2ef1868 Reviewed-on: https://chromium-review.googlesource.com/1141874 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577091} Reviewed-on: https://chromium-review.googlesource.com/1147220 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#19} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/chrome/app/chromium_strings.grd [modify] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/chrome/browser/ui/startup/startup_browser_creator_impl.cc [add] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/chrome/browser/ui/startup/supervised_users_deprecated_infobar_delegate.cc [add] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/chrome/browser/ui/startup/supervised_users_deprecated_infobar_delegate.h [modify] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/components/infobars/core/infobar_delegate.h [modify] https://crrev.com/c5f0036dc0323358c39d481777ec1169d2f4056b/tools/metrics/histograms/enums.xml
,
Jul 25
Tested this issue on Windows 10 on the build without fix 69.0.3486.0 and unable to create a supervised user on M-69 build as this feature is deprecated. jochen@ Could you please help on how to verify this CL manually? Thanks..
,
Jul 25
it's no longer possible to create SU profiles since a while :/ To verify, I manually set the "managed_user_id" key in a profile's Preferences file to foo, as well as in the Local State cache. I'm not sure what the value of retaking these steps as at this point... |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by kuscher@chromium.org
, Jul 18