New issue
Advanced search Search tips

Issue 865155 link

Starred by 2 users
Status: Fixed
Owner:
weili@chromium.org
Closed: Jul 19
Cc:
sdy@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MacViews-Browser] Fullscreen toolbar should only slide up after mouse leaves

Reported by jleedev@gmail.com, Jul 18 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3495.0 Safari/537.36

Steps to reproduce the problem:
1. Enter full screen
2. Move mouse to top of screen — menubar and toolbar slide down
3. Try to interact with the toolbar

What is the expected behavior?
The toolbar stays where it is until the mouse moves off the bottom

What went wrong?
The toolbar slides back up while the mouse is still over the toolbar

Did this work before? Yes 

Chrome version: 69.0.3495.0  Channel: canary
OS Version: OS X 10.13.6
Flash Version: 

Forked from Issue 831219
(Cocoa bug from long ago was  Issue 418413 )
good.mov
3.2 MB View Download
bad.mov
4.9 MB View Download

Comment 1 by meh...@chromium.org, Jul 18

Cc: sdy@chromium.org ellyjo...@chromium.org
Components: -UI UI>Browser>FullScreen
Labels: Proj-MacViews
Owner: weili@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks. Assigning to weili@ since you are working on the macOS Fullscreen Mode for MacViews.

Comment 2 by weili@chromium.org, Jul 18

Status: Started (was: Assigned)
I noticed this too. Will fix soon.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1406837c85633743729c75ec61f02e45b852f1f2

commit 1406837c85633743729c75ec61f02e45b852f1f2
Author: Wei Li <weili@chromium.org>
Date: Thu Jul 19 17:10:31 2018

[MacViews] Track mouse and position content correctly in fullscreen

During full screen mode, we need to track mouse movement around top UI
to lock the system menu bar. This CL sets up the correct area for such
tracking.

Also, when system menu bar slides down in full screen, only the top UI
will appears under the menu bar while the position of web content should
not move.

BUG= 864931 , 865155 , 831219

Change-Id: Ie121e6f27dd24066c1ae1e133740f01c75f118a5
Reviewed-on: https://chromium-review.googlesource.com/1142694
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576533}
[modify] https://crrev.com/1406837c85633743729c75ec61f02e45b852f1f2/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/1406837c85633743729c75ec61f02e45b852f1f2/chrome/browser/ui/views/frame/browser_view_layout.cc

Comment 4 by weili@chromium.org, Jul 19

Status: Fixed (was: Started)

Comment 5 by viswa.karala@chromium.org, Jul 20

Labels: TE-Verified-69.0.3497.0 TE-Verified-M69
Able to reproduce the issue on chrome version 69.0.3495.0(build without fix)
Verified the fix on Mac 10.12.6 using Chrome version #69.0.3497.0 as per the comment #0.
Attaching screenshot for reference.
Observed "Toolbar stays in same place until the mouse moves to the bottom"
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks!
865155.mp4
805 KB View Download
►

Sign in to add a comment