New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865140 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit 19 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocking:
issue 863984



Sign in to add a comment

Implementation: Changing the word "Incognito" to "Private"

Project Member Reported by jianli@chromium.org, Jul 18

Issue description

Experiment with changing the word "Incognito" to "Private" for users in select countries. The goal is to understand whether changing the string to a more commonly-understood word increases usage of the feature.
 
Owner: ----
I believe this was assigned to me by mistake.
Owner: jianli@chromium.org
Blocking: 863984
Summary: Implementation: Changing the word "Incognito" to "Private" (was: Changing the word "Incognito" to "Private")
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cebdc85e758cc7429c70db5e362cf06b13d694a7

commit cebdc85e758cc7429c70db5e362cf06b13d694a7
Author: Jian Li <jianli@chromium.org>
Date: Wed Aug 01 21:54:18 2018

Experiment updating the UI strings to replace "incognito" to "private"

Launch bug: 863984

Bug: 865140
Change-Id: I1b67dd974d2eb5e15965d830c2fb304f8e9501a8
Reviewed-on: https://chromium-review.googlesource.com/1153837
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579957}
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/LauncherShortcutActivity.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/src/org/chromium/chrome/browser/widget/incognitotoggle/IncognitoToggleButton.java
[modify] https://crrev.com/cebdc85e758cc7429c70db5e362cf06b13d694a7/chrome/android/java/strings/android_chrome_strings.grd

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844900c43c80ec2c9e6a736beb835f42cfc8a69c

commit 844900c43c80ec2c9e6a736beb835f42cfc8a69c
Author: Jian Li <jianli@chromium.org>
Date: Fri Aug 03 19:31:08 2018

More UI string updates for experiment changing incognito to private

Launch bug: 863984

Bug: 865140
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I021aa78fd002dc74a8c9965afce1906bdff7acdb
Reviewed-on: https://chromium-review.googlesource.com/1161217
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580625}
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/app/vr_strings.grdp
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/browser/about_flags.cc
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/common/chrome_features.cc
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/chrome/common/chrome_features.h
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/components/new_or_sad_tab_strings.grdp
[modify] https://crrev.com/844900c43c80ec2c9e6a736beb835f42cfc8a69c/components/payments_strings.grdp

Sign in to add a comment