iPad tab switcher menu is displayed at wrong position in RTL |
||||||||||
Issue descriptionApp Version: 69.0.3495.0 canary iOS Version: 12.0, 11.4.1 Device: iPad Pro 9", 10.5" URL: NA Precondition: Set iOS Device language to RTL Steps to reproduce: 1. Launch Google Chrome 2. Long press on the tab counter icon Observed results: Pop-up menu is displayed at the wrong location Expected results: Popup menu should be displayed correctly Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Link to video/image: https://drive.google.com/file/d/1uKnQpMyV81YoslpbzSy23UWywaumV8Ox/view
,
Jul 19
Assigning to Justin as it is because the layout guide for the TabGrid button isn't correctly positioned.
,
Jul 21
,
Jul 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d4ead66ffa0647fe19506b55e4d439bbd1e6b99 commit 7d4ead66ffa0647fe19506b55e4d439bbd1e6b99 Author: Justin Cohen <justincohen@google.com> Date: Sun Jul 22 03:50:57 2018 [ios] Fix tab strip rtl long press frame. Bug: 865119 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2a6fdb250075d14306eb4f581b8443f05632d8f Reviewed-on: https://chromium-review.googlesource.com/1145851 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577088} [modify] https://crrev.com/7d4ead66ffa0647fe19506b55e4d439bbd1e6b99/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
,
Jul 23
,
Jul 23
This bug requires manual review: Less than -2 days to go before AppStore submit on M68 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 23
Oops, I meant M69.
,
Jul 23
,
Jul 23
Verified on M70.0.3500.0 canary iOS: 11.4.1, iPad Pro 9" Languages: HE, AR AR: https://drive.google.com/file/d/1wLFYRfi0f1EpdtcrbhL0CfZeohLe-hf3/view HE: https://drive.google.com/file/d/1vHGblne6L_jyR4cjKN6FPx8njdCzDI7A/view
,
Jul 23
Approved!
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3d63c6c7c02b5c1ac547fb6798a7d93644d280f commit b3d63c6c7c02b5c1ac547fb6798a7d93644d280f Author: Justin Cohen <justincohen@google.com> Date: Mon Jul 23 16:11:41 2018 [ios] Fix tab strip rtl long press frame. Bug: 865119 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic2a6fdb250075d14306eb4f581b8443f05632d8f Reviewed-on: https://chromium-review.googlesource.com/1145851 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577088}(cherry picked from commit 7d4ead66ffa0647fe19506b55e4d439bbd1e6b99) Reviewed-on: https://chromium-review.googlesource.com/1146781 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#15} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/b3d63c6c7c02b5c1ac547fb6798a7d93644d280f/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
,
Jul 25
Verified in: App Version: 69.0.3497.7 beta Devices: iPad Pro iOS Versions: 11.4.1 iPad tab switcher pop up menu is displayed at right position when device language is set to any RTL language. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by marq@chromium.org
, Jul 19Labels: -Pri-2 M-69 Q2 Pri-1
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Summary: iPad tab switcher menu is displayed at wrong position in RTL (was: Popup menu is displayed at wrong position in RTL)