New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865116 link

Starred by 1 user
Status: Verified
Owner:
█ elalish@chromium.org
Last visit 20 days ago
Closed: Dec 27
Cc:
tiborg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 853890


Sign in to add a comment

[Standalone VR Browsing] After transition to 2D Chrome dialog, user isn't returned back to VR browsing, they remain in 2D mode.

Project Member Reported by dbbrooks@chromium.org, Jul 18 
Chrome Version: 69.0.3495.0
OS: O
Device: Lenovo standalone VR Headset

What steps will reproduce the problem?
(1) Open Chrome and go to wikipedia.org
(2) Click on the security lock icon in the Omnibox.
(3) Click on the "Details" link in the infobar.
(4) Click on the "what do these mean?" link in the infobar

What is the expected result? Page link is opened in VR browser, not 2D Chrome.

What happens instead? Chrome renders in 2D in a very tall window. The user remains in this view for further browsing. Unless they exit and return to Chrome.
Screenshot_20180718_111751.jpg
102 KB View Download

Comment 1 by mthiesse@chromium.org, Jul 18

Blockedon: 853890
Cc: tiborg@chromium.org
Status: Available (was: Untriaged)
Let's re-assess once we have Tab support and can do something more reasonable here.

(Note that the tall window is a known platform bug that we can't fix as Chrome)

Comment 2 by dbbrooks@chromium.org, Jul 23 

I'd like to tack one more thing to this bug.

1. Got to chrome:flags page.
2. change one flag (example enable webxr)
3. Press the Relaunch Now button.

Chrome restarts in 2D mode. See screenshot.
Screenshot_20180723_074413.jpg
67.6 KB View Download

Comment 3 by dbbrooks@chromium.org, Nov 5

Labels: -Pri-3 Pri-2
Summary: [Standalone VR Browsing] After transition to 2D Chrome dialog, user isn't returned back to VR browsing, they remain in 2D mode. (was: [Standalone VR Browsing] Viewing site details link 'what do these mean' launches very tall 2D Chrome window)

Comment 4 by elalish@chromium.org, Dec 26

Owner: elalish@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab88d1c2892e9f0fdc938d2755a984be3fdf4269

commit ab88d1c2892e9f0fdc938d2755a984be3fdf4269
Author: Emmett Lalish <elalish@chromium.org>
Date: Thu Dec 27 20:04:14 2018

When Chrome in VR launches Chrome, make that instance also in VR

Chrome in 2D mode on the Vega headset already worked properly (popup Chrome windows are in the same 2D mode of the browser). Now Chrome in VR mode on the headset (and Chrome in SVR) will show those popups in VR Chrome, to keep the experience functional and consistent.

Bug:  865116 
Change-Id: Ie20b9c8050716d766fd5b6385730fc5ea8002821
Reviewed-on: https://chromium-review.googlesource.com/c/1391421
Commit-Queue: Emmett Lalish <elalish@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619061}
[modify] https://crrev.com/ab88d1c2892e9f0fdc938d2755a984be3fdf4269/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Comment 6 by elalish@chromium.org, Dec 27

Status: Fixed (was: Started)

Comment 7 by elalish@chromium.org, Dec 27 

Issue 881347 has been merged into this issue.

Comment 8 by dbbrooks@chromium.org, Jan 4

Status: Verified (was: Fixed)
Verified and opened comment #2 issue in new bug 919141.
Chrome 73.0.3659.0
Now clicking the "What do these mean" links in security indicator info dialog opens a page in VRB, not 2D Chrome.
►

Sign in to add a comment