New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865114 link

Starred by 1 user
Status: Started
Owner:
█ scottwu@chromium.org
Last visit > 30 days ago
Cc:
ios-bugs@chromium.org
█ ichikawa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Implement passwords in //ios/web_view

Project Member Reported by jzw@chromium.org, Jul 18 
Tracking bug for implementing passwords in //ios/web_view.

Comment 1 by scottwu@chromium.org, Jul 19

Labels: -Type-Bug Type-Feature
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51c0f00e8182544953f424c929304e27fd149caf

commit 51c0f00e8182544953f424c929304e27fd149caf
Author: Scott Wu <scottwu@chromium.org>
Date: Thu Jul 26 01:52:01 2018

Move js password manager into component folder, so that it can be shared by ios web view.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaf96f48918f1a8556e3f7de94cc2f2470034245e
Reviewed-on: https://chromium-review.googlesource.com/1149663
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578165}
[add] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/components/password_manager/ios/BUILD.gn
[add] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/components/password_manager/ios/DEPS
[rename] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/components/password_manager/ios/js_password_manager.h
[rename] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/components/password_manager/ios/js_password_manager.mm
[modify] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/ios/chrome/browser/DEPS
[modify] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/51c0f00e8182544953f424c929304e27fd149caf/ios/chrome/browser/passwords/password_controller_unittest.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1

commit 550a1c4ab1034d8f0b114cec6e62092b34b9b2c1
Author: Scott Wu <scottwu@chromium.org>
Date: Fri Aug 03 08:50:26 2018

Add password autofill client and factory classes to ios web view.

Note:
This CL is almost a clone of https://chromium-review.googlesource.com/c/chromium/src/+/1060634
by removing cwv_password_controller and fixing conflicts.

Bug:865114

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I318fba363d7f6edd8d7b187b29d7e500955f498e
Reviewed-on: https://chromium-review.googlesource.com/1149778
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580481}
[modify] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/BUILD.gn
[modify] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/DEPS
[modify] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/cwv_preferences_unittest.mm
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/mock_credentials_filter.h
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/mock_credentials_filter.mm
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_manager_client.h
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_manager_client.mm
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_manager_driver.h
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_manager_driver.mm
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_manager_internals_service_factory.h
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_manager_internals_service_factory.mm
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_store_factory.h
[add] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/passwords/web_view_password_store_factory.mm
[modify] https://crrev.com/550a1c4ab1034d8f0b114cec6e62092b34b9b2c1/ios/web_view/internal/web_view_browser_state.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e35c0a03fef63a03497491233a5cdcf52e27a1ed

commit e35c0a03fef63a03497491233a5cdcf52e27a1ed
Author: Scott Wu <scottwu@chromium.org>
Date: Tue Aug 07 09:23:17 2018

Move password form serialization logic into components folder

The purpose is to share this logic with both ios chrome and ios web view

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id6f16a05eb3408238c2772b420ec408e499ed2e8
Reviewed-on: https://chromium-review.googlesource.com/1151181
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581180}
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/BUILD.gn
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/BUILD.gn
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/DEPS
[rename] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/account_select_fill_data.cc
[rename] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/account_select_fill_data.h
[rename] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/account_select_fill_data_unittest.cc
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/js_password_manager.h
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/js_password_manager.mm
[rename] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/test_helpers.cc
[rename] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/components/password_manager/ios/test_helpers.h
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/e35c0a03fef63a03497491233a5cdcf52e27a1ed/ios/chrome/browser/passwords/password_controller_unittest.mm
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357385134e69d6e6a2ec3a36841007f2398a3f62

commit 357385134e69d6e6a2ec3a36841007f2398a3f62
Author: Scott Wu <scottwu@chromium.org>
Date: Thu Aug 23 01:36:55 2018

Create password controller helper for common logic.

This CL creates the skeleton of common password controller and moves FormActivityObserver related logic into it`.
The goal is to move common password autofill logics into components folder so that they can be shared by both Chrome iOS and //ios/web_view.

> Moved webState and jsPasswordManager into helper class.
> Moved FormActivityObserver logic into helper class.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2dbfdb1cb4f0bdf22bf1d5c37451f46682addcac
Reviewed-on: https://chromium-review.googlesource.com/1156528
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585356}
[modify] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/components/password_manager/ios/BUILD.gn
[modify] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/components/password_manager/ios/DEPS
[add] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/components/password_manager/ios/password_controller_helper.h
[add] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/components/password_manager/ios/password_controller_helper.mm
[add] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/components/password_manager/ios/password_controller_helper_unittest.mm
[modify] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/357385134e69d6e6a2ec3a36841007f2398a3f62/ios/chrome/browser/passwords/password_controller_unittest.mm
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37cb83a643b9384f8ede1684f439f83ad38fff05

commit 37cb83a643b9384f8ede1684f439f83ad38fff05
Author: Scott Wu <scottwu@chromium.org>
Date: Mon Aug 27 11:52:59 2018

Move password_controller.js to components folder.

Note: In order to provide __crWeb.passwords, looks like the password_controller.js file needs to be included in js_compile targets as source file.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9a2447259247c58a86b36a354737fdd7ab1fa443
Reviewed-on: https://chromium-review.googlesource.com/1168959
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586234}
[rename] https://crrev.com/37cb83a643b9384f8ede1684f439f83ad38fff05/components/password_manager/ios/resources/password_controller.js
[modify] https://crrev.com/37cb83a643b9384f8ede1684f439f83ad38fff05/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/37cb83a643b9384f8ede1684f439f83ad38fff05/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/37cb83a643b9384f8ede1684f439f83ad38fff05/ios/web_view/BUILD.gn
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ae8802f80ea7d81ce951944a8c0a71f0b26a946

commit 9ae8802f80ea7d81ce951944a8c0a71f0b26a946
Author: Scott Wu <scottwu@chromium.org>
Date: Mon Aug 27 13:29:59 2018

Add unit test for password controller helper.

Bug: 865114
Change-Id: I74a77252b7280f2e85df56f3ce7f4a0fd28b9873
Reviewed-on: https://chromium-review.googlesource.com/1169028
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586244}
[modify] https://crrev.com/9ae8802f80ea7d81ce951944a8c0a71f0b26a946/components/password_manager/ios/BUILD.gn
[modify] https://crrev.com/9ae8802f80ea7d81ce951944a8c0a71f0b26a946/components/password_manager/ios/password_controller_helper_unittest.mm
[add] https://crrev.com/9ae8802f80ea7d81ce951944a8c0a71f0b26a946/components/password_manager/ios/resources/test_bundle.js
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4

commit 74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4
Author: Scott Wu <scottwu@chromium.org>
Date: Tue Aug 28 07:58:12 2018

Move password form finding logic to components.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ieee1dc88df8b3c5533b050bda4f71e7b27588df1
Reviewed-on: https://chromium-review.googlesource.com/1170681
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586617}
[modify] https://crrev.com/74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4/components/password_manager/ios/password_controller_helper.h
[modify] https://crrev.com/74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4/components/password_manager/ios/password_controller_helper_unittest.mm
[modify] https://crrev.com/74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/74da6a1d49ba4b80d0729a0d5b8e5b595460f2f4/ios/chrome/browser/passwords/password_controller_unittest.mm
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d40eeb4b7b8220c147fbf24315382a913aa4150

commit 9d40eeb4b7b8220c147fbf24315382a913aa4150
Author: Scott Wu <scottwu@chromium.org>
Date: Fri Aug 31 10:56:21 2018

Move password filling logic into components.

Note: Unit test will be added in https://chromium-review.googlesource.com/c/chromium/src/+/1195292.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I91e187ae90b7515cc3bc37cdd80bdfbf33ae5ca1
Reviewed-on: https://chromium-review.googlesource.com/1195246
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587986}
[modify] https://crrev.com/9d40eeb4b7b8220c147fbf24315382a913aa4150/components/password_manager/ios/password_controller_helper.h
[modify] https://crrev.com/9d40eeb4b7b8220c147fbf24315382a913aa4150/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/9d40eeb4b7b8220c147fbf24315382a913aa4150/ios/chrome/browser/passwords/password_controller.mm
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9e7c5c52197afe2c33a868b7742abc285d7fcf

commit ff9e7c5c52197afe2c33a868b7742abc285d7fcf
Author: Scott Wu <scottwu@chromium.org>
Date: Tue Sep 04 16:04:12 2018

Add unit test for password filling logic

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5617f95e83c661d046e1a9d148362c2b436d2240
Reviewed-on: https://chromium-review.googlesource.com/1195292
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588528}
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/BUILD.gn
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/account_select_fill_data_unittest.cc
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/password_controller_helper_unittest.mm
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/test_helpers.cc
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/test_helpers.h
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/ios/chrome/browser/passwords/password_controller_unittest.mm
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9e7c5c52197afe2c33a868b7742abc285d7fcf

commit ff9e7c5c52197afe2c33a868b7742abc285d7fcf
Author: Scott Wu <scottwu@chromium.org>
Date: Tue Sep 04 16:04:12 2018

Add unit test for password filling logic

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5617f95e83c661d046e1a9d148362c2b436d2240
Reviewed-on: https://chromium-review.googlesource.com/1195292
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588528}
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/BUILD.gn
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/account_select_fill_data_unittest.cc
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/password_controller_helper_unittest.mm
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/test_helpers.cc
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/test_helpers.h
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/ios/chrome/browser/passwords/password_controller_unittest.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9e7c5c52197afe2c33a868b7742abc285d7fcf

commit ff9e7c5c52197afe2c33a868b7742abc285d7fcf
Author: Scott Wu <scottwu@chromium.org>
Date: Tue Sep 04 16:04:12 2018

Add unit test for password filling logic

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5617f95e83c661d046e1a9d148362c2b436d2240
Reviewed-on: https://chromium-review.googlesource.com/1195292
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588528}
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/BUILD.gn
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/account_select_fill_data_unittest.cc
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/password_controller_helper.mm
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/password_controller_helper_unittest.mm
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/test_helpers.cc
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/components/password_manager/ios/test_helpers.h
[modify] https://crrev.com/ff9e7c5c52197afe2c33a868b7742abc285d7fcf/ios/chrome/browser/passwords/password_controller_unittest.mm

Comment 13 by pe...@bockenhauer.com, Sep 5 

Is this bug report related to Chrome on iOS not always successfully filling credentials from password manager apps like 1Password? I understand Chrome utilizes it’s own implementation for password managers and does not use the same that Safari uses. So sometimes the password field populates, but not the username or sometimes neither.

Comment 14 by scottwu@chromium.org, Sep 5 

Sorry Peter, this bug is not related to that problem

Comment 15 by pe...@bockenhauer.com, Sep 5 

Thanks Scott. Are you aware of a bug that covers that overall issue? I can find many bugs that go back many years that address on a per site basis, but that’s ridiculous.

Comment 16 by scottwu@chromium.org, Sep 5 

May be crbug.com/472248 ?
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8062b71bf9902e71568f902e40cc932a34627a03

commit 8062b71bf9902e71568f902e40cc932a34627a03
Author: Scott Wu <scottwu@chromium.org>
Date: Tue Sep 11 00:50:53 2018

Enable basic password autofill functionality for ios web view - Save password after login and autofill password form when going back to the login page.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4f6e3f40500bb667959110d5f0eb3f07c85bca94
Reviewed-on: https://chromium-review.googlesource.com/1198672
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590146}
[modify] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/BUILD.gn
[modify] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/internal/DEPS
[modify] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/internal/cwv_web_view.mm
[add] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/internal/passwords/cwv_password_controller.mm
[add] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/internal/passwords/cwv_password_controller_internal.h
[add] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/public/cwv_password_controller.h
[modify] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/public/cwv_web_view_autofill.h
[add] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/public/cwv_web_view_password.h
[modify] https://crrev.com/8062b71bf9902e71568f902e40cc932a34627a03/ios/web_view/shell/shell_view_controller.m
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca71f697a5b66f86a6178c4d551fadf107a05cac

commit ca71f697a5b66f86a6178c4d551fadf107a05cac
Author: Scott Wu <scottwu@chromium.org>
Date: Thu Oct 04 01:52:29 2018

Extend autofill controller delegate for password autofilling logic in //ios/web_view.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I48e317b989129cf391ece111df72f98eb62504d1
Reviewed-on: https://chromium-review.googlesource.com/c/1226950
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596478}
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/BUILD.gn
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/internal/cwv_web_view.mm
[add] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/internal/passwords/cwv_password_controller.h
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/internal/passwords/cwv_password_controller.mm
[delete] https://crrev.com/f72b33988e4c2f9423741fd1cc0977f450955cae/ios/web_view/internal/passwords/cwv_password_controller_internal.h
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/public/cwv_autofill_controller.h
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/public/cwv_autofill_controller_delegate.h
[delete] https://crrev.com/f72b33988e4c2f9423741fd1cc0977f450955cae/ios/web_view/public/cwv_password_controller.h
[delete] https://crrev.com/f72b33988e4c2f9423741fd1cc0977f450955cae/ios/web_view/public/cwv_web_view_password.h
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/shell/shell_autofill_delegate.m
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/shell/shell_view_controller.m
[modify] https://crrev.com/ca71f697a5b66f86a6178c4d551fadf107a05cac/ios/web_view/test/web_view_autofill_inttest.mm
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a4429e3b49acb3be07a11697d3d9680f08e616

commit b9a4429e3b49acb3be07a11697d3d9680f08e616
Author: Scott Wu <scottwu@chromium.org>
Date: Fri Oct 12 10:34:30 2018

Move password suggestion logic into components.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
Reviewed-on: https://chromium-review.googlesource.com/c/1264455
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599165}
[modify] https://crrev.com/b9a4429e3b49acb3be07a11697d3d9680f08e616/components/password_manager/ios/BUILD.gn
[add] https://crrev.com/b9a4429e3b49acb3be07a11697d3d9680f08e616/components/password_manager/ios/password_suggestion_helper.h
[add] https://crrev.com/b9a4429e3b49acb3be07a11697d3d9680f08e616/components/password_manager/ios/password_suggestion_helper.mm
[modify] https://crrev.com/b9a4429e3b49acb3be07a11697d3d9680f08e616/ios/chrome/browser/passwords/password_controller.mm
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/830919bab9ae548252386c0e0b2bb97b4a22152e

commit 830919bab9ae548252386c0e0b2bb97b4a22152e
Author: Scott Wu <scottwu@chromium.org>
Date: Fri Oct 12 10:44:43 2018

Rename PasswordControllerHelper to PasswordFormHelper

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
Reviewed-on: https://chromium-review.googlesource.com/c/1278670
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599167}
[modify] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/components/password_manager/ios/BUILD.gn
[rename] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/components/password_manager/ios/password_form_helper.h
[rename] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/components/password_manager/ios/password_form_helper.mm
[rename] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/components/password_manager/ios/password_form_helper_unittest.mm
[modify] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/components/password_manager/ios/password_suggestion_helper.h
[modify] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/830919bab9ae548252386c0e0b2bb97b4a22152e/ios/web_view/internal/passwords/cwv_password_controller.mm
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5707fca76b36b8801cbb004196a29ccd4675276d

commit 5707fca76b36b8801cbb004196a29ccd4675276d
Author: Scott Wu <scottwu@chromium.org>
Date: Wed Oct 17 10:37:28 2018

Implement password suggestion in //ios/web_view

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0a7d78359724a4e4cdca350145b55b65e5d4f184
Reviewed-on: https://chromium-review.googlesource.com/c/1250503
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600341}
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/autofill/cwv_autofill_suggestion.mm
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/autofill/cwv_autofill_suggestion_internal.h
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/autofill/cwv_autofill_suggestion_unittest.mm
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/passwords/cwv_password_controller.h
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/internal/passwords/cwv_password_controller.mm
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/public/cwv_autofill_controller.h
[modify] https://crrev.com/5707fca76b36b8801cbb004196a29ccd4675276d/ios/web_view/shell/shell_autofill_delegate.m
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff76ba3afad56f725aadfefab14e8f491900649

commit 5ff76ba3afad56f725aadfefab14e8f491900649
Author: Scott Wu <scottwu@chromium.org>
Date: Fri Oct 19 01:43:31 2018

Change checkIfSuggestionsAvailableForForm to return YES for password fields when form matched.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Idf883678744f87a7d431154608242d0ed0ec7e91
Reviewed-on: https://chromium-review.googlesource.com/c/1288309
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601017}
[modify] https://crrev.com/5ff76ba3afad56f725aadfefab14e8f491900649/components/password_manager/ios/password_suggestion_helper.h
[modify] https://crrev.com/5ff76ba3afad56f725aadfefab14e8f491900649/components/password_manager/ios/password_suggestion_helper.mm
[modify] https://crrev.com/5ff76ba3afad56f725aadfefab14e8f491900649/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/5ff76ba3afad56f725aadfefab14e8f491900649/ios/web_view/internal/passwords/cwv_password_controller.mm
►

Sign in to add a comment