New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 865112 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 900579



Sign in to add a comment

Add graphics autotest for hw overlays and HTML Canvas

Project Member Reported by mcasas@chromium.org, Jul 18

Issue description

HTML Canvases can and should be promoted to overlays when the
right conditions are present, we can land an autotest that
verifies that this is happening where it's happening and that
monitors for regressions.
I propose naming them sth like graphics_HwOverlays.*
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5

commit 87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Jul 24 19:44:14 2018

autotest: add graphics_HwOverlay tests

This CL adds a new autotest for checking if 2D/3D HTML canvases
are correctly promoted to overlays. Counting the number of
overlays is added to the graphics_utils.py file; the rest is
a combination of a py file and control and html files.

Note that it needs a flag to work on ToT, which is passed to
Chrome, and that it should work on Rockchip (w/o screen rotation)
but not on Intel (WIP).

crrev.com/c/1144481 plugs it into autotest-chrome.

Bug:  865112 
Change-Id: I22d71cf45799378e2574c33b0d389348711b0d23
Reviewed-on: https://chromium-review.googlesource.com/1142349
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[add] https://crrev.com/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5/client/site_tests/graphics_HwOverlays/canvas_3d.html
[modify] https://crrev.com/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5/client/cros/graphics/graphics_utils.py
[add] https://crrev.com/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5/client/site_tests/graphics_HwOverlays/graphics_HwOverlays.py
[add] https://crrev.com/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5/client/site_tests/graphics_HwOverlays/canvas_2d.html
[add] https://crrev.com/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5/client/site_tests/graphics_HwOverlays/control.canvas2D
[add] https://crrev.com/87b5a69cf8000a0f2d40ff0c068e5bee3ad4faf5/client/site_tests/graphics_HwOverlays/control.canvas3D

dcastagna@ would it be interesting to add similar tests to prevent
regressions of video playback ?
Yes it would, in particular it would be useful to test a NV12.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a1d7250e809743ff2c16fca91513fde7a8ac0db8

commit a1d7250e809743ff2c16fca91513fde7a8ac0db8
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed Jul 25 07:14:33 2018

autotest-chrome: Add graphics_HwOverlays

This CL adds graphics_HwOverlays to autotest-chrome.

BUG= chromium:865112 
CQ-DEPEND=CL:1142349
Change-Id: Ieeed50bdd2358f9eb30edf059038fde3695ac773
Reviewed-on: https://chromium-review.googlesource.com/1144481
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/a1d7250e809743ff2c16fca91513fde7a8ac0db8/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Comment 6 Deleted

Labels: LowLatency
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/990115c86e6dbb2d3d7a6dc26baf84be7a306323

commit 990115c86e6dbb2d3d7a6dc26baf84be7a306323
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Aug 07 08:50:49 2018

autotest: skip graphics_HwOverlays test if DRM atomic isn't supported

This CL supersedes crrev.com/c/1153450 and crrev.com/c/1153848, and
merges them both into a single two-pronged check.  This CL:

- Adds a graphics_utils.is_drm_atomic_supported() to detect if
any DRM device file supports the "atomic" capability. The ioctl
is based on the Chromium DrmDeviceHandle() code [1].
  This method also double checks if any of the necessary
/sys/kernel/debug/dri/... files are present.

- Skips the graphics_HwOverlays test if said function says false
(this is to skip boards that have no overlays support at all and
by design - old kernels etc).

- Corrects test flags to use --enable-experimental-web-platform-features,
 allowing (many) canvas2D tests to pass.

[1] https://cs.chromium.org/chromium/src/ui/ozone/platform/drm/host/drm_device_handle.cc?sq=package:chromium&dr=CSs&g=0&l=71

BUG= chromium:865112 
Change-Id: I1ff77fba16b8aaf3403dcca253edf59c2a1ec2d7
Reviewed-on: https://chromium-review.googlesource.com/1159197
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>

[modify] https://crrev.com/990115c86e6dbb2d3d7a6dc26baf84be7a306323/client/site_tests/graphics_HwOverlays/graphics_HwOverlays.py
[modify] https://crrev.com/990115c86e6dbb2d3d7a6dc26baf84be7a306323/client/cros/graphics/graphics_utils.py

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/799c525881f994920356712ba6a79ac9ce07420d

commit 799c525881f994920356712ba6a79ac9ce07420d
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Aug 09 03:46:08 2018

autotest: add video to graphics_HwOverlays

This CL adds a new test case to graphics_HwOverlays.py to verify
that a large video gets promoted to Hw overlay (this has regressed
a number of times in the past).

A VP9 video is chosen for starters, more codecs prob coming.

Bug:  865112 
Change-Id: I3256ab498706e744a0cdafa6d3eb92633e1e59cd
Reviewed-on: https://chromium-review.googlesource.com/1153460
Commit-Ready: Miguel Casas <mcasas@chromium.org>
Tested-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pohsien Wang <pwang@chromium.org>

[modify] https://crrev.com/799c525881f994920356712ba6a79ac9ce07420d/client/site_tests/graphics_HwOverlays/canvas_3d.html
[add] https://crrev.com/799c525881f994920356712ba6a79ac9ce07420d/client/site_tests/graphics_HwOverlays/video.html
[add] https://crrev.com/799c525881f994920356712ba6a79ac9ce07420d/client/site_tests/graphics_HwOverlays/control.video
[modify] https://crrev.com/799c525881f994920356712ba6a79ac9ce07420d/client/site_tests/graphics_HwOverlays/canvas_2d.html
[modify] https://crrev.com/799c525881f994920356712ba6a79ac9ce07420d/client/site_tests/graphics_HwOverlays/graphics_HwOverlays.py

Blocking: 900579

Sign in to add a comment