New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 865104 link

Starred by 1 user
Status: Fixed
Owner:
█ donnd@chromium.org
(OOO slow)
Closed: Aug 2
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[TTS] Send the URL and clear the cookie when anonymous URL collection is on

Project Member Reported by donnd@google.com, Jul 18 
Contextual Search will get better results when the URL is send in the Resolve request, but for privacy reasons we cannot always do so.

As part of Unity integration, and upcoming logging changes on the server side this is getting somewhat complicated.  

In short, we want to send the URL whenever we can to get better results.  However the server will sometimes log the URL and since it's considered privacy-sensitive we need to be careful when that's done.  Currently we use the GAIA sign-in as a requirement to log.  In order to not log when anonymous URL collection is on we need to clear the GAIA cookie when sending the Resolve request, or add another parameter to that request indicating if privacy-sensitive logging should be done.

More background in issue 825428.

Comment 1 by donnd@google.com, Jul 24 

I figured out how to clear the cookie using the current URLFetcher class (used by ContextualSearchDelegate), by cribbing off of suggestions_service (https://cs.chromium.org/chromium/src/components/suggestions/suggestions_service_impl.cc?type=cs&q=setrequestcontext+file:suggestions&sq=package:chromium&g=0&l=458).

Comment 2 by donnd@google.com, Jul 24 

Another option is to crib off of GoC and switch to SimpleURLLoader. https://cs.chromium.org/chromium/src/components/ntp_snippets/contextual/contextual_suggestions_fetch.cc?q=do_not_send_cookies+file:contextual&sq=package:chromium&dr=C&l=180
Probably simplest and safest to stick with URLFetcher.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a9c0de65dca59bba902ac892ec7cf4ac462f40f

commit 2a9c0de65dca59bba902ac892ec7cf4ac462f40f
Author: Donn Denman <donnd@chromium.org>
Date: Thu Aug 02 19:03:14 2018

[TTS] Update Resolve URL sending, remove cookies.

Updates the sending of the Resolve request to no longer include cookies,
and to only include the URL when the Unified Conset helper's anonymous
data collection is enabled.

BUG= 865104 , 825428

Change-Id: Id33afbcca55ddafcade925d5e717ce1167701ae2
Reviewed-on: https://chromium-review.googlesource.com/1155839
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580274}
[modify] https://crrev.com/2a9c0de65dca59bba902ac892ec7cf4ac462f40f/chrome/browser/android/contextualsearch/contextual_search_delegate.cc

Comment 4 by donnd@google.com, Aug 2

Status: Fixed (was: Assigned)
►

Sign in to add a comment