New issue
Advanced search Search tips

Issue 865102 link

Starred by 1 user
Status: Fixed
Owner:
alexilin@chromium.org
Closed: Jul 23
Cc:
mattcary@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 795291



Sign in to add a comment

Convert device::GamepadSharedBuffer to the new shared memory API

Project Member Reported by alexilin@chromium.org, Jul 18 
The deprecated base::SharedMemory is used in device/gamepad/gamepad_shared_buffer.h

GamepadSharedBuffer is shared as read-only, so it should be replaced with base::ReadOnlySharedMemoryRegion.

There is an outstanding  issue 670655  with the intention to convert the base::SharedMemory to the mojo::SharedBuffer in GamepadSharedBuffer. It couldn't be done because the gamepad buffer is also sent to Pepper and Pepper doesn't work with mojo. However, Pepper already supports the new shared memory API, so this attempt should be successful.

This change touches files in following directories:
- device/gamepad/*
- ppapi/proxy/*
- third_party/blink/renderer/modules/gamepad/*
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce671509c922ab463f3c2c9aff736745ade2850

commit 1ce671509c922ab463f3c2c9aff736745ade2850
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Thu Jul 19 20:59:35 2018

device: Convert GamepadSharedBuffer to the new shared memory API

This CL replaces all uses of base::SharedMemory and base::SharedMemoryRegion
with the new shared memory classes. New classes can be used both in the
renderer and the ppapi plugin processes.

Bug:  865102 
Change-Id: I4ccc52990a0aa8a65ac701b92c45b792188506f8
Reviewed-on: https://chromium-review.googlesource.com/1142161
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576622}
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/content/browser/renderer_host/pepper/pepper_gamepad_host.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/content/shell/test_runner/gamepad_controller.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/content/shell/test_runner/gamepad_controller.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_monitor.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_provider.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_provider_unittest.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_service.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_service.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_shared_buffer.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/gamepad_shared_buffer.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/public/mojom/BUILD.gn
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/device/gamepad/public/mojom/gamepad.mojom
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/ppapi/proxy/gamepad_resource.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/ppapi/proxy/gamepad_resource.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/ppapi/proxy/resource_message_params.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/ppapi/proxy/resource_message_params.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/third_party/blink/renderer/modules/gamepad/gamepad_shared_memory_reader.cc
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/third_party/blink/renderer/modules/gamepad/gamepad_shared_memory_reader.h
[modify] https://crrev.com/1ce671509c922ab463f3c2c9aff736745ade2850/third_party/blink/tools/audit_non_blink_usage.py

Comment 2 by alexilin@chromium.org, Jul 23

Status: Fixed (was: Started)
►

Sign in to add a comment